From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36BAC45B88; Fri, 25 Oct 2024 23:46:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC18940264; Fri, 25 Oct 2024 23:46:36 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id E282D4021F for ; Fri, 25 Oct 2024 23:46:35 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e30fb8cb07so1824706a91.3 for ; Fri, 25 Oct 2024 14:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729892795; x=1730497595; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=N577jYbhmCARLyowaC6jJ7WG3kyDEAh8bMsz+9OAX3Q=; b=P7sPLwXr2dVLJ1kf+WObFV1fkzhTdYiQ3IyW32Z2re71KE71VNHt6U1iqTkD/Li35y CTWAjPLgm1SoKv709+fD+QHh74XueccDY1fLgYpkjgxUkGJTZ6xPSEhJScWR67acLP/J XH235TaRgK0wCKItArF6KNAqJHKBMqn/9AoTbPnYTVyyeeDs+O7WFbjOFnLuZdmXhjRY zPwQd6z+azle4GixzPk7GNAi1uYuklFaFuf94+hZu9yVgB+YKhcJSr+IdjuHWLmJglZu ib8E6h9UbjqZ2TfZ4fEuyqlFTwzs77BQP5ByfNDxe03TY7CyFuXdgxpjcLpniLlqyBWy cuTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729892795; x=1730497595; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=N577jYbhmCARLyowaC6jJ7WG3kyDEAh8bMsz+9OAX3Q=; b=qCWWJrePVzJL0FgOOfoEH/N667rLUMCfU+s0NOf3z3rjbtov66zlRXOiOIJyi6atN5 zUmKX39SB2C8OWkjlgboY5PsAlTDTPm6twANuMMRSaJT+MQxKJDmUUZAcIDOMoZK6NDP ea150r4k1xdhRaHAuZgVM4mR8kcQPGbsEjuJ8mHDAMfC74j7vvbkc+8e+MD1buZANQD5 KVrnATUL1luuj4Y1booKloln/XVWaGi0SSVjy9CNvJuz6fDkX1x3EJ3z9zRS6OC+iJ6l m7T4owqXXjfugKx+iQ78PYXqI6iZon+1diVhFjMo30LCWH4q168bnih9bXZgRyeRerKg n0rg== X-Gm-Message-State: AOJu0YyU/ADCyrUnBAd+zXWIKBc9eeG/pUeuoiXHA70SxcYGGXUKNnRL 9232BkXRT6zp7L4bWku2UHHJNRWLAhuYkE7lF9smBl6uNSlQjyP02eqHOv5gfVYri0luF2H5fAX t X-Google-Smtp-Source: AGHT+IH66LTkCEhnSwbE3cK5Gf038npfJCGVwDfnJl077cpna4In/abrWw5MHshdNVcPcFwYensx3w== X-Received: by 2002:a17:90b:3849:b0:2e0:ab57:51ec with SMTP id 98e67ed59e1d1-2e8f11a82c9mr973451a91.30.1729892794921; Fri, 25 Oct 2024 14:46:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e77e4c9c1bsm4049934a91.19.2024.10.25.14.46.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 14:46:34 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v29 00/13] Logging subsystem enhancements Date: Fri, 25 Oct 2024 14:45:05 -0700 Message-ID: <20241025214625.62876-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20200814173441.23086-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Improvements and unification of logging library. This version works on all platforms: Linux, Windows and FreeBSD. This is update to rework patch set. It adds several new features to the console log output. * Putting a timestamp on console output which is useful for analyzing performance of startup codes. Timestamp is optional and must be enabled on command line. * Displaying console output with colors. It uses the standard conventions used by many other Linux commands for colorized display. The default is to enable color if the console output is going to a terminal. But it can be always on or disabled by command line flag. This default was chosen based on what dmesg(1) command does. Color is used by many tools (vi, iproute2, git) because it is helpful; DPDK drivers and libraries print lots of not very useful messages. And having error messages highlighted in bold face helps. This might also get users to pay more attention to error messages. Many bug reports have earlier messages that are lost because there are so many info messages. * Add support for automatic detection of systemd journal protocol. If running as systemd service will get enhanced logging. * Use of syslog is optional and the meaning of the --syslog flag has changed. The default is *not* to use unless requested. Add myself as maintainer for log because by now have added more than previous authors. v29 - address review feedback and change wording of release note If a log stream is set with rte_open_log_stream() then none of the other stuff happens (syslog, journal, timestamp, or color) Stephen Hemminger (13): maintainers: add for log library windows: make getopt functions have const properties windows: update os shim eal: make eal_log_level_parse common eal: do not duplicate rte_init_alert() messages eal: change rte_exit() output to match rte_log() log: rework syslog handling eal: initialize log before everything else log: add hook for printing log messages log: add timestamp option log: add support for systemd journal log: colorize log output doc: add release note about log library MAINTAINERS | 1 + app/test/test_eal_flags.c | 66 ++++- .../freebsd_gsg/freebsd_eal_parameters.rst | 27 ++ .../prog_guide/env_abstraction_layer.rst | 6 +- doc/guides/prog_guide/log_lib.rst | 57 ++++- doc/guides/rel_notes/release_24_11.rst | 20 ++ lib/eal/common/eal_common_debug.c | 6 +- lib/eal/common/eal_common_options.c | 122 +++++---- lib/eal/common/eal_internal_cfg.h | 1 - lib/eal/common/eal_options.h | 5 + lib/eal/freebsd/eal.c | 65 ++--- lib/eal/linux/eal.c | 68 +---- lib/eal/windows/eal.c | 50 +--- lib/eal/windows/getopt.c | 23 +- lib/eal/windows/include/getopt.h | 8 +- lib/eal/windows/include/rte_os_shim.h | 10 + lib/log/log.c | 83 ++++-- lib/log/log_color.c | 214 ++++++++++++++++ lib/log/log_freebsd.c | 12 - lib/log/log_internal.h | 22 +- lib/log/log_journal.c | 152 +++++++++++ lib/log/log_linux.c | 61 ----- lib/log/log_private.h | 53 ++++ lib/log/log_syslog.c | 108 ++++++++ lib/log/log_timestamp.c | 240 ++++++++++++++++++ lib/log/log_windows.c | 18 -- lib/log/meson.build | 12 +- lib/log/version.map | 5 +- 28 files changed, 1163 insertions(+), 352 deletions(-) create mode 100644 lib/log/log_color.c delete mode 100644 lib/log/log_freebsd.c create mode 100644 lib/log/log_journal.c delete mode 100644 lib/log/log_linux.c create mode 100644 lib/log/log_private.h create mode 100644 lib/log/log_syslog.c create mode 100644 lib/log/log_timestamp.c delete mode 100644 lib/log/log_windows.c -- 2.45.2