From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5CF3545B88; Fri, 25 Oct 2024 23:47:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1829140693; Fri, 25 Oct 2024 23:46:52 +0200 (CEST) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id CAEB840651 for ; Fri, 25 Oct 2024 23:46:44 +0200 (CEST) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2e2dcf4b153so1832848a91.1 for ; Fri, 25 Oct 2024 14:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729892804; x=1730497604; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UfF5OFU4THEiQH/INtpTpQBZpms6s7Uvj06coYmX7Vo=; b=bfeUxUH7M/xLVCCgKBxD7fjYiwXsUrDesBP5SbwVpTQskYiC2LUC/IvKSCwXHVn6/L U9+0524GMUmQn0uIDdu1baLCXC1BYhd4aP39+2XUXnPTCB5jh6/oh2N0DFyL8j3NkWfK o1ZREshBTT0o/3TYZq+Brj+LzE/gYfkAMY/r6rkVlPeyk4VdxzHzY/p0vcawzCVK8MdC lIWEyXuri9PN5aLTVavEPa8QZ3wER9bOK5qiVyCWjw2DGD8VNAW9zMb2tuPMfuhtq3hn kBC6niHrGiJ+NMtyfXSRp6acsVBoPxas78JxXdztxugLvUJEf2hjIsUkHumNi7NZL8rF 0B+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729892804; x=1730497604; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UfF5OFU4THEiQH/INtpTpQBZpms6s7Uvj06coYmX7Vo=; b=Z9i7jG6afJCRWC8R+iM2qxgY/mq2ckjX0xplZNHoNdl0Oo1t4Fgj+ee8JuodxYefAf qB8MtZZUsYpHXnCzgcdkb4Q/XT1Wa2Nk8zSBgB+jHp/Tf7E1w6/uJkYbXHgN97RIDTi2 APpHhNduGeQtiJkaTNy2A5wZR/NMJA3VkAt+1mFwxha+LW9gocmuItNnst+msR/f/bfB gOx7p2QJdXRlqcz5PC7IBjF8rK1L5jVp3YWW/lhxzMONo+SzRnple0HarJAn3aKHu5eN RL7x42tjAB65IbkL8UnM/PDEpKbr2lqQkitZ2jWcRZf1NwgRDC5ZCcuA+WN/YU/4rxVD SmkQ== X-Gm-Message-State: AOJu0YyKC8n/4Hi7G8oB904hpkwjMF9MaZUpgoUn5CXDE4fY4D7nmuwf E9n47cPVo4JJTotuxY5M7PfVDrhU6vm/5UuqjYvadAfE+17/Omj4CCee8tBKmguzMIvTpuU1wQ2 y X-Google-Smtp-Source: AGHT+IFHHsr2j/R7mPjQgE2y1Xe4K0K6iYWu5+XKD4iB3sgl/3gxn7C916Ib4W/TJiL0NKNh5CVOhg== X-Received: by 2002:a17:90a:d807:b0:2da:9115:15ce with SMTP id 98e67ed59e1d1-2e8f106d6bdmr936101a91.15.1729892803993; Fri, 25 Oct 2024 14:46:43 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e77e4c9c1bsm4049934a91.19.2024.10.25.14.46.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 14:46:43 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng , Dmitry Kozlyuk Subject: [PATCH v29 05/13] eal: do not duplicate rte_init_alert() messages Date: Fri, 25 Oct 2024 14:45:10 -0700 Message-ID: <20241025214625.62876-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241025214625.62876-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241025214625.62876-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- lib/eal/windows/eal.c | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 40d750ed0d..c53a051405 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -830,8 +830,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index a77e590a72..93f099a968 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -181,7 +181,6 @@ sync_func(void *arg __rte_unused) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); EAL_LOG(ERR, "%s", msg); } -- 2.45.2