From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6332945B88; Fri, 25 Oct 2024 23:47:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E42140A6F; Fri, 25 Oct 2024 23:46:53 +0200 (CEST) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 4CD0C40674 for ; Fri, 25 Oct 2024 23:46:46 +0200 (CEST) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20cdb889222so23266375ad.3 for ; Fri, 25 Oct 2024 14:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729892805; x=1730497605; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=MIztN1tWqmUrbpDd/IvhJNV0A1jRgO3QJebJ63qt99WPxbj2Hh/zxME1pwavSpjoSl 55rl1pbQfPcTL7ODTSna//rqAI2F+1XEmhoaBOozlINsAAsumSKYrmRDXxaJReJ/hGFG NqtlgTWmboDyuPthQ6o6i3qNmYiSPQLDXzWyzwSLn9FppNkvB7k9k0JpFMtgyKSehZgu TPNYW/FIGed6kAiBi25lkXTQFUamUa9UjrlKgBv7guqRPqhmxPmAtaYanSXh8rsb+Tyo sbAmTzaNaRYEz+U/qu37AXY2icNRPfo5Ogg8qHroIkNYgmp89S5VRDI2EPFhAqLYI5N3 mpQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729892805; x=1730497605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o2d4foqEUlKX8e/d7INvNR8WQ2O85ZJBZV4qHltV3dM=; b=HxEEhUDcc1ON65TzyWxgDZSPpzGiF16v3VcpVAHQmnzhYVMKdTGCzl15Kryai2aKaA zr0STgzbrL3vwVw64arl6Lm2wGaaGVbuqcAuKUMZyNqk6RgGUCQeFB/g6qKY3YVXwkY5 PJI3O0TjxY90ER+xrLWcsnwqXfu1pFP4QQpNOf1z87xrgxLXI8VdU5vZ1H6OboJRMB0y sXmSVURfCARBiH5Xde3jSjEVYdHgP5mjrfd7n6iH4AYekxn7cdMocQAqBWoVPf6T3tyO d6cCaFvT+6fnCmRZagdCb2Oe7H4Rpg2ihWdhLg9yrseWw4q5KUX7xF71mXTuoRFGUchf Yu4w== X-Gm-Message-State: AOJu0YyrW7fhVILpGceIBEKhpIbSfv/tvPzcksZxlsP6rJDKCcjryMin mPe1Ys4b3hYuiaE44ELwx1VJy7KWEfd90inuXU/pdM5NUImq97hKX1kxZKNCWPCv7a06hcnmi5f E X-Google-Smtp-Source: AGHT+IEc95nptxh3nDLbh4go6GHKrbBBjSlFN6vfaN+xeUkLgaQq9I8MJ2Lqy2/lnusRTsKpHEw69w== X-Received: by 2002:a17:90a:d807:b0:2d3:c638:ec67 with SMTP id 98e67ed59e1d1-2e8f0d4d3bfmr917955a91.0.1729892805264; Fri, 25 Oct 2024 14:46:45 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e77e4c9c1bsm4049934a91.19.2024.10.25.14.46.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2024 14:46:44 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng Subject: [PATCH v29 06/13] eal: change rte_exit() output to match rte_log() Date: Fri, 25 Oct 2024 14:45:11 -0700 Message-ID: <20241025214625.62876-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241025214625.62876-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241025214625.62876-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_exit() output format confuses the timestamp and coloring options. Change it to use be a single line with proper prefix. Before: [ 0.006481] EAL: Error - exiting with code: 1 Cause: [ 0.006489] Cannot init EAL: Permission denied After: [ 0.006238] EAL: Error - exiting with code: 1 [ 0.006250] EAL: Cannot init EAL: Permission denied Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/common/eal_common_debug.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lib/eal/common/eal_common_debug.c b/lib/eal/common/eal_common_debug.c index 3e77995896..bcfcd6df6f 100644 --- a/lib/eal/common/eal_common_debug.c +++ b/lib/eal/common/eal_common_debug.c @@ -36,15 +36,13 @@ rte_exit(int exit_code, const char *format, ...) va_list ap; if (exit_code != 0) - RTE_LOG(CRIT, EAL, "Error - exiting with code: %d\n" - " Cause: ", exit_code); + EAL_LOG(CRIT, "Error - exiting with code: %d", exit_code); va_start(ap, format); rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); va_end(ap); if (rte_eal_cleanup() != 0 && rte_errno != EALREADY) - EAL_LOG(CRIT, - "EAL could not release all resources"); + EAL_LOG(CRIT, "EAL could not release all resources"); exit(exit_code); } -- 2.45.2