From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78ECA45BEC; Sun, 27 Oct 2024 04:09:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9D6B40614; Sun, 27 Oct 2024 04:08:44 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 7175640614 for ; Sun, 27 Oct 2024 04:08:42 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7ed9c16f687so2466913a12.0 for ; Sat, 26 Oct 2024 20:08:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729998521; x=1730603321; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=bDqZQiolA+ifqYLfxgOmHQmi5l/thqQ/BrequNyeGbY=; b=PVOL1SJr7UMmX7H1rmHIWc12h0UzAML7Fa5ec7ZKzoQlIljTNaO+eaUWGn4EaSVCM5 ljQdI+0wMDLLjKRvpcui/uG3Yd3J+2DEP+/6UUUcH5w+0C5Unh2UyZTrXZVf9KBQRfDe oFGRVx9n+H/QVOKeFlSmvOk8NZJjEe9TpYRaEzyQkq2AYrh6tqHkVn+vWJgv27tTklUV HNLpFtgouvvKf6rVPMZeUAVmC3jt9Wpo5MkhpTyciXt3C2HXU2oNz4JvnuilDFCF0kN+ KUg2HMzw/mq7DpeCEaWWaxgw9sxrAB5MAi7VFpONe0BFDza1Ur3cSK6jibprPeg7WvAi 1rQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729998521; x=1730603321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bDqZQiolA+ifqYLfxgOmHQmi5l/thqQ/BrequNyeGbY=; b=b7JtVdouCo5N8rtJSXLA6aSUzGzib4DblOTs8vqcqkAmOczofvyOUvfXdDww7hc4aX zL+PJ2JyxIEF0Hq047UDN9YEriwVKpmOlmjnIHVXVBRyM/VtBsskhnOJCBkSB6NxynsU tyvUA2RRtbcVKJOGWmRdjB9t7Rto6PEn98WiNhRPltuHlF9UVYTuZnNIH4RvxSaHRpfr Cu1JDk6siSxqJSeOoNqASw3omqINIAu1IfdeVfP3rYs/NqF8ewvdBWgMxLiYV+aFKmHw ACZnqif0LLltLDOWnQBczFm/ksFrFTuB3PIhAutSY89G9Lfr9wsgZRU5ztU6QMCCrHPC 0CbA== X-Gm-Message-State: AOJu0YwT5AiSecVrmYzRJutWYVr26b1pfExmhWABbDkrfh+iwsHHGJvx EzBepG7nWAbYzuplejpTT6qbU1rH7cAIVX2ta2Xf6eP6amUjt/Faq9zY7w4EdWc= X-Google-Smtp-Source: AGHT+IETvdxxXnwCZ8KgMhDfY5o6EWJ11D/eecKuG2BUElZYCg749NgP0Xs5NrDl77mBIeuhK/dQIg== X-Received: by 2002:a05:6a20:2d23:b0:1d9:1cea:2e3e with SMTP id adf61e73a8af0-1d9a84bcd96mr6162408637.31.1729998521547; Sat, 26 Oct 2024 20:08:41 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057931766sm3384534b3a.49.2024.10.26.20.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 20:08:41 -0700 (PDT) Date: Sat, 26 Oct 2024 20:00:30 -0700 From: Stephen Hemminger To: Jie Hai Cc: , , , Chengwen Feng , Kevin Laatz , Bruce Richardson , Conor Walsh , Sean Morrissey , , Subject: Re: [PATCH v4 01/13] dmadev: replace strtok with reentrant version Message-ID: <20241026200030.1f492187@hermes.local> In-Reply-To: <20241026101451.29135-2-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241026101451.29135-1-haijie1@huawei.com> <20241026101451.29135-2-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 26 Oct 2024 18:14:39 +0800 Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. >=20 > The strtok() is non-reentrant, it is better to replace it with a > reentrant version. >=20 > Fixes: 39b5ab60df30 ("dmadev: add telemetry") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jie Hai > Acked-by: Chengwen Feng > Acked-by: Morten Br=C3=B8rup No reason to bother stable with this one. That function is only called from RTE_INIT() which is a constructor.