From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BE1645BEC; Sun, 27 Oct 2024 04:08:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4E0740279; Sun, 27 Oct 2024 04:08:33 +0100 (CET) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id E066540272 for ; Sun, 27 Oct 2024 04:08:32 +0100 (CET) Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-7edb6879196so1920346a12.3 for ; Sat, 26 Oct 2024 20:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729998512; x=1730603312; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Sd8VwZo8M2DcKL/CSt393cDdP1zPB1K8NrziBjUwV+o=; b=Zcnx4Np+EdqSzPK+HZnprnerMrxA6N92u/xQNaUfrbZWGVU25Sp+gRwj8Tl9RME6iE obN+uq0YHQxmheZ2va3YtpFT+q4gLS5/PAYMBIZkLMbv09+XPc9U9kncUDiVR9jHpNnn keLoIsO4Oq1NrkQKP6SRbc9DBMXXZjAzLKHzNRjdNEjorSEX4JzhUXuoldAdoVpgJ2W1 eMNtiyVbxLaf2Dnb8LxQ0qoErHzU6v26hmiY6z35RNtM7SNtVpbs6WhsOWEajmQuBs6E hRudt8HbKKeeBnTcFa0EYDW6C1SZN3l7nriQZBcqf4MB+rV7j+OHuV9IePGAr304ZB+i k7lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729998512; x=1730603312; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sd8VwZo8M2DcKL/CSt393cDdP1zPB1K8NrziBjUwV+o=; b=Qy9CgfL0HT204qOb4JzWuUfZjvNTIBTV6RLf88MiM8/imveMtA/qQ5mZAAXV+jBQDM mPuUxVGuQ6WdYRWdt/epXbnReuVIF5HeMXrRh/EQ5VNbIvMmtc0qQO2jKaVfhrafDP9x NIi9yeVv1gBS5+/wcSzGxORw6GYp6rFw8ZXJ8H5cAlz534Ehh3SZ09BXSo6SCV4Am0nj 0abdrtXx0bOhCm+ZB+5jUYA0qGCXpCg9jvOsRSo285KrGSoBWVEa76Wy74zMhzp3DrhR VKIvCgQ4v1ZTCecNiAdzXVz9NYzT2xPawirLW7aVR+0u7GSk2Z4usoEgq9U939w9DjgU moSg== X-Gm-Message-State: AOJu0Yxp1UbdLmBDKWmeFGJn7GX/4cEa+WyuvJBlfuqI++dq6zm173pn W+BwZZy9EPzhE3jetEgFOqJw+1OsvXScucCoaT7yRGomJEsT7mPTWySQiKaMIOs= X-Google-Smtp-Source: AGHT+IFv/ebaO4eNY16KSJnKLFToBb9gcOBxLTXiB9571sbA4bIRkLuSFupa/aBgT19K0ENGoL06cQ== X-Received: by 2002:a05:6a20:c793:b0:1d5:144b:5941 with SMTP id adf61e73a8af0-1d9a840afc8mr5875460637.28.1729998511615; Sat, 26 Oct 2024 20:08:31 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057931766sm3384534b3a.49.2024.10.26.20.08.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 20:08:31 -0700 (PDT) Date: Sat, 26 Oct 2024 20:03:48 -0700 From: Stephen Hemminger To: Jie Hai Cc: , , , Akhil Goyal , Anoob Joseph , Gowrishankar Muthukrishnan , , , Subject: Re: [PATCH v4 05/13] security: replace strtok with reentrant version Message-ID: <20241026200348.1bef5bce@hermes.local> In-Reply-To: <20241026101451.29135-6-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241026101451.29135-1-haijie1@huawei.com> <20241026101451.29135-6-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 26 Oct 2024 18:14:43 +0800 Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. > > The strtok() is non-reentrant, it is better to replace it with a > reentrant version. > > Fixes: 259ca6d1617f ("security: add telemetry endpoint for capabilities") > Cc: stable@dpdk.org Another patch that is not needed in stable.