From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B978D45BEC; Sun, 27 Oct 2024 04:09:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A11E406B4; Sun, 27 Oct 2024 04:08:58 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 931ED40673 for ; Sun, 27 Oct 2024 04:08:52 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-71e74900866so2424498b3a.1 for ; Sat, 26 Oct 2024 20:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729998532; x=1730603332; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=g+cur5ku3GF0npGWLjw1l8CtfB3FEQX/FvnJ8klu1pM=; b=H/krvwISv2+qlsa0FHlP2qQD4LHCQXYiwf738vwNpQoKrlG0+dzJN2wzhz82Lc4CCp dP3rASGcOk13k4gSaTnqBSi5inu9PVsqIU+zP0Fe7l5qQT68nx1eyKfDWesb5Kun/i4z kf3qyU5QpSp2dVDnaCbyKnp9Jee67usunCYXsHIevV/mnY87376zViOFz6ZUBnsAfr6W 9FRlpjZdcQbjB/iESrDE6UnsQaIHsbz7JAt/5zAre0cVbI3sGiUUHdElywUiMapEdUjP jAHT8v9AY3zi96qIctXju2vuRQjKlOvL6Z4e4YMbYiFDTEh7AwuWZ++riDo5WNXRlMlU bfuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729998532; x=1730603332; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g+cur5ku3GF0npGWLjw1l8CtfB3FEQX/FvnJ8klu1pM=; b=cXqlvSLC79uwYOxqx9obAobzk2BJDcr/6ESduf81moF9q+hhu+EleHlsmNNbnQHCml f3DP7Hxotwdw8gODzVNJ35NqVyhr6Uz3ScJJO/o4uxxWKmQ7S36KlYZ9xKoxMRVK+r+z djlv8xDF1JIpfjl9X9b5fm3eIjA1CauGXb4XNqAOOd/WaSSLDEsUZbHpZlbqWGaxX4I+ BRzZGUMEGw6YIIHnz4xnKDvzMgls0NRG54l5d7TbsJGVxUq1dT73U65aLJOkNCiwFrG1 1lvhPcz82WmaAIt46EOwC5EUzXVoD51Utf1v33FHIYOg5OXwOfPbI/mLsrtNmeYxltGN u03Q== X-Gm-Message-State: AOJu0Yz4QpGHLrq+GVNmxasA+A4L7ON5B0rfwIq5ifMGAZpag09RdmNH 0HHwLltee5W1NLzytcAEFiWOIVLSxT+ZmcVuBq/ts+iPJIOYHprHeBgflllq3zNvokBgE2E5d/Q K6pPJMg== X-Google-Smtp-Source: AGHT+IEyQiiIogXv43N7siwQ7+WinBo+M1Y9BJubxAge4aMB8fMRv4sc42AQKL7fS90tmQtZNCmgMg== X-Received: by 2002:a05:6a00:cc4:b0:71e:79a8:1d84 with SMTP id d2e1a72fcca58-72062eccf33mr7037560b3a.3.1729998531718; Sat, 26 Oct 2024 20:08:51 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057931766sm3384534b3a.49.2024.10.26.20.08.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 20:08:51 -0700 (PDT) Date: Sat, 26 Oct 2024 20:05:31 -0700 From: Stephen Hemminger To: Jie Hai Cc: , , , Bruce Richardson , Keith Wiles , Ciara Power , , , Subject: Re: [PATCH v4 06/13] telemetry: replace strtok with reentrant version Message-ID: <20241026200531.188a673d@hermes.local> In-Reply-To: <20241026101451.29135-7-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241026101451.29135-1-haijie1@huawei.com> <20241026101451.29135-7-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 26 Oct 2024 18:14:44 +0800 Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. >=20 > The strtok() is non-reentrant, it is better to replace it with a > reentrant version. >=20 > Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jie Hai > Acked-by: Chengwen Feng > Acked-by: Ciara Power > Acked-by: Morten Br=C3=B8rup > --- > lib/telemetry/telemetry.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) This one could be hit while application is running. Acked-by: Stephen Hemminger