From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E62645BEC; Sun, 27 Oct 2024 04:09:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E65840677; Sun, 27 Oct 2024 04:08:49 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id 3405B40657 for ; Sun, 27 Oct 2024 04:08:45 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7ea9739647bso2231188a12.0 for ; Sat, 26 Oct 2024 20:08:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729998524; x=1730603324; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5voVIGFHd/LQtevhZIBwqbBQS4gH9KUtVGG0ivx/Mq0=; b=u9f52/FbIwgg23OyeYm/S7UourM7H+ASdg4IUeEG9UfdLz2MAHbFqyFg3txki41vQF AA6igXxWAesP+EObzNaC/6E718OpEJn+i2Gufxgdl8/uUAwQjtrCBLnjzrFlY7s62BI8 REBEcnnzww7min4jMjUuE3ji7gMb/Ye+fEmWp2HWHW7u8ZW6lKCVx5+OH01aWLzb2Lvz cAtaTD4PCcJ3QkEB1grm40unooQ/moHrXaJul0SZ+jsaXjRc0QKwjc8PdZfBRBgjBV8L jySnGAUbHAdjbU46W8IIEJCygJUkdtJSjmtN1bqs7cfdiYZ2RMswItxZCVuj17wTKTXe BOnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729998524; x=1730603324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5voVIGFHd/LQtevhZIBwqbBQS4gH9KUtVGG0ivx/Mq0=; b=wOkETGRp/sp7cEkmfPg+fShWdmhu7fJlSv5MtLPjDty2pXcXStkuiBzmJyYWWzFicm x4JaS5/0AKz8PxvO4l1kin2iYl/KV5yxXiu8umBUFww2REzTnt+QyRk3Nj3Jr7bkOyu9 I5BtM9hQnjBBu4D8VJ8ap4SHMqxA2fvQCHmolf3vKyrOUGWeDH8e8iP6Ah5c/XDWUP7/ 7mWcuO+KCydUsypc//JkUC6+yTE4hIA0PDPQVaOp8wdxUJSSQLnea/Sh6yggzaavTxpw ZCrfyCm6044OrnAU8SDDHlR7kLtzssGo6tW2mGWg696ltoem7NYSmcPQl83Ijyno3ih1 Fk0Q== X-Gm-Message-State: AOJu0YzUrrqdFuGH0YIKuos739MFixMudIv2mHqq/tWE9Leb4+SFWVa2 xWsavdEtpFarwr2q9NlJR1y4ly2tgBqnmUM9cXO6WhpE9Rmoyh7bm/u61wMGwcC5g1X6vfBFp4w j6y2k6g== X-Google-Smtp-Source: AGHT+IE6ZU5MbUT4UWsBdibGUbsRn8oQnUlkI3WjHTq4F+lX9nHa3c2sNIiiWEEh1csLrZip7rAA7A== X-Received: by 2002:a05:6a21:170f:b0:1cf:3677:1c4a with SMTP id adf61e73a8af0-1d9a83d0a71mr6203031637.16.1729998524294; Sat, 26 Oct 2024 20:08:44 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057931766sm3384534b3a.49.2024.10.26.20.08.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 20:08:43 -0700 (PDT) Date: Sat, 26 Oct 2024 20:07:32 -0700 From: Stephen Hemminger To: Jie Hai Cc: , , , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra , Jerin Jacob , Gowrishankar Muthukrishnan , , , Subject: Re: [PATCH v4 08/13] common/cnxk: replace strtok with reentrant version Message-ID: <20241026200732.0103dee1@hermes.local> In-Reply-To: <20241026101451.29135-9-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241026101451.29135-1-haijie1@huawei.com> <20241026101451.29135-9-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 26 Oct 2024 18:14:46 +0800 Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. >=20 > The strtok() is non-reentrant, it is better to replace it with a > reentrant version. >=20 > Fixes: af75aac78978 ("common/cnxk: support telemetry for NIX") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jie Hai > Acked-by: Chengwen Feng > Acked-by: Morten Br=C3=B8rup > --- These info functions can be called when running. Acked-by: Stephen Hemminger