From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB64545BEC; Sun, 27 Oct 2024 04:08:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8171C40651; Sun, 27 Oct 2024 04:08:43 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id BAD88402E3 for ; Sun, 27 Oct 2024 04:08:39 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7ea8c4ce232so2604263a12.0 for ; Sat, 26 Oct 2024 20:08:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729998519; x=1730603319; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=5ibwGqIqgPo4aJp1qdkq+va8mAcyUZ+fcXFabKxYbRo=; b=EVBH9t051kk7vkuIm0C4VvWk3NW5wjuUw/ydBOqE6Ww+s7iePphOS6OEDj5/18iG9+ piMVPCe7TnTn59C7dWvgm7NsP1Xz0ZQfpIi99aMDmWYscNUIilzks+IMJHS0hq72L0xc Wacd8HU3bLI17TCPER2UXMj64e5MAd20P5qUuI8gvZAYtjRKNEqc4QE2XYMra+wv+aLp 8+0guU7W9egJPo5xvk9lNWrwI6Gnn+UuqcKTfQmE1gRmcw8uG6Jm0VwB09076OJyotO8 oSyoJJ2kLyJJ/Uqo4KZIbpPxYcd9CDFiR2u7oSCi6bxCPhh1QonjgSyrquhqGBXfGB8K 9hrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729998519; x=1730603319; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5ibwGqIqgPo4aJp1qdkq+va8mAcyUZ+fcXFabKxYbRo=; b=DAqI2SQyuAGY4cV/lU4qqVjgq3TopNt9z98m1XexP1RCGWs4Q6DqjF8QNb2tT9v8qH d0QyKLiikAx4NjMxt6FZX11NY38k2XVQMORFL3SrKEeCfB+syLPpVXOZ8e4Ynhk74led F4Mc69uHRKiQTZSunE0i1iJiTOrlCUii2uwb2sJd6b3sVWFAl7RupwaVl4wwLqwZ4GJM LVyvXRNZasVN6O7ne9jcfO3vQq2dlC08eJRqUq/MFmqgHUqcukcaphe5MgoPOPE4AYG2 RaBrxEDYupRZkqbfjAQZq6uQ623zmhuH4qht4N5L6vIcDFP+HG2OE1alw3XwjY+CUg1t GPyQ== X-Gm-Message-State: AOJu0Yz77RM3WS+NVfpex67PIGv660mKncpyePtJ8cXcJd4myHRYKI/3 DGLjzzlPfCzhDOIUGBHMQDZ+fSU/VjOK6Y8uBW09OaL5BqhNnriAG+WM7IX5UyLrABvn5HzY4yy p47gnXw== X-Google-Smtp-Source: AGHT+IGPNdtmNQmkG9szTeSYsoZ+i+JNYQ6oyJ8Y+Ye+hO0+180BcGe8FtSwrxTta2TM2McXBUs20Q== X-Received: by 2002:a05:6a21:2d87:b0:1d8:fd01:52b7 with SMTP id adf61e73a8af0-1d9a83ab01amr5522246637.2.1729998518835; Sat, 26 Oct 2024 20:08:38 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057931766sm3384534b3a.49.2024.10.26.20.08.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 20:08:38 -0700 (PDT) Date: Sat, 26 Oct 2024 20:08:18 -0700 From: Stephen Hemminger To: Jie Hai Cc: , , , Pavan Nikhilesh , Shijith Thotton , , , Subject: Re: [PATCH v4 09/13] event/cnxk: replace strtok with reentrant version Message-ID: <20241026200818.3580e25f@hermes.local> In-Reply-To: <20241026101451.29135-10-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241026101451.29135-1-haijie1@huawei.com> <20241026101451.29135-10-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 26 Oct 2024 18:14:47 +0800 Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integrity. >=20 > The strtok() is non-reentrant, it is better to replace it with a > reentrant version. >=20 > Fixes: 8a3d58c189fd ("event/cnxk: add option to control timer adapters") > Fixes: 8bdbae66b299 ("event/cnxk: add external clock support for timer") > Cc: stable@dpdk.org >=20 > Signed-off-by: Jie Hai > Acked-by: Chengwen Feng > Acked-by: Morten Br=C3=B8rup Another set of parse routines only called during startup. Patch is unnecessary for stable.