From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9C4545BEC; Sun, 27 Oct 2024 04:11:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67EB24029B; Sun, 27 Oct 2024 04:11:22 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id B294A40279 for ; Sun, 27 Oct 2024 04:11:21 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7ea7e2ff5ceso2198948a12.2 for ; Sat, 26 Oct 2024 20:11:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729998681; x=1730603481; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zqgjH6PPGoABZ2sr+3iSMMcVeJN/K7iTTpHrMfAa4Gk=; b=t1/hSEtM4qPkSPhEa8XhTwU6C7omAbuHz8FuAUuzKaKsAxh4E+bTKJR/yUvL7lrNf6 ZRKxjMWy1FhZIDHK7zzIGE7z4UUxNRwIuoL6mMyoRAhlsMdqPiX9jcOAN1ztYcJRwXyZ GDE4nYdQK04SeM2LwytKzYoa/8FGHQMx5ZJ5TYlm6SUFqtJsOCDoRZ7a32IBI8UZcWI0 iGRUBPjzsoPuoUUtDrmOlz1hOgXa7Jt3Dd7ax5jqohdqmEjM6jmcMqISpJfVsTlfMYfb BRRJuG0T55Zc+pQx+AsWT0N8OJ5URPxaT0nZRIt8GoPPwqlu7e8ImsxEREN3seIzIJWp z+xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729998681; x=1730603481; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zqgjH6PPGoABZ2sr+3iSMMcVeJN/K7iTTpHrMfAa4Gk=; b=tkAo67cgvLBaCOsMC2z6dzyJ4X+E+nhkgZWT2PbHdlUgdrBcKYWtwDlAa3nJ2wGDsf RyuaHQgjZqs3RP+7KVTgX6wvNcdon3X756Iy8b9uPLLkaWAPr+Y/Tj7k4tToazbJxo4R FUQoeppux4UbePqoXS9q1P+aHKS69lCFc2h5kFnIh5jX5hTbRzBm9LFOvfA64LLK5vgn w2Q+L6vbE8bNzG4fDb8vI8LkgRWHX1UKGMwQNqsiUqmO5N3f0EsjufpP6sOkb8Pol3dH FHFwHlroHRtHiSODVbiqABPT2K0/WxBYeQKfJPs6cjbFylNgOiF++M+27JNYfIrJvAmR 3X4Q== X-Gm-Message-State: AOJu0Yy69sxVNlrg3qHX9bFfByebdcmZjgXt9+eZbezf7N4WUnPY1aHz kOG72GZXh+btSj9Hph2if4ySntzaUzZ1RDrlGvSKzePJtHgekQ1zsx3OOWBiFI0= X-Google-Smtp-Source: AGHT+IGeA5r7SMwbUVrJSfj4kU21V0BNSz8Q9wD9g834rUqfK/Hi5DECfFkf8ozvy5bmyH7MO1uBLQ== X-Received: by 2002:a05:6a21:78d:b0:1d2:f09e:c15b with SMTP id adf61e73a8af0-1d9a846a207mr5665196637.25.1729998680709; Sat, 26 Oct 2024 20:11:20 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057921a94sm3397890b3a.8.2024.10.26.20.11.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 20:11:20 -0700 (PDT) Date: Sat, 26 Oct 2024 20:11:18 -0700 From: Stephen Hemminger To: Jie Hai Cc: , , , , , Subject: Re: [PATCH v4 13/13] devtools: check for some reentrant function Message-ID: <20241026201118.5e8c5626@hermes.local> In-Reply-To: <20241026101451.29135-14-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241026101451.29135-1-haijie1@huawei.com> <20241026101451.29135-14-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 26 Oct 2024 18:14:51 +0800 Jie Hai wrote: > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > index d860f190457e..8c3d32d8e552 100755 > --- a/devtools/checkpatches.sh > +++ b/devtools/checkpatches.sh > @@ -145,6 +145,14 @@ check_forbidden_additions() { # > -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > "$1" || res=1 > > + # refrain from using some non-reentrant functions > + awk -v FOLDERS="lib drivers app examples" \ > + -v EXPRESSIONS="strtok\\\(" \ > + -v RET_ON_FAIL=1 \ > + -v MESSAGE='Using non-reentrant function strtok, prefer strtok_r' \ > + -f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \ > + "$1" || res=1 > + > # refrain from using some pthread functions > awk -v FOLDERS="lib drivers app examples" \ > -v EXPRESSIONS="pthread_(create|join|detach|set(_?name_np|affinity_np)|attr_set(inheritsched|schedpolicy))\\\(" \ Ok, but checkpatch keeps getting slower and slower with all this copy baset. Could someone make it into a python script without so much copy/paste?