DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 2/2] doc: provide Meson version that works
Date: Sat, 26 Oct 2024 23:45:47 +0300	[thread overview]
Message-ID: <20241026234547.68e9ddbb@sovereign> (raw)
In-Reply-To: <1729884659-2480-3-git-send-email-andremue@linux.microsoft.com>

2024-10-25 12:30 (UTC-0700), Andre Muezerie:
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> ---
>  doc/guides/windows_gsg/build_dpdk.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/windows_gsg/build_dpdk.rst b/doc/guides/windows_gsg/build_dpdk.rst
> index c5fad81..76bfc22 100644
> --- a/doc/guides/windows_gsg/build_dpdk.rst
> +++ b/doc/guides/windows_gsg/build_dpdk.rst
> @@ -74,7 +74,7 @@ A good option to choose is the MSI installer for both meson and ninja together::
>  
>  Meson version 0.58 was unusable with LLVM toolchain
>  because of an `issue <https://github.com/mesonbuild/meson/issues/8981>`_, but
> -more recent versions are working fine.
> +more recent versions are working fine. Meson version 1.5.2 was tested and worked.
>  
>  
>  Install the Backend

In order to address reviewer feedback on a single patch,
you are supposed to send an updated version of that patch,
not a series of the original patch (as v2 1/2)
and a patch with amendments (as v2 2/2, i.e. this patch).
IOW, you should have sent a single v2 patch with the proper text.

As for this documentation paragraph: please drop the mention of Meson 0.58
and simply state that Meson 1.5.2 or newer is recommended.
The warning was put in place because the bug lasted many Meson versions.

      reply	other threads:[~2024-10-26 20:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 14:15 [PATCH] doc: enhance build instructions on windows Andre Muezerie
2024-10-25 14:15 ` [PATCH] doc: enhanced build instructions on Windows Andre Muezerie
2024-10-25 14:50   ` Thomas Monjalon
2024-10-25 19:30     ` [PATCH v2 0/2] doc: enhance build instructions on windows Andre Muezerie
2024-10-25 19:30       ` [PATCH v2 1/2] doc: enhanced build instructions on Windows Andre Muezerie
2024-10-26 21:03         ` Dmitry Kozlyuk
2024-10-25 19:30       ` [PATCH v2 2/2] doc: provide Meson version that works Andre Muezerie
2024-10-26 20:45         ` Dmitry Kozlyuk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241026234547.68e9ddbb@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).