From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1657745BE4; Sat, 26 Oct 2024 22:45:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E0346402A8; Sat, 26 Oct 2024 22:45:51 +0200 (CEST) Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by mails.dpdk.org (Postfix) with ESMTP id 78A9640294 for ; Sat, 26 Oct 2024 22:45:50 +0200 (CEST) Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-539f53973fdso2605057e87.1 for ; Sat, 26 Oct 2024 13:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729975550; x=1730580350; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Qqu0AJ8x44wviwHwKAqx0/U4Sr6rfCq/h0yLYdD5Fo0=; b=Rgqttepl32T2QBDfy59yqjnHiL7gJ1MHVYVV37JbG94AFmvPjIxkbH9lWrDtdCL0KE FAiFZYIv+9Hl4hk2wjT7bODi4OH6u+eMMdNLICdO5T34idMXOJlWCDpa9+mlKj3AOpp1 ddI0bnN6PfL9TMOaZ80wz1FkBySt/huKTisMbtD34lX3DGR/TW04DRA1h1peUWFdywKR 8bfbP5ZfdKVYioQ2KGeMiUg5HgzLoMfjrljL/XeieC5RndgLe9p0hW1Ox+pGyoIDXO6r +IATTGRuHq7hHecAiCYFURMo3cb5Sg00IUm/VRrDHds+yeCXvdwDXQK1Pr7VaLepuZRo jfJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729975550; x=1730580350; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qqu0AJ8x44wviwHwKAqx0/U4Sr6rfCq/h0yLYdD5Fo0=; b=gyPy/JvfZvlgX49y4k9ssPLUM5S7rGJluNcZrspFZFN83ZnCGHwNVjOAJuD3ioV0Uz p1nYRAANctK6rdc89Whjcpl9C6386YzJuQ4hY0eR63SbLuaBcoRzepT3N3pInD73RGTO lGczOKB5HCIoUjY+H14EMev06JBRnTuParQdXP1UcYq7FoENyGGa/NB+t7STF+nJxA52 IX+QzJwWjiCenfvHrAFDDXD8tuoXvp8MH3pyj/sHidlr5lQSTU2sr5Zgv+zg/u34OTQw RKltfU8x8nMDkDLWoRSVoitz+zN0KKbCpA5lqCZ+8mDuNTuMjEoovz4pfGqxQ+ufCW0u KgeQ== X-Gm-Message-State: AOJu0YxUQd9qwXHICu5B7OATxHYz8O2OpHnmodidGswj+oK9o/mgyaJf cO2AS2hUYtnBBeD3meug8sgFi0VzfkhKr6s/Dy/gIFoEWvO9astR2H+piQEO X-Google-Smtp-Source: AGHT+IFV903YoVZk6yTkZvSfOobHJNrZrRgEt/Oy4oH8uNtkvk0F97X314ajcwo5K+LwfMe1JV1l+Q== X-Received: by 2002:a05:6512:4013:b0:539:f84d:bee1 with SMTP id 2adb3069b0e04-53b23723f2amr3243732e87.17.1729975549375; Sat, 26 Oct 2024 13:45:49 -0700 (PDT) Received: from sovereign (broadband-109-173-43-194.ip.moscow.rt.ru. [109.173.43.194]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53b2e10a555sm593553e87.34.2024.10.26.13.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 26 Oct 2024 13:45:48 -0700 (PDT) Date: Sat, 26 Oct 2024 23:45:47 +0300 From: Dmitry Kozlyuk To: Andre Muezerie Cc: dev@dpdk.org Subject: Re: [PATCH v2 2/2] doc: provide Meson version that works Message-ID: <20241026234547.68e9ddbb@sovereign> In-Reply-To: <1729884659-2480-3-git-send-email-andremue@linux.microsoft.com> References: <1857976.G7SD5HZVK5@thomas> <1729884659-2480-1-git-send-email-andremue@linux.microsoft.com> <1729884659-2480-3-git-send-email-andremue@linux.microsoft.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2024-10-25 12:30 (UTC-0700), Andre Muezerie: > Signed-off-by: Andre Muezerie > --- > doc/guides/windows_gsg/build_dpdk.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/guides/windows_gsg/build_dpdk.rst b/doc/guides/windows_gsg/build_dpdk.rst > index c5fad81..76bfc22 100644 > --- a/doc/guides/windows_gsg/build_dpdk.rst > +++ b/doc/guides/windows_gsg/build_dpdk.rst > @@ -74,7 +74,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: > > Meson version 0.58 was unusable with LLVM toolchain > because of an `issue `_, but > -more recent versions are working fine. > +more recent versions are working fine. Meson version 1.5.2 was tested and worked. > > > Install the Backend In order to address reviewer feedback on a single patch, you are supposed to send an updated version of that patch, not a series of the original patch (as v2 1/2) and a patch with amendments (as v2 2/2, i.e. this patch). IOW, you should have sent a single v2 patch with the proper text. As for this documentation paragraph: please drop the mention of Meson 0.58 and simply state that Meson 1.5.2 or newer is recommended. The warning was put in place because the bug lasted many Meson versions.