From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E3B445BF4; Sun, 27 Oct 2024 17:48:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C91A64026B; Sun, 27 Oct 2024 17:48:02 +0100 (CET) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 96A6240151 for ; Sun, 27 Oct 2024 17:48:01 +0100 (CET) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-71ec997ad06so2489430b3a.3 for ; Sun, 27 Oct 2024 09:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730047680; x=1730652480; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=HTRkxN48aSrZWoPVFnAqzJKjbK7vsLx9RyfR10IHVmU=; b=avMX+uCk3YClkb0TfIWlo+NrtXWfKUcel02Wzk4aVjo29EJsXaDGd818De3tdmeKsX YAgRbEgbJ4bDm6ZTgvk4RkY/hin2A4B7h+o/o6S3aeNKdz20Oz4UjNYLd+VWftIL8NMT xNDYlOw8XQuqWGDlb3xOE/ccOhhVBkihRNkCZFYR1h/nLoQuQH0lgh0NrtaDLprsiq3f BWXoatrfbDI45KcxDr2W7NTp9szhqRj0y9fRoDMjxA2YgAuQt6x8D4UmyiMzKsc5npaW hycU7x01OWanustVwgKMpudBWTjaSzhNmZXShesmI0y5WJyLbgYJTXq9mwX3K5hQOsh4 2a0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730047680; x=1730652480; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HTRkxN48aSrZWoPVFnAqzJKjbK7vsLx9RyfR10IHVmU=; b=ag1iqBeBfYQmnDEOteuMt0fYb/aXzg1/rDfx8GeaTVWk8GOaBkMP0hxAqE+dgFkuFN McMwWZTxLFvYYtJV4R2huP2XgmGlJJMngsRcCoKVarFU/YUjLgXHwoQdYtkXZzTaTB3B JnLJXswLWpNLUC8uYJW/rlIFaJlPGS1Qgt4/MZr0lVJ9uKoMa3Y1Sormja4wYcEHAlS/ BE1O67Q+yAXnir2qdHUa/ZxQXrDwY9VsIEgcNlrIDCP8RqhXMHgvhBWI+O6ZnDA3cxGX /Qx/ccuXDSzAPEXnrcIQ++9xDy2KTOKelysuRn3nT8rRID1SUnOlRz62wXtPjbsT/8nP +WcA== X-Gm-Message-State: AOJu0YzsgBrB3YM0aDhOACOnUAwRHM3sFQ22jK2hKapk5dF++eOQpSsh 1BTJolGPaMFJOD05vu7WwojsFc1XUWwswVZwcOkL9xFU1PXVXCDrtRpHBDN/4OA= X-Google-Smtp-Source: AGHT+IFGPGmW+3VmfmdCIGqo2ueiMJEQ+S7JYZqaZFLpH7eTBiDJP+Nh+OBfwfHhyrgwOIN73Ws/IA== X-Received: by 2002:a05:6a00:18a4:b0:71e:4ee1:6d78 with SMTP id d2e1a72fcca58-72062f4bea7mr8701717b3a.1.1730047680353; Sun, 27 Oct 2024 09:48:00 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a23e9fsm4376841b3a.177.2024.10.27.09.47.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 09:48:00 -0700 (PDT) Date: Sun, 27 Oct 2024 09:47:58 -0700 From: Stephen Hemminger To: Junlong Wang Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, wang.yong19@zte.com.cn Subject: Re: [PATCH v7 3/9] net/zxdh: add zxdh device pci init implementation Message-ID: <20241027094758.5dff7037@hermes.local> In-Reply-To: <20241022122042.2127065-4-wang.junlong1@zte.com.cn> References: <20241016081647.1808333-2-wang.junlong1@zte.com.cn> <20241022122042.2127065-1-wang.junlong1@zte.com.cn> <20241022122042.2127065-4-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 22 Oct 2024 20:20:36 +0800 Junlong Wang wrote: > Add device pci init implementation, > to obtain PCI capability and read configuration, etc. > > Signed-off-by: Junlong Wang > --- > drivers/net/zxdh/meson.build | 1 + > drivers/net/zxdh/zxdh_ethdev.c | 43 +++++ > drivers/net/zxdh/zxdh_ethdev.h | 22 ++- > drivers/net/zxdh/zxdh_pci.c | 290 +++++++++++++++++++++++++++++++++ > drivers/net/zxdh/zxdh_pci.h | 151 +++++++++++++++++ > drivers/net/zxdh/zxdh_queue.h | 105 ++++++++++++ > drivers/net/zxdh/zxdh_rxtx.h | 51 ++++++ > 7 files changed, 660 insertions(+), 3 deletions(-) > create mode 100644 drivers/net/zxdh/zxdh_pci.c > create mode 100644 drivers/net/zxdh/zxdh_pci.h > create mode 100644 drivers/net/zxdh/zxdh_queue.h > create mode 100644 drivers/net/zxdh/zxdh_rxtx.h DPDK has switched from GNU special zero length arrays to the C99 standard flexible arrays. ### [PATCH] net/zxdh: add zxdh device pci init implementation ERROR:FLEXIBLE_ARRAY: Use C99 flexible arrays - see https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays #620: FILE: drivers/net/zxdh/zxdh_queue.h:33: + uint16_t ring[0]; +}; ERROR:FLEXIBLE_ARRAY: Use C99 flexible arrays - see https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays #690: FILE: drivers/net/zxdh/zxdh_queue.h:103: + struct vq_desc_extra vq_descx[0]; +}; total: 2 errors, 0 warnings, 0 checks, 698 lines checked