Re: [PATCH v7 9/9] net/zxdh: add zxdh dev configure ops

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 22 Oct 2024 20:20:42 +0800
Junlong Wang <wang.junlong1@zte.com.cn> wrote:

> provided zxdh dev configure ops for queue
> check,reset,alloc resources,etc.
> 
> Signed-off-by: Junlong Wang <wang.junlong1@zte.com.cn>
> ---
>  drivers/net/zxdh/meson.build   |   1 +
>  drivers/net/zxdh/zxdh_common.c | 118 +++++++++
>  drivers/net/zxdh/zxdh_common.h |  12 +
>  drivers/net/zxdh/zxdh_ethdev.c | 457 +++++++++++++++++++++++++++++++++
>  drivers/net/zxdh/zxdh_ethdev.h |  18 +-
>  drivers/net/zxdh/zxdh_pci.c    |  97 +++++++
>  drivers/net/zxdh/zxdh_pci.h    |  29 +++
>  drivers/net/zxdh/zxdh_queue.c  | 131 ++++++++++
>  drivers/net/zxdh/zxdh_queue.h  | 175 ++++++++++++-
>  9 files changed, 1035 insertions(+), 3 deletions(-)
>  create mode 100644 drivers/net/zxdh/zxdh_queue.c

In future, DPDK wants to re-enable the Gcc warning for taking
address of packed member.  When I enable that (in config/meson.build)
this shows up.

[1478/3078] Compiling C object drivers/libtmp_rte_net_zxdh.a.p/net_zxdh_zxdh_ethdev.c.o
../drivers/net/zxdh/zxdh_ethdev.c: In function ‘zxdh_init_vring’:
../drivers/net/zxdh/zxdh_ethdev.c:541:27: warning: taking address of packed member of ‘struct <anonymous>’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  541 |         vring_init_packed(&vq->vq_packed.ring, ring_mem, ZXDH_PCI_VRING_ALIGN, size);
      |                           ^~~~~~~~~~~~~~~~~~~
../drivers/net/zxdh/zxdh_ethdev.c: In function ‘zxdh_init_queue’:
../drivers/net/zxdh/zxdh_ethdev.c:682:62: warning: taking address of packed member of ‘union <anonymous>’ may result in an unaligned pointer value [-Waddress-of-packed-member]
  682 |                         struct vring_packed_desc *start_dp = txr[i].tx_packed_indir;
      |                                                              ^~~
[1479/3078] Compiling C object drivers/libtmp_rte_net_virtio.a.p/net_virtio_virtio_ethdev