From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3636345BF4; Sun, 27 Oct 2024 17:59:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2578A402E6; Sun, 27 Oct 2024 17:59:39 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 0C953402CD for ; Sun, 27 Oct 2024 17:59:33 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2e3fca72a41so2817212a91.1 for ; Sun, 27 Oct 2024 09:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730048372; x=1730653172; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=6UXYIkhMVLZTeyG5r1CtqV6QNHrgLkLl6jqJWXC0ERo=; b=02PEAJQozfg97az8E3wA6cQIfN+nd8HmukDD+rkBvZEksiZkbZVJl31ft/s3z1FU4t J+R9OSOn3HzWCLZkbj6Nftym83HL1XUbS11UtC50wrkh9zdOqI/MP4/RfNurY7AyqcwO BVqZprEFOIMoiDT/8MibX49JROQBNPOs3HDgOCqG+bzUoxCKZp8jYHd8dCFQh8AieEOR xUdEM08xy7McMFt9HjWOoEmq+ei17Te+KvW1CbOFyhjeL0uhd4zn3XnFifNQrYU17HFz 7b/DHazYPEJRzhroKrU6LmJ2+Fw+1/C/HfyTCDc9qYFAn0b6P8SMlv7jBp4XYrO7sSXR MRpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730048372; x=1730653172; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6UXYIkhMVLZTeyG5r1CtqV6QNHrgLkLl6jqJWXC0ERo=; b=cMH4U+V09nd1PRvvlK1Vw+CR2jrZsM6pKeKGxA6k/E2bo4nmsm2IWPpU513vxpf6CA JTraipY9uL4sj7GkJ9SR8zTaOMYYazdY8jzAS0YcyeZCFixtcwq8pSW7vuHU9xZBKrnB qRyk3BGYM8le7cD1B5iVlswKfcFnifh0EYxffdyTzNl9/aCO9XVpClenPqhFtsSHv0Az 5Tsy1xAVWQ/6pIoKW+FpdIJelTe2SPy9lpnN0iHJBVqEkuOsFz1+Jzy1gV3vMg4tX3Mg KMH4QFYtac327wZ/7JgtrgDUw3B4lxU257Zquf1W9DTfSTJ0Hf/i5ex/kBW1Jo7TCMYs SWaw== X-Gm-Message-State: AOJu0YwqWxGtj0nhkFf3d5fwYEK60nkHOq1POwehoUv7U7YIYPt2uTxQ AY9r1bNEYY7b98FOMkT0qZRelG0K2SKfdkJ4TmluitpMw6bPTjmZO37fhOmJ8/L6Mi5YKJvs55R X++uhFw== X-Google-Smtp-Source: AGHT+IFb987XF46wprazYnAMtihGCEVr8HfhSslSR9dSMvQ8/boraZySKDUAI2bOSRrwyd0OdwnPYQ== X-Received: by 2002:a17:90b:390e:b0:2e0:a47a:5eb0 with SMTP id 98e67ed59e1d1-2e8f11b9e07mr7228841a91.38.1730048372173; Sun, 27 Oct 2024 09:59:32 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e77e4c7076sm7435157a91.16.2024.10.27.09.59.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 09:59:32 -0700 (PDT) Date: Sun, 27 Oct 2024 09:58:33 -0700 From: Stephen Hemminger To: Junlong Wang Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, wang.yong19@zte.com.cn Subject: Re: [PATCH v7 9/9] net/zxdh: add zxdh dev configure ops Message-ID: <20241027095833.53bd87df@hermes.local> In-Reply-To: <20241022122042.2127065-10-wang.junlong1@zte.com.cn> References: <20241016081647.1808333-2-wang.junlong1@zte.com.cn> <20241022122042.2127065-1-wang.junlong1@zte.com.cn> <20241022122042.2127065-10-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 22 Oct 2024 20:20:42 +0800 Junlong Wang wrote: > provided zxdh dev configure ops for queue > check,reset,alloc resources,etc. >=20 > Signed-off-by: Junlong Wang > --- > drivers/net/zxdh/meson.build | 1 + > drivers/net/zxdh/zxdh_common.c | 118 +++++++++ > drivers/net/zxdh/zxdh_common.h | 12 + > drivers/net/zxdh/zxdh_ethdev.c | 457 +++++++++++++++++++++++++++++++++ > drivers/net/zxdh/zxdh_ethdev.h | 18 +- > drivers/net/zxdh/zxdh_pci.c | 97 +++++++ > drivers/net/zxdh/zxdh_pci.h | 29 +++ > drivers/net/zxdh/zxdh_queue.c | 131 ++++++++++ > drivers/net/zxdh/zxdh_queue.h | 175 ++++++++++++- > 9 files changed, 1035 insertions(+), 3 deletions(-) > create mode 100644 drivers/net/zxdh/zxdh_queue.c In future, DPDK wants to re-enable the Gcc warning for taking address of packed member. When I enable that (in config/meson.build) this shows up. [1478/3078] Compiling C object drivers/libtmp_rte_net_zxdh.a.p/net_zxdh_zxd= h_ethdev.c.o ../drivers/net/zxdh/zxdh_ethdev.c: In function =E2=80=98zxdh_init_vring=E2= =80=99: ../drivers/net/zxdh/zxdh_ethdev.c:541:27: warning: taking address of packed= member of =E2=80=98struct =E2=80=99 may result in an unaligned = pointer value [-Waddress-of-packed-member] 541 | vring_init_packed(&vq->vq_packed.ring, ring_mem, ZXDH_PCI_V= RING_ALIGN, size); | ^~~~~~~~~~~~~~~~~~~ ../drivers/net/zxdh/zxdh_ethdev.c: In function =E2=80=98zxdh_init_queue=E2= =80=99: ../drivers/net/zxdh/zxdh_ethdev.c:682:62: warning: taking address of packed= member of =E2=80=98union =E2=80=99 may result in an unaligned p= ointer value [-Waddress-of-packed-member] 682 | struct vring_packed_desc *start_dp =3D txr[= i].tx_packed_indir; | ^~~ [1479/3078] Compiling C object drivers/libtmp_rte_net_virtio.a.p/net_virtio= _virtio_ethdev