From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E318645BF5; Sun, 27 Oct 2024 18:08:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE1C240289; Sun, 27 Oct 2024 18:08:04 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id AF6954026B for ; Sun, 27 Oct 2024 18:08:02 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-7163489149eso2647298a12.1 for ; Sun, 27 Oct 2024 10:08:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730048882; x=1730653682; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=FrudY0Cc0CoAGcqszA5eRHm5l47nTwYWkFCXk4HjJvQ=; b=nufFdA9/AouVMIF2xObNd7/bapBRrSMURugGfbE3X15D+Vpl7iZiMsMRHG7eRXa5GO 1SyxpR5CiFs8ml2nWW39JE9Ge5WA2x7hPdtkqv/+/r7/9UvE04JpnLcu5m9JceNeAEfU E70RcLRNRGBOncEEuSEoZSSI9K4rriD3/phPpsjR110/AyomoestRP071jwe+Vt1q9LT PI5E3Ezn9hzs+yZQ+SUaA1RXqEs21Dc81oIUv39SM2dnOmqymnUVdFBMojcY0252HQ7o eezBirfltjVoiuekjF73f31ysFrOk/gVZfqjkER0mTy2Wab3OQ2JDI/8YbAWmIuNR9+p 18AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730048882; x=1730653682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FrudY0Cc0CoAGcqszA5eRHm5l47nTwYWkFCXk4HjJvQ=; b=XFihGhNvx0GagECn4x3WJHwHcmVrle2EB3yQKAfOHKSkvBMtkNUR8Zwhp8PYfNL7Xp kGqGDWt12XreBtHcUM9+Uj3DlAbL2UV+td3kjlIshbqB1+qRcxeciFTBXpVp2YjuO5jX ptInEE29aAeyVafSgPr0JELe5Rex8oKB+4EJAG+5kpMAFZS2FgJ0ppYBzhBYxRYtEyj/ lkNbNvSBlzETFPiMCwONWCbEeYoMHkcfuNi6KFEEMiOl/1q/WLxWDpgyiVwq8OUfiEAH L5L96ztsEBcKUwJKwUH/uCbFvTqEQvoZCUiYylZ6P5WPt6vhEEduUCsBFae92AHB/SNn C2fw== X-Gm-Message-State: AOJu0YwxWHrjeKLlAEyzfC+5DiyT7onAq7f7r6O6EADMCbOE86c5Md6d 6jy6bmp9LYHOKlg2oscstDG7YuhbvKr1v+sTuy6mf7KSvjmOO14XcNoyIPXyrks= X-Google-Smtp-Source: AGHT+IFGyyEuCPObaYzpn9ck4tVi8R8USK9MfbzbwLl2ukleSL4yFileQWrY1q1d3U6QTTijOHmqQg== X-Received: by 2002:a17:90a:8d05:b0:2e2:b204:90c8 with SMTP id 98e67ed59e1d1-2e8f11bf7d2mr7257344a91.34.1730048881784; Sun, 27 Oct 2024 10:08:01 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e8e3578dc1sm5484234a91.24.2024.10.27.10.08.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 10:08:01 -0700 (PDT) Date: Sun, 27 Oct 2024 10:07:59 -0700 From: Stephen Hemminger To: Junlong Wang Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, wang.yong19@zte.com.cn Subject: Re: [PATCH v7 7/9] net/zxdh: add configure zxdh intr implementation Message-ID: <20241027100759.4faa6cf6@hermes.local> In-Reply-To: <20241022122042.2127065-8-wang.junlong1@zte.com.cn> References: <20241016081647.1808333-2-wang.junlong1@zte.com.cn> <20241022122042.2127065-1-wang.junlong1@zte.com.cn> <20241022122042.2127065-8-wang.junlong1@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 22 Oct 2024 20:20:40 +0800 Junlong Wang wrote: > +/* Interrupt handler triggered by NIC for handling specific interrupt. */ > +static void zxdh_fromriscv_intr_handler(void *param) > +{ > + struct rte_eth_dev *dev = param; > + struct zxdh_hw *hw = dev->data->dev_private; > + uint64_t virt_addr = 0; > + > + virt_addr = (uint64_t)(hw->bar_addr[ZXDH_BAR0_INDEX] + ZXDH_CTRLCH_OFFSET); There is no need to initialize a variable like virt_addr which is set later.