From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 688CD45BF2; Sun, 27 Oct 2024 13:40:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AF354026C; Sun, 27 Oct 2024 13:40:01 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2067.outbound.protection.outlook.com [40.107.236.67]) by mails.dpdk.org (Postfix) with ESMTP id 62ABA40151; Sun, 27 Oct 2024 13:39:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Zrba5jXq3LYRmnWV7vxqEyldgdluGHNXsY/sgZPoxVpoRcORL6/jBpKk5OZwH+FTI9hbHzUts288ych0MDHRofY+8LIB7XKcb0uE0TfaGtt7WYHKgxYe7Bx6lTKF5IZIFm2VXCAFG4o7koI0bfqOXXkr3G8Abu6z61lV9skf6D3isM6HYpN8MoV1rlpD0VZ/H/i0vCJMOLDORe5V5zGZnmTMKXel3I6EFX/LwPDVdLFPZhu4h8akLx21Hk8ISat10jmW9guv9VmMnM5pYz4cNEsZi7Us8XzrKeEzcvRo4jo1jELhLr6zcpwOWOFgcqQ8U1k/9EB6b5yd2SK5xWAV7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1b5YKKTkRX8b+IXNt6pOp/U/PxLf27lp4Hi4hZnLpBY=; b=YLGto4VEaJJPyWBLg1XTOqYjSIk90OI+RNEo6995+AyfD6GPws67dwbxiLCRGPAFQR1QWBJYg74NBVzDxLgLwdJvA+jOejPSdkhHtR5ZeSiCCwlLOfdQM7R/BACPDcPTLT59zOh0t/O8G4Akg2HmfIAw16sD8mOipVz2d/DycaX+pylUGpqCEGGKJx+RLfmaMk7eHoeTU8M/nBsIXAv4IZSKkzYdKMzgk1OPmhsGsp2ofEzRu93Wj2+NgmOMidUwm4M2P7a6APuOPRY4C5Lor6t9nIzP8qSH+fwZHq2T63VyiwbUCJi9H5XWq4VzX3x2+wljVlFYaNR48SG2NSQBVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1b5YKKTkRX8b+IXNt6pOp/U/PxLf27lp4Hi4hZnLpBY=; b=j/nxa+gv+ml/K2GS+7U5MnAxB31zjq/ahEBoMaiNNb5PnnfqTSlfvF/UsVF7YBHKVamEZZ5bFuZFALz+zhxvupPqIEp0sz7g1bzIDetCnbTdETQnRHvHGLV8EskqDNmH01toBj/xA/J0sMDUx7ftzHsisgXzpc5JBhRJ5632LJsRNjvo4KnJaz/GWRDptl/ztnoqygDLF8qY9JNLNFvgu81di1HH+QyYHWEiqwAd5ig+46kabk3Sy9B8DLFgnc4WAfpzwZ8xQ4QijPpKOcRu4QgwSkGdBUf0YkmOZVRr8jGTF9U/vhs9MjdT0uq2/I6SAIzopM5jfUFyPV5ELR1VLg== Received: from MN2PR19CA0004.namprd19.prod.outlook.com (2603:10b6:208:178::17) by IA0PR12MB7580.namprd12.prod.outlook.com (2603:10b6:208:43b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.24; Sun, 27 Oct 2024 12:39:54 +0000 Received: from BN3PEPF0000B06C.namprd21.prod.outlook.com (2603:10b6:208:178:cafe::e4) by MN2PR19CA0004.outlook.office365.com (2603:10b6:208:178::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.21 via Frontend Transport; Sun, 27 Oct 2024 12:39:54 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN3PEPF0000B06C.mail.protection.outlook.com (10.167.243.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.0 via Frontend Transport; Sun, 27 Oct 2024 12:39:54 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 27 Oct 2024 05:39:43 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 27 Oct 2024 05:39:39 -0700 From: Gregory Etelson To: CC: , =?UTF-8?q?=C2=A0?= , , , Suanming Mou , Dariusz Sosnowski , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Matan Azrad Subject: [PATCH] net/mlx5: fix GRE item translation for root table Date: Sun, 27 Oct 2024 14:39:16 +0200 Message-ID: <20241027123916.114037-1-getelson@nvidia.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B06C:EE_|IA0PR12MB7580:EE_ X-MS-Office365-Filtering-Correlation-Id: 9d9abff7-ddbd-4986-15fb-08dcf6847553 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?/xB5YQ8CQ9TnKpZBTEeE/fbYCteBtSmIYxupEfwIV2wXimqzHzQaO8wSyi2y?= =?us-ascii?Q?LDcJtNL0GZpQgBTuQo4l4eGEw5ROddYRq7wz0o/NHwFkM0eHWAVxVok3UUoY?= =?us-ascii?Q?fPRzb1KqY948VPoy+DP6eC5dHPiGOu6TSr6bcTKesqmZkEVHpB12Ab5vAl2i?= =?us-ascii?Q?AFYM+ZVkZEma7PX8uxOArsqvF0bkAvuF6pb/A1X0leoK9N6aEHeIPoa3ImC/?= =?us-ascii?Q?/caDyCcftwhMiml7fEi8IPqHZZprAGT/tSRo486KNffBWScMKjYtITWmNf7N?= =?us-ascii?Q?620YOKhebFh1Ka7efts8mY3UQ62IUcXHK/8lghebadNPkGq10lQVvDagjg2U?= =?us-ascii?Q?UC4icbPIy0VxZaXKpxKWSJNRkk9I9qsXSmTEzX1oZf4qDka2atpgwWzLVrxi?= =?us-ascii?Q?yoVbVP2RLqM7o0U9tQyFq3WF8Fj01DhaopTnfclsTS5vEk9wL1NcPUOikcgY?= =?us-ascii?Q?mHT1h6tp3FrFHkVky3a6UOxr3bcNuGJyaF0qdXKpUaIIt3/kNgvsqVuT1Vb+?= =?us-ascii?Q?ARCWlK9sqP/cKToB0nYujpYRtK0U8UaP6YIY/zurmyHy6raXk8hAnjE/qA7y?= =?us-ascii?Q?7OcZalJNpPm74P2T+KWiV6kf5Z0fjw2VMR2CpgDFFAaSO/A0CpcoGapxM0ly?= =?us-ascii?Q?iEPDTOrWT1t9tZYriyrmnvWqxTAmBLlRXgzn62Ph5lkh7uDePcDs6pTwDxdU?= =?us-ascii?Q?/7D8IzXBr7ZLQObmmcUj9E+EdKB2GXtR55L9i4Xur7/2P8Zp9wVZAl6Nakbh?= =?us-ascii?Q?wkAW5ff/GsBld3Hlr+pyXGVVf0Yc7f8u1rt9bFPry+zSAKj5SkNKj0GvGMNY?= =?us-ascii?Q?hoCsVuasi3a1PAqgH0FBUTh1fxZWhZWQ1NcBGfrea2llfc2H1aNn4IxlF4aC?= =?us-ascii?Q?Y6T657zosZunNJc8VvAQABes7Wg7lt2UoSuQvgBD9WWgSmu1InivgI9KHkWd?= =?us-ascii?Q?ilxIfc4zA70pREa/2Yk1a+WosFmuboxDQ31piWr3TLv3K5m57dpZMREdLIYK?= =?us-ascii?Q?NxuY9y5FapSR8/yd7CJcNNn6nJiK6L6iZplUVtKcjVXrE6zxkQmk4Ts+EEOf?= =?us-ascii?Q?YTo+zU7jj24DdRPzdGXMzPSQMXsuCq5XrE2w/PCzv5pXJp3MKWVb7EXi4W6r?= =?us-ascii?Q?irlNSHZvFa+R99qL4meXo7ZlBYEiVNLCJf5tGzTCOkX0XdV8wLQgO90gD1a+?= =?us-ascii?Q?Ygr8oSDnvtqhJE9HL7Z7PtcYt+I5Jf8LvSaEmJDcPDWDXku3xyXhEBBoDg9h?= =?us-ascii?Q?WjkUmfHLb6Ez1gg7jmLosQ7ZE4IEY4lMFGVd8r7YiDd7suSPoMPTmoF/dgC0?= =?us-ascii?Q?P0JoKzu5DwpZxcCaL0FLvfDgzDJGoxT3g7AeefNHfetfBKqgUn/ZIU62+iq4?= =?us-ascii?Q?M/61i9bv6bygIvdfNLPiKs0Jtt46YmGpXjJs5mg67gLlWIsIOQ=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2024 12:39:54.2231 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9d9abff7-ddbd-4986-15fb-08dcf6847553 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B06C.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7580 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Flow items translations for the root tables reuses DV code. DV GRE item translation did not initiate item mask for HWS template. Fixes: cd4ab742064a ("net/mlx5: split flow item matcher and value translation") Cc: stable@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Suanming Mou --- drivers/net/mlx5/mlx5_flow_dv.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 201e215e4b..7c3a1d537a 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -9829,22 +9829,23 @@ flow_dv_translate_item_gre(void *key, const struct rte_flow_item *item, } gre_crks_rsvd0_ver_m, gre_crks_rsvd0_ver_v; uint16_t protocol_m, protocol_v; - if (key_type & MLX5_SET_MATCHER_M) + if (key_type & MLX5_SET_MATCHER_M) { MLX5_SET(fte_match_set_lyr_2_4, headers_v, ip_protocol, 0xff); - else + if (!gre_m) + gre_m = &rte_flow_item_gre_mask; + gre_v = gre_m; + } else { MLX5_SET(fte_match_set_lyr_2_4, headers_v, ip_protocol, IPPROTO_GRE); - if (!gre_v) { - gre_v = &empty_gre; - gre_m = &empty_gre; - } else { - if (!gre_m) + if (!gre_v) { + gre_v = &empty_gre; + gre_m = &empty_gre; + } else if (!gre_m) { gre_m = &rte_flow_item_gre_mask; + } + if (key_type == MLX5_SET_MATCHER_HS_V) + gre_m = gre_v; } - if (key_type & MLX5_SET_MATCHER_M) - gre_v = gre_m; - else if (key_type == MLX5_SET_MATCHER_HS_V) - gre_m = gre_v; gre_crks_rsvd0_ver_m.value = rte_be_to_cpu_16(gre_m->c_rsvd0_ver); gre_crks_rsvd0_ver_v.value = rte_be_to_cpu_16(gre_v->c_rsvd0_ver); MLX5_SET(fte_match_set_misc, misc_v, gre_c_present, -- 2.43.0