From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF43A45BF3; Sun, 27 Oct 2024 15:10:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AEE24026C; Sun, 27 Oct 2024 15:10:15 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2086.outbound.protection.outlook.com [40.107.243.86]) by mails.dpdk.org (Postfix) with ESMTP id 99EE140151; Sun, 27 Oct 2024 15:10:13 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=VjtTX51Nw8alLZ/s/zBc7zhQT79Cy1Ta1h5lre0q7PczHFLNUvi/jHe7G0ayFYdcDC5OVOnVaDkoGxlOT9J1ECIQ8eU11B7B2pu9Zgub6FEzPl6J7AG5D3pZO4cYV3gpsoXj/bE0mYaXe0riXfu7bbnL6ffmpgZ6ZccNhrhMBLBgCEdLOf1oCQ3BVihc5Wl3FVkvHPELVxrrKwVf2D5oeOUF+fs6eV5BG9I9ph3uhefCcSchpiMmJbvQt80EGkpH5IhOEOabvpHWdHNykQq9xKx/VJJ+FPFsN9b4O/tNRyzo76XEgGGBXiMqTtWc0xLqUdbJOFXK0V5auWrP4WaTrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JMXpVMYLqydnFCSCjo47dl0aHrEYk6vtPHnk2FIumDk=; b=Zq2zGCkxOhyrK5WrP4ZUFrak/ekI92W7RlvpiJjE1UjzbO+QKT2eFyprXUVhawXIQ16r4xMX3b1deFy+SkD0TRXeWDqPb36usbbn2Y0yh8J8TN9cZ4V6f/FhSaC1Ic62rt2rMhy6/CawFthD1kGCv9rW6tzQshK0ortgR79N5kw5OQqyvUa0U9v4Md7nSeg84Dm1lx4H+cJy3Q1jHXpPaI+ziW2Ep2VSCzkM5k32BtcDhbeEkTgyqcwGuyFKQc+nuyyNjGimYrOZd8Ot/soQCdPwJYWKOjhZUiO3xTz7RkGMwrC0GEbP7e5ie30AD/ZdapTmaQ+EBk+1gdZmOsLn1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JMXpVMYLqydnFCSCjo47dl0aHrEYk6vtPHnk2FIumDk=; b=Ybcn2cRPN5AuqJlX7RubLA5Er24g04e3Icp9pPFF8ab8W5DR5sckqdenHfV7fl/exLeJpsCKp9FQ5ezCHrZeijks8MaY9OxVEXfKi6A8g4NizyieueeOaT11tvlDqbT72dbbXdBMQbNCpcS4QMNF0mHaqZCv2kkl4X4Akk+0jQOITt6mPKNqLZgXx7CoKeGC4t1rlfepHuJygdq7dLb81BzVJK2WdRp//RBW4rzwJw1aBJoB97EMLaDz3zLvO+14iTsTQyIaf8z835bWzGbxkUOSHgTwb7SDDUwuAZs5G80Fmm68QeolOCyvDp5k4+flWhaMtRcf159yPu0KwjklYg== Received: from PH0PR07CA0001.namprd07.prod.outlook.com (2603:10b6:510:5::6) by DM4PR12MB7502.namprd12.prod.outlook.com (2603:10b6:8:112::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.24; Sun, 27 Oct 2024 14:10:08 +0000 Received: from SN1PEPF000252A3.namprd05.prod.outlook.com (2603:10b6:510:5:cafe::a1) by PH0PR07CA0001.outlook.office365.com (2603:10b6:510:5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.23 via Frontend Transport; Sun, 27 Oct 2024 14:10:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SN1PEPF000252A3.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.14 via Frontend Transport; Sun, 27 Oct 2024 14:10:07 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 27 Oct 2024 07:10:00 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 27 Oct 2024 07:09:56 -0700 From: Gregory Etelson To: CC: , =?UTF-8?q?=C2=A0?= , , , Dariusz Sosnowski , Viacheslav Ovsiienko , "Bing Zhao" , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH] net/mlx5: fix internal SQ item definition Date: Sun, 27 Oct 2024 16:09:40 +0200 Message-ID: <20241027140941.127233-1-getelson@nvidia.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF000252A3:EE_|DM4PR12MB7502:EE_ X-MS-Office365-Filtering-Correlation-Id: f2ed70bd-cbb1-4baa-d252-08dcf691100a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?RrDQGjcRFmaAm1ni7x4KSHRdUllarF2S+TAc51gm4JYbvsPoFlKn4K9++iui?= =?us-ascii?Q?3tDFxePenu1VXZr/6D8PudWy2P7+LOF/OCdoNSGXXj1w5fwCzYRhf57YNWlY?= =?us-ascii?Q?H+dYVYu60i0xiCutUsxa3MeQrbToQJ5bCNVcKukCwR9tqVhdv3UqSloQ1Oob?= =?us-ascii?Q?NeftLSF6ttArFMlRBT2YWKD/MgpaTBk61Z5CibQJZmJsHmjRl/wS456lurvx?= =?us-ascii?Q?GRzbdLb4BQEph0v19Fb9b2qnoxolXTDhHowgxyMUT/v24G29qgq3eCf6QNQM?= =?us-ascii?Q?sVeUNKwQeehKGJ/UEG4pXo8ACQQcFuuoB/2iMbNXBgZ744Pbye21HuReLitS?= =?us-ascii?Q?iprfCWdzjxBgocHWpGzHfAD2GGZYemy6BS6TollFJ5NT4MjWZi2Eet/W1SKM?= =?us-ascii?Q?bl/FqCmLZt/JylfhnCsdb1rAMR2mVYLSu8UMiBPhr1oL2h9b77QnLeG8TDzS?= =?us-ascii?Q?VenUg52RfrX744Ujg+WY0mcNl36NpnvQQOPCwehMhgUtcDphL2JhjdqmQMsS?= =?us-ascii?Q?j3eoMnA10uFaEXzPfWYqVxaCYzDDAnFaHUf0nlUoYms/bcr/V+9aYn0kUFW8?= =?us-ascii?Q?Aqjnv1G4pxsAh7LLq7i0UH1kDGGfXk+k7dO9s+QrbcYaHc/ietVsM9gUJSIn?= =?us-ascii?Q?+9JGv0gniv/FDhAyeeobXHffTYikszZP7Kn90L8idbaJM0+grkGmQbqiYE2q?= =?us-ascii?Q?i56yPRA2GzNsrQ/kBdO3pzmvsP8jKLXpgqxhSHb26LkA5CuwZGxHrdVFcWfB?= =?us-ascii?Q?s33nEOsUp1eMX49qlLj6MTP4NGp/COvls27HPZzaEa7uGlT61vdEGtAAdHov?= =?us-ascii?Q?874X8Jrx2sF7qCpvy+hx8a6kxel3E/T/a4yM8x+Q7Krx9rtFU+0fG3ZzgROI?= =?us-ascii?Q?FEJh1FW+u9E42Q9P0E7b9tso3NoLgqlRX56oibuMh7C3W0yIjYWk4VyRd0Vl?= =?us-ascii?Q?so/G4/eVdPztzk+RoO7ubW1CiHEr1kuOpIi8lHBFaXsTK/8jjj0Arbl6xR1U?= =?us-ascii?Q?8GmYAmTyv26c7/98jxFk9HCXZn6jUMtnDFOoCpE5OTOZJoUdFWX2/05OjYOG?= =?us-ascii?Q?mUfsMxBOMXaXBzISnBEfjZmvzDMW6qVp864tspa7yfLEDiANhPEs7Yg7NeBR?= =?us-ascii?Q?87sQBALMR9Bha2yvMmFrLQgXvXPaPVYPim58YQDClyfShcJmqHMcjMrfATnB?= =?us-ascii?Q?uS+6SVukIzIS0PMHwZc0kp2G/pfRbajC/9qIHk5AZiDR4C8NgTPC1eyo+pDm?= =?us-ascii?Q?GkJ+2PLiYzdAkQ0R7Iyls3FUi6rX+kWlzsG915800a+EQgyiYd/8sy2/wbb4?= =?us-ascii?Q?qa1NcEvcyPLzBKQFABnZBul/qTTDwMpyYo+pFEQiI/MOcBSu9x+DW8hUEFaC?= =?us-ascii?Q?3X8ek4Y+xAdXpDS6Quozn1TgneVCy7D42Wl5lnY4MzJfCnaXVA=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2024 14:10:07.7883 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2ed70bd-cbb1-4baa-d252-08dcf691100a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF000252A3.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7502 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When DPDK copies flow items with the `rte_flow_conv` call, it assumes that size of PMD private data has pointer size - see patch [1] MLX5 PMD defined `struct mlx5_rte_flow_item_sq` as 32 bits. As the result, on 64 bits systems, when DPDK copied MLX5_RTE_FLOW_ITEM_TYPE_SQ item, the target buffer was assigned additional 32 bits. The patch expands size of `struct mlx5_rte_flow_item_sq` to 64 bits on 64 bits systems. [1]: commit 6cf72047332b ("ethdev: support flow elements with variable length") Fixes: 75a00812b18f ("net/mlx5: add hardware steering item translation") Cc: stable@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h index db56ae051d..9cf54c3a6a 100644 --- a/drivers/net/mlx5/mlx5_flow.h +++ b/drivers/net/mlx5/mlx5_flow.h @@ -168,6 +168,9 @@ struct mlx5_flow_action_copy_mreg { /* Matches on source queue. */ struct mlx5_rte_flow_item_sq { uint32_t queue; /* DevX SQ number */ +#ifdef RTE_ARCH_64 + uint32_t reserved; +#endif }; /* Map from registers to modify fields. */ -- 2.43.0