From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83AFD45BF3; Sun, 27 Oct 2024 15:37:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C3D14026C; Sun, 27 Oct 2024 15:37:38 +0100 (CET) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam02on2051.outbound.protection.outlook.com [40.107.95.51]) by mails.dpdk.org (Postfix) with ESMTP id B4DF940151; Sun, 27 Oct 2024 15:37:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=PpoyiHfjcGpWWUrPN+bcZbfLltx8RDNz2sudLRydSjX/FBMKVmxXTBznskjhdUnzEKS55QRYMSQRkmeJ4CtVcKTfJGq1v80ZLqr/8wsWYz5BsabjWnhcj92Kjd5hGsn8AlL9oWOvPuOKtSq6cus4/eNA158Mr/mTAwrxqfKKIfrQBRi2gsY7mIanWNQ0pRynxlKV0bjZ35SnJ7ZlECfdOxxDjlgIqrlBLi2dbnSDxH4stFg6w9S0+/u4M89CueEVxZfY/Re1eNYrg62ifKj3npaSeBLLHb9sJoddjS+cX9KJWlk6OhCRH7PNCiTxjL8lUCziWn2gMydcQsBbWWCPSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bJaed+NN5pD1tSrKRr6EQn3iKuxgLZkMRTc2LSLKU9Y=; b=L404cIEtqyVBbQ0f/xP9urI8fLfMR5cIPAlJltUBwAv+UuyRqSCNMB/LkUlrSPPuU9PA9rkv6BuiO8vMR02zvnlZJtUoXY+zd6vowen2aQzmwzWo0sJ1cMy+ta2poY/mD8h6UOnNDOaX+dLyYWlzz0B5cjFQr+7VTGuE8usxTf+41eaJRqMTTN8ruMSJZxmYTc+EU9W68lLmB+/psTwTxxh1xpMYiHV9MntxMAdF8gJuwyf46glwX3vrvspmZnOQX3Givp4hF/9+Y2TrMDkuV1BJWmkJeU9XL6L9R4aQRR2Pd9Yslk0UpF2vp5WHibllI64BaRJnry/oZ0DVUqFrpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bJaed+NN5pD1tSrKRr6EQn3iKuxgLZkMRTc2LSLKU9Y=; b=onyE0VkwyVRzuY6u4pna6GVcp1WXnNGoD6Pz3I2rClgQIdoYHzvkhuS8gYF7qUfb23kDJFpEvlM970yqdX3ZhvseoG65vRNwhYc6LNRmDc9BrF8SRjJ+RmB0+IBYhGw7SobMyWCEpBCR7W71ZveajThQlmd7kEe22NM3z6ONlndS+UYH+DpBzFcQ131Mk1RfrLfjhLAhePVjLbgoivGeHhUvs2GxfKoso+TwS7Zkm/KGEirE/2bflEGy7+xzN9OVr9EqQl2ju+/UkI2WiWzC0xmSrMoafT0ToQ9m4N5O9COYNF6s8L8v+GbsluBM0qXfR8tr2pJaK9oYAX6uqlkTOA== Received: from SJ0PR05CA0076.namprd05.prod.outlook.com (2603:10b6:a03:332::21) by DS0PR12MB7801.namprd12.prod.outlook.com (2603:10b6:8:140::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.23; Sun, 27 Oct 2024 14:37:30 +0000 Received: from SJ5PEPF000001CB.namprd05.prod.outlook.com (2603:10b6:a03:332:cafe::29) by SJ0PR05CA0076.outlook.office365.com (2603:10b6:a03:332::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.8 via Frontend Transport; Sun, 27 Oct 2024 14:37:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001CB.mail.protection.outlook.com (10.167.242.40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.16 via Frontend Transport; Sun, 27 Oct 2024 14:37:29 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 27 Oct 2024 07:37:22 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 27 Oct 2024 07:37:18 -0700 From: Gregory Etelson To: CC: , =?UTF-8?q?=C2=A0?= , , , Dariusz Sosnowski , Viacheslav Ovsiienko , "Bing Zhao" , Ori Kam , Suanming Mou , Matan Azrad , Michael Baum Subject: [PATCH] net/mlx5: fix non-template API actions template validation Date: Sun, 27 Oct 2024 16:36:59 +0200 Message-ID: <20241027143700.160638-1-getelson@nvidia.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CB:EE_|DS0PR12MB7801:EE_ X-MS-Office365-Filtering-Correlation-Id: 39a37882-d897-406e-3a82-08dcf694e2c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jrhkF/Mfqaxt3MF35Y6tx/bAfqzQSZqSfz+BF3PksPLeaKVPtjCvIbPShRKh?= =?us-ascii?Q?k+hkbF739Ul53QgArO05Hxte7ZecGtp0ijd5t5qY+YtWvGhYhQ2tABgJVHqy?= =?us-ascii?Q?7DBO17xujhAKWE/H5qzFvB3aVcaaXxZEezk8+wDZrjxQ7lVkq5ivawKqXo01?= =?us-ascii?Q?hrWR/IdFQW9NH48eRHzHiAKeTMENg2mWW72XDyUsx/BbOlBIarF324eKcwC8?= =?us-ascii?Q?fOgN1ZMCP9thAwDB/oX9kWSXaxJh8gHNW6L5QABQQmAyJSDkV5mDuR6Oq1k4?= =?us-ascii?Q?/37XRlAND12BVXh4eQOk9odajVX3VDZMt1zWNkIjMVsnFAzlkpvPMiEUOQY5?= =?us-ascii?Q?26IJeLN55n34KS4QKViZGHFqga8XWLehsOkUwDzqHmaoYWhPURYWVBhgzPgF?= =?us-ascii?Q?Gf/ax/5bRL4MrdvrcV8ho5V57cz1yn7CcysTknKOst5HDsTZzt26d6SDM4q+?= =?us-ascii?Q?r7dtagoNhSkh6E2o1tW6/BX/vAfAiFLoxqBYH8WS/svELgwl12Exl15fMkoi?= =?us-ascii?Q?1WDE5xaymfGmTW44P9gYeOKwDSET7o+IbS/7ABJlmZxdRhDF5OX/ah/6RQhJ?= =?us-ascii?Q?BgIos3Brz9vr+BvNcuuMsyCWb8EHuj424rRa70cxR3OprTxk4D5Quh71SId4?= =?us-ascii?Q?lasx6usz8Ahwu9AmnsWHbicGFBdRUnwIoc2n0FylqcvD7C8IW9gS42/z9NH4?= =?us-ascii?Q?phsl7r84C85Y3q//YxGIxWtYm/+o81C37S8VZEII4Q4TEq7Fz8OhNubYkgiA?= =?us-ascii?Q?heDtES4aS2A8aTDPE7z+PGa7mN3+lMYfU52G0h3aAtHSioVzVp6FAR2s/slu?= =?us-ascii?Q?BonhkaaZPuuo0GlABcaJxU2N4hPDXdOk3dXHy7xWbynG4Dy7HqLjl/moT+0u?= =?us-ascii?Q?+fVL+BmwLLPhX7+SX3eV4065jy8/Bk8HuSn8felSuqYlK9X2wXpC21Q+9zPQ?= =?us-ascii?Q?0hYanvOPNvXVJJBwM7sFzEKpfI8g7EHhBRAXeoVbLF8ZUigdmpW6e8hj1B5O?= =?us-ascii?Q?TJmqn34R5nY+NWoiwU4yF1F1ZBXwl4IF0TZ+Se9X63CATcSdjZOZ62paQD2j?= =?us-ascii?Q?1NfpczlHzHec2RU2KJD7A1iLGFCMBwdUpdSeZDzgA+TW9aukQop0+O6Ta9zv?= =?us-ascii?Q?Z6FfQW2YB4hU1wZYHOUX7JLJ9mwI6/GMi4Ovsegme/5Ux5GnBDJDaB/2GnUD?= =?us-ascii?Q?gArgY1XtELJsHpBzNyytCFuV0d6ophRDBNmjdFS+WxPhxZMzlDo6UJ0kz2q7?= =?us-ascii?Q?w/nBEa6etdH2jitQZqjpLidlWdZeIrA4ktq6A/gEvVoRLVWQZNtreu1Ffq/8?= =?us-ascii?Q?p2Y0pdunMt+t49wqNGtIaLSLMySfr2rLBwXr9X37/XBdX44TddAq6sw+iTBs?= =?us-ascii?Q?NeQahzCMsAjNjtMVV2DMEnfnWqZh2LwONxwIXh7sbnVx0YGirg=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(1800799024)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Oct 2024 14:37:29.9977 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39a37882-d897-406e-3a82-08dcf694e2c8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7801 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org HWS actions template validation checks actions parameters in actions masks. Non-template API does not have actions masks. Actions templates in the non-template API are artificial and created internally by the PMD. The patch removes HWS actions template validation in non-template setup. Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS") Cc: stable@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 5b34154bf1..c9bd9f229b 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -7873,8 +7873,8 @@ __flow_hw_actions_template_create(struct rte_eth_dev *dev, uint32_t tmpl_flags = 0; int ret; - if (mlx5_flow_hw_actions_validate(dev, attr, actions, masks, - &action_flags, error)) + if (!nt_mode && mlx5_flow_hw_actions_validate(dev, attr, actions, masks, + &action_flags, error)) return NULL; for (i = 0; ra[i].type != RTE_FLOW_ACTION_TYPE_END; ++i) { switch (ra[i].type) { -- 2.43.0