From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BB6145BF5; Sun, 27 Oct 2024 18:12:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 230F440691; Sun, 27 Oct 2024 18:12:03 +0100 (CET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 236B740665 for ; Sun, 27 Oct 2024 18:11:57 +0100 (CET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71e49ef3bb9so2354824b3a.1 for ; Sun, 27 Oct 2024 10:11:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1730049115; x=1730653915; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wGBoRycky+Hxi1ZCIpwWoxDioS0ofUHY4fuHT13wH2A=; b=ATJuG47/trMZonJr3pLtlGUhmtbqaQqd9AfA8J6wlAU4Yd4OumEgOZ6RdIn/6IbpvE xCyikh29YlW//ZcVmY4XPnTgY+FhleBIHL9khF+1WancK6O1L11c/MA2Ik+EUBN7eKVo UxT8Bpee0Jd6KDa8KCHuZ0tKSwm5lI4L1p4HU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730049115; x=1730653915; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wGBoRycky+Hxi1ZCIpwWoxDioS0ofUHY4fuHT13wH2A=; b=OVnwDwH2tskx23iDSHh6xAEftt79pPiJLP77P8SW2h+4ZO/5623s41MtJEA4AKx0k1 gZOtGkS2BjliS+A3Y5k3iRO7qc7Vf9if/VW+bhxLbenW7TLBextVNEr8a0KdLdhpgSDu 5k/wqzZzKZMjj8GpSx4CnWA8/6HM8OVafjI8mHtpocB8kF13hwcGVzaKISswhsL1tOp1 L3aocAPFIuYt2aj+XYIJcCDTvZboKI7shQRg6X3kpE8rNuGJy5SSi0eVlOWrGqWHGD4/ c0YbaRTnSARo3ou6FG7ArKvK2PMD2Yl0zY2Svo59GhIAGlHAf+uwkSLXz6woIOZXuDRT EI1g== X-Gm-Message-State: AOJu0YxzZom83MsteaQb5PQAmnfnTBZHfbsssuK45jm2UujHxMxXQW04 V14ywvh5B9CF7sQR/tnFua6BCr1jxl7fd9bjB7W9wSUqISf+W53+L8dVPgWAAY0A32XBlSMLzg/ qbrkWgzLDuzIo0Kps0KCvEVPSl0eYzF0MiDFpvGoFUP3zBrI6WTZYuFdPnKn95PQ1stMG7dse9x N5WzEtq74N652VzbhsVhtBEhAw2WTd8y8= X-Google-Smtp-Source: AGHT+IE/MsCvYUglPwBHyZSc0KaLd/objwIIsEQWsg0uIBQiChQ6NgZOQWuzh7PbQ/ixQIYrp/vV0A== X-Received: by 2002:a62:ab0c:0:b0:71e:591d:cb4c with SMTP id d2e1a72fcca58-720452076d6mr15833877b3a.1.1730049115374; Sun, 27 Oct 2024 10:11:55 -0700 (PDT) Received: from localhost.localdomain ([136.52.21.78]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a21ccesm4269158b3a.167.2024.10.27.10.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 10:11:54 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , Mike Baucom Subject: [PATCH v2 09/13] net/bnxt: disable VLAN filter when TF is enabled Date: Sun, 27 Oct 2024 10:11:24 -0700 Message-Id: <20241027171128.50221-10-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20241027171128.50221-1-ajit.khaparde@broadcom.com> References: <20241027171128.50221-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kishore Padmanabha For p7 platform, the vlan filter and strip is disabled if the truflow is enabled on the platform. Signed-off-by: Kishore Padmanabha Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 6 +++++- drivers/net/bnxt/bnxt_rxq.c | 17 +++++++++++------ 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 890c9f8b45..d3ea4ed539 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -2964,7 +2964,7 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask) { uint64_t rx_offloads = dev->data->dev_conf.rxmode.offloads; struct bnxt *bp = dev->data->dev_private; - int rc; + int rc = 0; rc = is_bnxt_in_error(bp); if (rc) @@ -2974,6 +2974,10 @@ bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask) if (!dev->data->dev_started) return 0; + /* For P7 platform, cannot support if truflow is enabled */ + if (BNXT_TRUFLOW_EN(bp) && BNXT_CHIP_P7(bp)) + return rc; + if (mask & RTE_ETH_VLAN_FILTER_MASK) { /* Enable or disable VLAN filtering */ rc = bnxt_config_vlan_hw_filter(bp, rx_offloads); diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index 249fe7f6e5..8b8bc6584a 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -28,18 +28,23 @@ uint64_t bnxt_get_rx_port_offloads(struct bnxt *bp) RTE_ETH_RX_OFFLOAD_UDP_CKSUM | RTE_ETH_RX_OFFLOAD_TCP_CKSUM | RTE_ETH_RX_OFFLOAD_KEEP_CRC | - RTE_ETH_RX_OFFLOAD_VLAN_FILTER | - RTE_ETH_RX_OFFLOAD_VLAN_EXTEND | RTE_ETH_RX_OFFLOAD_SCATTER | RTE_ETH_RX_OFFLOAD_RSS_HASH; - if ((BNXT_CHIP_P7(bp) && !bnxt_compressed_rx_cqe_mode_enabled(bp)) || - BNXT_CHIP_P5(bp)) + /* In P7 platform if truflow is enabled then vlan offload is disabled*/ + if (!(BNXT_TRUFLOW_EN(bp) && BNXT_CHIP_P7(bp))) + rx_offload_capa |= (RTE_ETH_RX_OFFLOAD_VLAN_FILTER | + RTE_ETH_RX_OFFLOAD_VLAN_EXTEND); + + + if (!bnxt_compressed_rx_cqe_mode_enabled(bp)) rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TCP_LRO; if (bp->flags & BNXT_FLAG_PTP_SUPPORTED) rx_offload_capa |= RTE_ETH_RX_OFFLOAD_TIMESTAMP; - if (bp->vnic_cap_flags & BNXT_VNIC_CAP_VLAN_RX_STRIP) - rx_offload_capa |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP; + if (bp->vnic_cap_flags & BNXT_VNIC_CAP_VLAN_RX_STRIP) { + if (!(BNXT_TRUFLOW_EN(bp) && BNXT_CHIP_P7(bp))) + rx_offload_capa |= RTE_ETH_RX_OFFLOAD_VLAN_STRIP; + } if (BNXT_TUNNELED_OFFLOADS_CAP_ALL_EN(bp)) rx_offload_capa |= RTE_ETH_RX_OFFLOAD_OUTER_IPV4_CKSUM | -- 2.39.5 (Apple Git-154)