From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61AA645BF5; Sun, 27 Oct 2024 18:11:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0CA14064E; Sun, 27 Oct 2024 18:11:49 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 38E16402F1 for ; Sun, 27 Oct 2024 18:11:45 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-71e5ae69880so2541871b3a.2 for ; Sun, 27 Oct 2024 10:11:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1730049104; x=1730653904; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xeq5JUB1b6HXK+w9i2aJfKsRO1Hes6bBbc2MvfUkJbY=; b=LndVGnL6GKa1Kd4cOG0Al7a17nptT9IRg0onYpKcXnGJ+/LJ+hoK6m83dS0G+PUBlY 6rYJekRrzdoRttO2GhB6qZC5nXZ1gxo5yRtuxMaQCrrhcMHXxA5ePGuomO3Q/lK5UpGV tOQd66779ixvwvd34suy6K3zZAzbaPdte8c20= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730049104; x=1730653904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xeq5JUB1b6HXK+w9i2aJfKsRO1Hes6bBbc2MvfUkJbY=; b=BO3Xh5cRA/LUCC6EIrtGu/oFOCowbrjcZ7oN337af5MZsvu4lmBswJLIhpT/Is/u+k o5eUP88y2dSbdhGQchWYqnzhh6mD11hiNPt57C+uaiZR75C9CcyawxHYEUSQXisSFb4l dKHEzj2dG02YSeAcCGn/P/ok0/+DUY+/zBcHY7kXxnKJb2uLMSZzPYyMKrKo2+1fnEr2 tvyIu3zEneijm8vV1DVnBKpEEDXkhZVeRHHiutbagLaqCfhQBVdsZuhR+H1OHYYe3bcQ AJSJA6hm42NegBXFTpDQK8PL62Jwd7GbbyiyEVekBB3xkUP6FF+6Nns4QBvRrcTqFyzS sVWw== X-Gm-Message-State: AOJu0YwLSWFA6UCQ0q8WJhChYT+/dRy9wz3MG+lqvKI2DCmDdtiboBp4 sU31jAb+4nQsWC5Gz864FIswIxzcUTZItBECZ/qnfjolsZ7QpY81BFFNQdzNrqE9IlFtYgi6Vyf 5Px0vspErk8wwHcNhB1nO0P0e5VS9T2LRhZgLLzu6VB41vjiVRUeIEYyI0/15i/QldgxIyKvpL+ 8OY5lbT4mAqadpSGc5shag4NKNNAqfb+A= X-Google-Smtp-Source: AGHT+IGPl1ui3iu2yz3ihwGNjEmcbH4KPJZzCk+HNaUs3Z8kNZkjHTsWasPxgPZjIxcGbFSG3u4ZCw== X-Received: by 2002:a05:6a00:2e07:b0:71e:6743:7599 with SMTP id d2e1a72fcca58-72062fa19b0mr9615039b3a.7.1730049103730; Sun, 27 Oct 2024 10:11:43 -0700 (PDT) Received: from localhost.localdomain ([136.52.21.78]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a21ccesm4269158b3a.167.2024.10.27.10.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 10:11:42 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Peter Spreadborough , stable@dpdk.org, Kishore Padmanabha Subject: [PATCH v2 02/13] net/bnxt: fix bad action offset in Tx bd Date: Sun, 27 Oct 2024 10:11:17 -0700 Message-Id: <20241027171128.50221-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20241027171128.50221-1-ajit.khaparde@broadcom.com> References: <20241027171128.50221-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough This change ensures that the high part of an action table entry offset stored in the Tx BD is set correctly. A bad value will cause the PDCU to abort a fetch an may stall the pipeline. Fixes: 527b10089cc5 ("net/bnxt: optimize Tx completion handling") Cc: stable@dpdk.org Signed-off-by: Peter Spreadborough Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_txr.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 38f858f27f..c82b11e733 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -308,10 +308,15 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, */ txbd1->kid_or_ts_high_mss = 0; - if (txq->vfr_tx_cfa_action) - txbd1->cfa_action = txq->vfr_tx_cfa_action; - else - txbd1->cfa_action = txq->bp->tx_cfa_action; + if (txq->vfr_tx_cfa_action) { + txbd1->cfa_action = txq->vfr_tx_cfa_action & 0xffff; + txbd1->cfa_action_high = (txq->vfr_tx_cfa_action >> 16) & + TX_BD_LONG_CFA_ACTION_HIGH_MASK; + } else { + txbd1->cfa_action = txq->bp->tx_cfa_action & 0xffff; + txbd1->cfa_action_high = (txq->bp->tx_cfa_action >> 16) & + TX_BD_LONG_CFA_ACTION_HIGH_MASK; + } if (tx_pkt->ol_flags & RTE_MBUF_F_TX_TCP_SEG || tx_pkt->ol_flags & RTE_MBUF_F_TX_UDP_SEG) { -- 2.39.5 (Apple Git-154)