From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94ADE45BF5; Sun, 27 Oct 2024 18:12:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2476240662; Sun, 27 Oct 2024 18:11:53 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 0EBBF40650 for ; Sun, 27 Oct 2024 18:11:50 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-7205b6f51f3so1488025b3a.1 for ; Sun, 27 Oct 2024 10:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1730049109; x=1730653909; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6ja6CwJEciD+8XYk5tRZEn5yghnsonZ3Y+c4t/l9rMs=; b=DAiq+bktrKby4Hfsxo3O6OpbcLUx8WTewJIg1boZ9CJOqF5x5dJIU/Hb3eruZQDdIA FMNN071FbbO4mnXm3aP3oWS9mHIBV06X2QAdFr5gfYGUdhpDOKaiQWQzYpjeLzoPaITf j0BU28ZJysemqpH6nKnNkOzXnSyfukDYWn16Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730049109; x=1730653909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6ja6CwJEciD+8XYk5tRZEn5yghnsonZ3Y+c4t/l9rMs=; b=nOtzWewSjZ9jzeu9hLOtX5sljbD5WZK7IpphNY/v7ERVsUzgAJJbgKjCAh76KlCanj 7GNnP9D2ZdRWbSzrrig3TWLqPKXP43TtUt7TE4TFqorvXdtkpH7E81OtZGVpIRENpafE HtECTJt3UmtHLheOh+xxv3zH7RJBHQpO79ufAJmGxxkM9z6DfFpJbjzXn3xnaoWdVv49 eCbKHB34dN8cnsW/mMDQ0oZ0e2HNerQelrJjp6D0XHhMExUkKMkAUflNGcxOUOCe/rai wk7YTnMZ0nTqxGAdzl7DEjDpW4nJYzovHH1y+iecKWe5qp1pzy3tymdJA1u4wZKujAhG k0rQ== X-Gm-Message-State: AOJu0Ywc0OZ5ib4wF1tvSVkJZ1UxvaGsDPkzgDiVs+mEbAQvi8Alj7vh fi+VbO+5R+p8FVBmDjc8FrSx7SPI9IOEN+ef6XU1vBnUiYF45Ua9InG1vqTR5/N2+F+OJ3E60w4 p8QiCPJO3+0LKdP+zUOu3gBj3uhyXlWXOLoT0LohE8FP33nH5tIGwPR5Nk08WHPdal509aHeoqX GLQNYlo/s7WAlpkaeBuUjspqSJSXF7GdI= X-Google-Smtp-Source: AGHT+IHARKzl3cYbmy1BQKGTumXP11x6DM5QGCFWTAARexNogIcogm+cgUGsSnKcCSqsz7dt02HZMw== X-Received: by 2002:a05:6a00:3d0e:b0:714:1d96:e6bd with SMTP id d2e1a72fcca58-72062fb3da8mr9393147b3a.13.1730049108460; Sun, 27 Oct 2024 10:11:48 -0700 (PDT) Received: from localhost.localdomain ([136.52.21.78]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a21ccesm4269158b3a.167.2024.10.27.10.11.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 10:11:47 -0700 (PDT) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , Somnath Kotur Subject: [PATCH v2 05/13] net/bnxt: add check for invalid mbuf passed by application Date: Sun, 27 Oct 2024 10:11:20 -0700 Message-Id: <20241027171128.50221-6-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20241027171128.50221-1-ajit.khaparde@broadcom.com> References: <20241027171128.50221-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP If the application passes invalid mbuf for a Tx pkt, this could escape all the existing driver checks and driver could end up sending down invalid TX BDs to the HW. This in turn could lead to a FW reset. Fix by validating the "mbuf->buf_iova" or "mbuf->buf_addr" passed for the Tx pkt by the application. Signed-off-by: Kalesh AP Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt_txr.c | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 51d3689e9c..4e9e377d5b 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -209,6 +209,25 @@ bnxt_invalid_nb_segs(struct rte_mbuf *tx_pkt) return (nb_segs != tx_pkt->nb_segs); } +static int bnxt_invalid_mbuf(struct rte_mbuf *mbuf) +{ + uint32_t mbuf_size = sizeof(struct rte_mbuf) + mbuf->priv_size; + const char *reason; + + if (unlikely(rte_eal_iova_mode() != RTE_IOVA_VA && + rte_eal_iova_mode() != RTE_IOVA_PA)) + return 0; + + if (unlikely(rte_mbuf_check(mbuf, 1, &reason))) + return -EINVAL; + + if (unlikely(mbuf->buf_iova < mbuf_size || + (mbuf->buf_iova != rte_mempool_virt2iova(mbuf) + mbuf_size))) + return -EINVAL; + + return 0; +} + static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, struct bnxt_tx_queue *txq, uint16_t *coal_pkts, @@ -236,6 +255,9 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, if (unlikely(is_bnxt_in_error(txq->bp))) return -EIO; + if (unlikely(bnxt_invalid_mbuf(tx_pkt))) + return -EINVAL; + if (unlikely(bnxt_invalid_nb_segs(tx_pkt))) return -EINVAL; -- 2.39.5 (Apple Git-154)