From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A5CA45BF5; Sun, 27 Oct 2024 18:26:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADC874065A; Sun, 27 Oct 2024 18:26:35 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 528C4402F0 for ; Sun, 27 Oct 2024 18:26:31 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-20cb7139d9dso30552155ad.1 for ; Sun, 27 Oct 2024 10:26:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730049990; x=1730654790; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UfF5OFU4THEiQH/INtpTpQBZpms6s7Uvj06coYmX7Vo=; b=p9DIpqonmLyqhZT547Ig0QtxOCy9SmXG1YSX6fO8+4DrLeFKiLVbLw9LJJRUr6fsIT XDJ3Pftf0kidgMU+Y1NRPIaUy7rLk8gVjhZTZo5+2mg0A/aG0mJqcrCLv6tm2dx3ZgB7 aPhH3ZZbP+FF8EpVMo22cXWK0K/8scUsGQGTj0oDDbd1CaBtVAXcmAAMaA4vKaSymzCy lNnWFIVdyLLIJ7COLKVcfU4qkYZXb2q+830dn8VRlYmipTWp6ZtkXywJHM9KGlrGN+6j +IjyxE36RFtzCd354x+e1ZFl72AQmKReLPp/JZuHbourhgkBUGmQyVWlYccRnExWaa2I tmRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730049990; x=1730654790; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UfF5OFU4THEiQH/INtpTpQBZpms6s7Uvj06coYmX7Vo=; b=r/hnQu4ItO/yuBkd5f60uiCtw74xOzFgV+xlKCDfFj5sCiT7duBp68RcrvnpToElO6 xg8ukzQ36BTxhdsn8oGdBSCujZpxFrM+J8E+45KVdDJPp46OoaaXZZe2QH8XbPAJd6WQ Vll/2ca9YJba3PWxJZv9p8dnxO8GCoC8VZjAYdkv/ra5MDNF87HkZDs2MW1K1VY67ZGg BvOlPL/QPOnfHpvbclOHewt6hUiEm6YT83L+M2mQQrjGMDoP8c1/Dc7+TpMUpUmr40Nt mlbn2I+U+o3tobmiyeqUxKrvBpDwo5/BbADlJY7KfK+OFM6wFKVNtQkvDLf0ddsafU6+ QyZg== X-Gm-Message-State: AOJu0YyLeHWX/a8BNtBoeiR8eGnJf4PANbTunpA+yPp8JaYVfZECbcMu Ygtv9pXRNSsgKu23EzSq/PtK631o1JeJnfjntchLaUnoDMZ4uX/VLlaRkuk6EOWreZoQbcEn6KM jBWcjDQ== X-Google-Smtp-Source: AGHT+IGp6FrIvymnbIWK5lPRgPAv0lHhos1V6h914wT1UtvPcAUMKbqvHB6mzPsA2wex3tP7qHjY6w== X-Received: by 2002:a17:902:f60c:b0:20c:f648:e3a7 with SMTP id d9443c01a7336-210c6c7048cmr93762885ad.50.1730049990519; Sun, 27 Oct 2024 10:26:30 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf71d50sm37754465ad.72.2024.10.27.10.26.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 10:26:29 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson , Chengwen Feng , Dmitry Kozlyuk Subject: [PATCH v30 05/13] eal: do not duplicate rte_init_alert() messages Date: Sun, 27 Oct 2024 10:24:35 -0700 Message-ID: <20241027172616.176175-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241027172616.176175-1-stephen@networkplumber.org> References: <20200814173441.23086-1-stephen@networkplumber.org> <20241027172616.176175-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The message already goes through logging, and does not need to be printed on stderr. Message level should be ALERT to match function name. Signed-off-by: Stephen Hemminger Acked-by: Tyler Retzlaff Acked-by: Morten Brørup Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- lib/eal/freebsd/eal.c | 3 +-- lib/eal/linux/eal.c | 3 +-- lib/eal/windows/eal.c | 1 - 3 files changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index d3b40e81d8..7b974608e4 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -529,8 +529,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* Launch threads, called at application init(). */ diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index 40d750ed0d..c53a051405 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -830,8 +830,7 @@ rte_eal_iopl_init(void) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); - EAL_LOG(ERR, "%s", msg); + EAL_LOG(ALERT, "%s", msg); } /* diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c index a77e590a72..93f099a968 100644 --- a/lib/eal/windows/eal.c +++ b/lib/eal/windows/eal.c @@ -181,7 +181,6 @@ sync_func(void *arg __rte_unused) static void rte_eal_init_alert(const char *msg) { - fprintf(stderr, "EAL: FATAL: %s\n", msg); EAL_LOG(ERR, "%s", msg); } -- 2.45.2