From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F3A9145BF5; Sun, 27 Oct 2024 19:29:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9B774021E; Sun, 27 Oct 2024 19:29:14 +0100 (CET) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) by mails.dpdk.org (Postfix) with ESMTP id BA22F40151 for ; Sun, 27 Oct 2024 19:29:13 +0100 (CET) Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-7ea8ecacf16so2228190a12.1 for ; Sun, 27 Oct 2024 11:29:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730053752; x=1730658552; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2+/laNzuzSLQMqI74l6VFwLsvev8oi5gUhgYNZ+/iZA=; b=fjy9UPnmdzJrvjkJK60PjQSFk5eyO10kAzCR1CTgpaBWfHP9cF7aBEMU6RQK9uJSP6 JMeTzBbNJ0RTtHB/Blq8imddfqDs6PMABjxO4bl/UbO+qE/cAt54XK+5+QyJseBAbRFR UaesbYzOTWJJzzntzzIKH5EWjiDyK3QIrVPiXJ3zw9oXgvwkARKK0GN+qNvaa+mw3LX6 YKImPeOJv0oGSC8W+bi50cJQSG1ykO0Sb9RCHmq7DKg+DgAe+v5TpdFDfuaw27Dblow8 exSjWNynj/PmVTuf60pZ6pj4SHJevMWcwCmgLM9oeQCrjWEaOKJCq81PaX8Kmgp+mFP+ McBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730053752; x=1730658552; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2+/laNzuzSLQMqI74l6VFwLsvev8oi5gUhgYNZ+/iZA=; b=NpS5Da2xVS8SHs2joq92LYDYZGI85CaXI3wTPvLR6AExEjNRLtiq6GA/qofcRD9YdY DHa2uO0JFssoWMZJg6T0HeUS7cSMIcse3caw7q4nGQ3JwGE5624b31ysDsM42XGMxnBB uzSE/M3RdGa/fYep6wkHOxK0rK8xMWI+NtK6WpBe3rZMSv8TsAO9FknqwfmlXkcj21Ix NVyC23BZ4kuAajBm95egQczFRYnNU4Fvn9/IR9eMe1Dy4p7P/qLGwP8WRUfU9JW0j90u EbWJk2cYx75pGJmF9jejKTA+WRO38KW9cFsqR2/G9/8SMeUPHKvKE9/r35riVVLodTrW e5Xg== X-Gm-Message-State: AOJu0YwreyordesxjQfq7arUICTLLGhgtPhK0NLhBiS8qKIe9G7BiXGg G4DebzZOPl2H32xxKYcvYFPwlEnOhFvJWybaDRCqnsT7krVjNr4UGayT7VarT1L89E4ULn+ZJnd GPNQqHA== X-Google-Smtp-Source: AGHT+IFZoUXB/xzjjK+7vH5aiRbZ5RmjtHhCAARBVPVGsdoq71J7fMR5lr0JSCtV0jo2pQSlPvmvkg== X-Received: by 2002:a05:6a21:3947:b0:1d9:3456:b71e with SMTP id adf61e73a8af0-1d9a83c1926mr7701099637.12.1730053752568; Sun, 27 Oct 2024 11:29:12 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a20252sm4466560b3a.147.2024.10.27.11.29.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 11:29:12 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH] dumpcap: check return value from adding interface Date: Sun, 27 Oct 2024 11:28:48 -0700 Message-ID: <20241027182903.209391-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_pcapng_add_interface could fail. For example: running out of space for the file. Covertity issue: 446742 Signed-off-by: Stephen Hemminger --- app/dumpcap/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c index fcfaa19951..260ca72dc6 100644 --- a/app/dumpcap/main.c +++ b/app/dumpcap/main.c @@ -800,9 +800,9 @@ static dumpcap_out_t create_output(void) free(os); TAILQ_FOREACH(intf, &interfaces, next) { - rte_pcapng_add_interface(ret.pcapng, intf->port, - intf->ifname, intf->ifdescr, - intf->opts.filter); + if (rte_pcapng_add_interface(ret.pcapng, intf->port, intf->ifname, + intf->ifdescr, intf->opts.filter) < 0) + rte_exit(EXIT_FAILURE, "pcapng_add_interface %u failed\n", intf->port); } } else { pcap_t *pcap; -- 2.45.2