From: Stephen Hemminger <stephen@networkplumber.org>
To: Howard Wang <howard_wang@realsil.com.cn>
Cc: <dev@dpdk.org>, <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH v4 02/18] net/r8169: add logging structure
Date: Sun, 27 Oct 2024 19:28:49 -0700 [thread overview]
Message-ID: <20241027192849.0c1bcf3e@hermes.local> (raw)
In-Reply-To: <20241025033529.15581-3-howard_wang@realsil.com.cn>
On Fri, 25 Oct 2024 11:35:13 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:
> Implement logging macros for debug purposes.
>
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
Did you see this from checkpatch? Probably not because it was buried
in all the CamelCase warnings.
Warning in drivers/net/r8169/r8169_logs.h:
Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE
Warning in drivers/net/r8169/r8169_logs.h:
Do not use variadic argument pack in macros
next prev parent reply other threads:[~2024-10-28 2:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 3:35 [PATCH v4 00/18] Modify code as suggested by the maintainer Howard Wang
2024-10-25 3:35 ` [PATCH v4 01/18] net/r8169: add PMD driver skeleton Howard Wang
2024-10-25 3:35 ` [PATCH v4 02/18] net/r8169: add logging structure Howard Wang
2024-10-28 2:28 ` Stephen Hemminger [this message]
2024-10-25 3:35 ` [PATCH v4 03/18] net/r8169: add hardware registers access routines Howard Wang
2024-10-25 3:35 ` [PATCH v4 04/18] net/r8169: implement core logic for Tx/Rx Howard Wang
2024-10-25 3:35 ` [PATCH v4 05/18] net/r8169: add support for hw config Howard Wang
2024-10-28 2:32 ` Stephen Hemminger
2024-10-25 3:35 ` [PATCH v4 06/18] net/r8169: add phy registers access routines Howard Wang
2024-10-25 3:35 ` [PATCH v4 07/18] net/r8169: add support for hardware operations Howard Wang
2024-10-25 3:35 ` [PATCH v4 08/18] net/r8169: add support for phy configuration Howard Wang
2024-10-25 3:35 ` [PATCH v4 09/18] net/r8169: add support for hw initialization Howard Wang
2024-10-25 3:35 ` [PATCH v4 10/18] net/r8169: add link status and interrupt management Howard Wang
2024-10-25 3:35 ` [PATCH v4 11/18] net/r8169: implement Rx path Howard Wang
2024-10-25 3:35 ` [PATCH v4 12/18] net/r8169: implement Tx path Howard Wang
2024-10-25 3:35 ` [PATCH v4 13/18] net/r8169: implement device statistics Howard Wang
2024-10-25 3:35 ` [PATCH v4 14/18] net/r8169: implement promisc and allmulti modes Howard Wang
2024-10-25 3:35 ` [PATCH v4 15/18] net/r8169: implement MTU configuration Howard Wang
2024-10-25 3:35 ` [PATCH v4 16/18] net/r8169: add support for getting fw version Howard Wang
2024-10-25 3:35 ` [PATCH v4 17/18] net/r8169: add driver_start and driver_stop Howard Wang
2024-10-25 3:35 ` [PATCH v4 18/18] doc/guides/nics: add documents for r8169 pmd Howard Wang
2024-10-28 2:12 ` 答复: " 王颢
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241027192849.0c1bcf3e@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).