From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5BC145BE5; Mon, 28 Oct 2024 03:28:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7C723402F2; Mon, 28 Oct 2024 03:28:53 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 3689A402A3 for ; Mon, 28 Oct 2024 03:28:52 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-20cb7139d9dso32306635ad.1 for ; Sun, 27 Oct 2024 19:28:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730082531; x=1730687331; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3o7MaBQKOXWZYtYCYII/oICX7gLXxLFd8j8mzPE6AZ4=; b=etjywUUT9fHf7Pee7qkZ6DF3C/BO2bjm9UOaE/j2Kg7xSb59pRolDvmSwoAFTeBL4f kERADiLzDqPgsRDdqwoSrASDCpAIpVmqMlFdISFTS2dwMOwrM4werK7BcVuZOte+gp92 0ktrGJv0vbCLmmB17iagXGUazYQV3TG4Ui/tbJ7LIxZG3zYoIHezRYgZw3yV5uW4DoFi IsY0mmMlwJ+cmWUOoeOQ3/Lw+fDkOwPBHFWVzk3JKJdnwskvXMJsCPwYLhtlE7lTkwXJ xQ3Ro00IjSPYAYk5uZ6nM+Xw7XpaBAX1R1xrH/Di+jpNlnoagcnPdGTr0Xq4lIVTcRts OefA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730082531; x=1730687331; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3o7MaBQKOXWZYtYCYII/oICX7gLXxLFd8j8mzPE6AZ4=; b=DNIH+HYYbm0pATelT8JDf2yzJMgD1fjyMhYOF21MCnTK3ZvWWxVrawITX8ivmTVtkt 85N0y9UDpLlpA8OCyjqVIZRBMCC0faG57T6T586R/lVHYs5Y/yp7eSa79jjmw2TtcF+L H3tQspyLPo/pSEmAcGIygKvHlYDNy3CEgtjxhVyHUVJqmFFo8l5mg0dqnjyhib+OgzYo o+i1LJwifWmyipe8ZFcdo4GG5UkqQuvp0s4uzWKMwGNvih6l5ebxevl8jIAoVEweRpHZ IJFeUAsJHPsjOHKd86uvzqExyxsXbhoSdAS5GL/3fsXTtkU2HM9C3EthCr3kp3VbKk7D 5zYg== X-Gm-Message-State: AOJu0YxCEwr8glwBOloBRHyVUxpd/U8VnKqgiWTNIYJ55GQYAbNxAp7E cue3TnO4DhPBs1Q2cEKcIRaNpjJTpAQ9N6Naz3kIeqmUVvzaGrWQaCsgGae2EsE= X-Google-Smtp-Source: AGHT+IEFFgZMzm43z91de7ZDsekrBaUzEJw8p4hTe59ieE38yZk3LtpNz8L79ylro195Vq2gtdylFQ== X-Received: by 2002:a17:902:f791:b0:20c:7be3:2816 with SMTP id d9443c01a7336-210c6c3f1cfmr101348925ad.40.1730082531218; Sun, 27 Oct 2024 19:28:51 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf44339sm41522755ad.32.2024.10.27.19.28.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 19:28:51 -0700 (PDT) Date: Sun, 27 Oct 2024 19:28:49 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v4 02/18] net/r8169: add logging structure Message-ID: <20241027192849.0c1bcf3e@hermes.local> In-Reply-To: <20241025033529.15581-3-howard_wang@realsil.com.cn> References: <20241025033529.15581-1-howard_wang@realsil.com.cn> <20241025033529.15581-3-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 25 Oct 2024 11:35:13 +0800 Howard Wang wrote: > Implement logging macros for debug purposes. > > Signed-off-by: Howard Wang Did you see this from checkpatch? Probably not because it was buried in all the CamelCase warnings. Warning in drivers/net/r8169/r8169_logs.h: Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE Warning in drivers/net/r8169/r8169_logs.h: Do not use variadic argument pack in macros