From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8872645BE5; Mon, 28 Oct 2024 03:32:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 19D0C402F2; Mon, 28 Oct 2024 03:32:43 +0100 (CET) Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by mails.dpdk.org (Postfix) with ESMTP id 8048A402A3 for ; Mon, 28 Oct 2024 03:32:41 +0100 (CET) Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-7ea9739647bso2594439a12.0 for ; Sun, 27 Oct 2024 19:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730082760; x=1730687560; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Sx0wrp/QoQSrBoeMbWGKoplj/0WvfV/x+5lX8IJ4S6c=; b=GDOIKcr5Hc5lQOv1DCrL4WovHwvtFLI+IueFgvKYxQj4mNHQgRNsEka2cPM3XREpd4 JBXNsv0HSlEgSGsoVXAlR6PZqVFR70kImmB5tsFhuo47cpnhxE75I6zZGmchG4xWoJGH JM2Jalw+AviVI1IFGK3KAQlNY+EVL/Ycmt+TS3KgvuDMIiHRCLJpIIHB9itED+1R1lc7 zy4bJ8sNLzHhYS3C2FhDWuFGcD2P8DHI+f1oH7seUAWZkzWpT9Z3ZT5me8aOJ9wHNBt8 0eFuCJqZ09afM8Uqli+bYM8lwX4pSoMKVpGD8yMLvidwdc46M8I7KMnB8ViRY2ODtWrp vRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730082760; x=1730687560; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sx0wrp/QoQSrBoeMbWGKoplj/0WvfV/x+5lX8IJ4S6c=; b=hpy3qanakDiHmCOvr7hu3Jy05/AqDKkly7PuB6FKT1gr3K2N0QwR58ExEKzxkjCm8L QQ1rpViDJqmvQ/IagUlHJeaE1P2v1hp78rscKQGeR8AkO8IjDA40Fh6zlyeIf2sTgECD SC2k8V6jdwTc2ZugHVDnJvgxxo65FNXWL2GiFXtstMUxjHIdRo/YZR44XQBt6Eyo3XF+ hDy2GbxvSnNEiFxdJNMvY4uogkYHp/Fi2zPdygIpUskav3/DXcxWM4aWeqQ3avVaA1A1 7dCn6X3ZnCrag9sY9Ucvhl6xpnhU2n/xxUFc+eTUSA5cF6cpALWVsOAz+DXRhaKX+w1f PACQ== X-Gm-Message-State: AOJu0Yzx9XupY+VmYN0aV84tLzK3npchBsYNS5yAz6H4pfeV/RO+TJMV Vw9iNQnpTzh6MrlwA5DvRZcewD26BDIakvSlcUWprOwPd+ZYQ3ZBaLG9nn/ymCE= X-Google-Smtp-Source: AGHT+IFa2FJevLP0rY/s3Pkmg3eW9ezleMqPk1A2cbELd+FMwgpK0iHp6IUrMZZtoebIA+luNanTHg== X-Received: by 2002:a05:6a21:3a4a:b0:1d9:4837:ada1 with SMTP id adf61e73a8af0-1d9a85144a4mr11187763637.35.1730082760633; Sun, 27 Oct 2024 19:32:40 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc0828d2sm41396465ad.286.2024.10.27.19.32.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Oct 2024 19:32:40 -0700 (PDT) Date: Sun, 27 Oct 2024 19:32:38 -0700 From: Stephen Hemminger To: Howard Wang Cc: , Subject: Re: [PATCH v4 05/18] net/r8169: add support for hw config Message-ID: <20241027193238.44807969@hermes.local> In-Reply-To: <20241025033529.15581-6-howard_wang@realsil.com.cn> References: <20241025033529.15581-1-howard_wang@realsil.com.cn> <20241025033529.15581-6-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 25 Oct 2024 11:35:16 +0800 Howard Wang wrote: > Implement the rtl_hw_config function to configure the hardware. > > Signed-off-by: Howard Wang If you send a new version, this should be fixed. ### [PATCH] net/r8169: add support for hw config WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #976: FILE: drivers/net/r8169/r8169_phy.c:2: + * Copyright(c) 2024 Realtek Corporation. All rights reserved */