From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8014445BFE; Mon, 28 Oct 2024 12:01:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 861C940EAB; Mon, 28 Oct 2024 12:01:54 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 04FB440E4B for ; Mon, 28 Oct 2024 12:01:39 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 49SA1TiB012711; Mon, 28 Oct 2024 04:01:37 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=r +8OtJssdIEyqKrJIYgCvHeXOFA2z433JGYSZZpiCc0=; b=Q0y3D84F3VGhwJmv/ begnrWopdrDn0tBrgA9o4mt3sEOKZjHQXFVSLGZ2CZJOZAMYUIQX88sb3RPj8/aF ZC1F/+3RdWnGskJbNushLQz4SWu9ZDU0RKYsET3lnBcjBrUoygAVsVaZOL0fddNp mxBwOhoWAmJojfJ4JiKxcvUc3aIDK5+kWqs7Zd08YrVVLXZmNL/0nmfTpL0HYMci wf4TEJdlwCR3Az5vnOUe45uD5Ceb04JH7hRhpGIfBUOrerO4LB9W2EBJi9TOzqQa BmV4H3Zpf+MQmTD+iab6NtqT73wdCIpmAjhmvAPUKmLVAeVEeMwlVjPEYQPfKRwW PfvQA== Received: from dc5-exch05.marvell.com ([199.233.59.128]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 42gyxf379f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Oct 2024 04:01:36 -0700 (PDT) Received: from DC5-EXCH05.marvell.com (10.69.176.209) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 28 Oct 2024 04:01:35 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH05.marvell.com (10.69.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Mon, 28 Oct 2024 04:01:35 -0700 Received: from localhost.localdomain (unknown [10.28.36.102]) by maili.marvell.com (Postfix) with ESMTP id 5E9915C68E6; Mon, 28 Oct 2024 04:01:32 -0700 (PDT) From: Akhil Goyal To: CC: , , , , , , , , Akhil Goyal Subject: [PATCH v6 4/9] raw/cnxk_rvu_lf: support msg handler registration Date: Mon, 28 Oct 2024 16:31:10 +0530 Message-ID: <20241028110115.1070655-5-gakhil@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241028110115.1070655-1-gakhil@marvell.com> References: <20241024131759.3337333-1-gakhil@marvell.com> <20241028110115.1070655-1-gakhil@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: oYYujw07vJPHOIM4TajzE6Tqlp78Qh16 X-Proofpoint-GUID: oYYujw07vJPHOIM4TajzE6Tqlp78Qh16 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Added APIs rte_pmd_rvu_lf_msg_handler_register() and rte_pmd_rvu_lf_msg_handler_unregister() to register/unregister mailbox message handlers. These handlers are needed to fill response at the other side for the request sent from one side. Signed-off-by: Akhil Goyal --- doc/guides/rawdevs/cnxk_rvu_lf.rst | 10 ++++ drivers/common/cnxk/roc_dev_priv.h | 6 +++ drivers/common/cnxk/roc_rvu_lf.c | 25 ++++++++++ drivers/common/cnxk/roc_rvu_lf.h | 7 +++ drivers/common/cnxk/version.map | 2 + drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c | 28 +++++++++++ drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_driver.h | 49 ++++++++++++++++++++ drivers/raw/cnxk_rvu_lf/version.map | 2 + 8 files changed, 129 insertions(+) diff --git a/doc/guides/rawdevs/cnxk_rvu_lf.rst b/doc/guides/rawdevs/cnxk_rvu_lf.rst index 4a0ce5654b..3c1856fc6e 100644 --- a/doc/guides/rawdevs/cnxk_rvu_lf.rst +++ b/doc/guides/rawdevs/cnxk_rvu_lf.rst @@ -18,6 +18,7 @@ The RVU LF device implements following features in the rawdev API: - Get PF FUNC of associated NPA and SSO devices. - Register/unregister interrupt handlers. +- Register/unregister mailbox callbacks for the other side to process mailboxes. Limitations ----------- @@ -51,3 +52,12 @@ Out of tree drivers can register interrupt handlers using ``rte_pmd_rvu_lf_irq_r or remove interrupt handler using ``rte_pmd_rvu_lf_irq_unregister()``. The irq numbers for which the interrupts are registered is negotiated separately and is not in scope of the driver. + +RVU LF RAW MESSAGE PROCESSING +----------------------------- + +For processing of mailboxes received on RVU PF/VF application, out of tree +drivers can register/unregister callbacks using ``rte_pmd_rvu_lf_msg_handler_register()`` +and ``rte_pmd_rvu_lf_msg_handler_unregister()``. +Required responses as per the request and message id received can be filled +in the callbacks. diff --git a/drivers/common/cnxk/roc_dev_priv.h b/drivers/common/cnxk/roc_dev_priv.h index dd4949b32c..c766183196 100644 --- a/drivers/common/cnxk/roc_dev_priv.h +++ b/drivers/common/cnxk/roc_dev_priv.h @@ -46,11 +46,17 @@ typedef void (*link_status_get_t)(void *roc_nix, /* Representee notification callback */ typedef int (*repte_notify_t)(void *roc_nix, void *notify_msg); +/* RVU Message process callback */ +typedef int (*msg_process_cb_t)(uint16_t vf, uint16_t msg_id, + void *req, uint16_t req_len, + void **rsp, uint16_t *rsp_len); + struct dev_ops { link_info_t link_status_update; ptp_info_t ptp_info_update; link_status_get_t link_status_get; q_err_cb_t q_err_cb; + msg_process_cb_t msg_process_cb; repte_notify_t repte_notify; }; diff --git a/drivers/common/cnxk/roc_rvu_lf.c b/drivers/common/cnxk/roc_rvu_lf.c index 63bc149f2a..2e1be81e52 100644 --- a/drivers/common/cnxk/roc_rvu_lf.c +++ b/drivers/common/cnxk/roc_rvu_lf.c @@ -87,3 +87,28 @@ roc_rvu_lf_irq_unregister(struct roc_rvu_lf *roc_rvu_lf, unsigned int irq, return 0; } + +int +roc_rvu_lf_msg_handler_register(struct roc_rvu_lf *roc_rvu_lf, roc_rvu_lf_msg_handler_cb_fn cb) +{ + struct rvu_lf *rvu = roc_rvu_lf_to_rvu_priv(roc_rvu_lf); + struct dev *dev = &rvu->dev; + + if (cb == NULL) + return -EINVAL; + + dev->ops->msg_process_cb = (msg_process_cb_t)cb; + + return 0; +} + +int +roc_rvu_lf_msg_handler_unregister(struct roc_rvu_lf *roc_rvu_lf) +{ + struct rvu_lf *rvu = roc_rvu_lf_to_rvu_priv(roc_rvu_lf); + struct dev *dev = &rvu->dev; + + dev->ops->msg_process_cb = NULL; + + return 0; +} diff --git a/drivers/common/cnxk/roc_rvu_lf.h b/drivers/common/cnxk/roc_rvu_lf.h index 800bf4e674..90a0b5690a 100644 --- a/drivers/common/cnxk/roc_rvu_lf.h +++ b/drivers/common/cnxk/roc_rvu_lf.h @@ -22,8 +22,15 @@ int __roc_api roc_rvu_lf_dev_init(struct roc_rvu_lf *roc_rvu_lf); int __roc_api roc_rvu_lf_dev_fini(struct roc_rvu_lf *roc_rvu_lf); typedef void (*roc_rvu_lf_intr_cb_fn)(void *cb_arg); +typedef int (*roc_rvu_lf_msg_handler_cb_fn)(uint16_t vf, uint16_t msg_id, + void *req, uint16_t req_len, + void **rsp, uint16_t *rsp_len); + int __roc_api roc_rvu_lf_irq_register(struct roc_rvu_lf *roc_rvu_lf, unsigned int irq, roc_rvu_lf_intr_cb_fn cb, void *cb_arg); int __roc_api roc_rvu_lf_irq_unregister(struct roc_rvu_lf *roc_rvu_lf, unsigned int irq, roc_rvu_lf_intr_cb_fn cb, void *cb_arg); +int __roc_api roc_rvu_lf_msg_handler_register(struct roc_rvu_lf *roc_rvu_lf, + roc_rvu_lf_msg_handler_cb_fn cb); +int __roc_api roc_rvu_lf_msg_handler_unregister(struct roc_rvu_lf *roc_rvu_lf); #endif /* _ROC_RVU_LF_H_ */ diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map index 174a953f6f..bc37f9ecd2 100644 --- a/drivers/common/cnxk/version.map +++ b/drivers/common/cnxk/version.map @@ -554,5 +554,7 @@ INTERNAL { roc_rvu_lf_dev_init; roc_rvu_lf_irq_register; roc_rvu_lf_irq_unregister; + roc_rvu_lf_msg_handler_register; + roc_rvu_lf_msg_handler_unregister; local: *; }; diff --git a/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c b/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c index c108931f97..29ab738392 100644 --- a/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c +++ b/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf.c @@ -16,6 +16,34 @@ #include "cnxk_rvu_lf.h" #include "cnxk_rvu_lf_driver.h" +int +rte_pmd_rvu_lf_msg_handler_register(uint8_t dev_id, rte_pmd_rvu_lf_msg_handler_cb_fn cb) +{ + struct rte_rawdev *rawdev = rte_rawdev_pmd_get_dev(dev_id); + struct roc_rvu_lf *roc_rvu_lf; + + if (rawdev == NULL) + return -EINVAL; + + roc_rvu_lf = (struct roc_rvu_lf *)rawdev->dev_private; + + return roc_rvu_lf_msg_handler_register(roc_rvu_lf, (roc_rvu_lf_msg_handler_cb_fn)cb); +} + +int +rte_pmd_rvu_lf_msg_handler_unregister(uint8_t dev_id) +{ + struct rte_rawdev *rawdev = rte_rawdev_pmd_get_dev(dev_id); + struct roc_rvu_lf *roc_rvu_lf; + + if (rawdev == NULL) + return -EINVAL; + + roc_rvu_lf = (struct roc_rvu_lf *)rawdev->dev_private; + + return roc_rvu_lf_msg_handler_unregister(roc_rvu_lf); +} + int rte_pmd_rvu_lf_irq_register(uint8_t dev_id, unsigned int irq, rte_pmd_rvu_lf_intr_callback_fn cb, void *data) diff --git a/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_driver.h b/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_driver.h index b315b2c61e..15320e55ba 100644 --- a/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_driver.h +++ b/drivers/raw/cnxk_rvu_lf/cnxk_rvu_lf_driver.h @@ -88,6 +88,55 @@ __rte_internal int rte_pmd_rvu_lf_irq_unregister(uint8_t dev_id, unsigned int irq, rte_pmd_rvu_lf_intr_callback_fn cb, void *cb_arg); +/** + * Signature of callback function called when a message process handler is called + * on RVU LF device. + * + * @param vf + * VF number(0 to N) from which message is received (ignored in case of PF) + * @param msg_id + * message id + * @param req + * pointer to message request + * @param req_len + * pointer to message request + * @param[out] rsp + * pointer to message response + * @param[out] rsp_len + * length of message response + * + * @return 0 when response is set, negative value otherwise + */ +typedef int (*rte_pmd_rvu_lf_msg_handler_cb_fn)(uint16_t vf, uint16_t msg_id, + void *req, uint16_t req_len, + void **rsp, uint16_t *rsp_len); + +/** + * Register message handler callback + * + * Registers message handler callback to be executed when the message is received from peer. + * + * @param dev_id + * device id of RVU LF device + * @param cb + * callback function to be executed + * + * @return 0 on success, negative value otherwise + */ +__rte_internal +int rte_pmd_rvu_lf_msg_handler_register(uint8_t dev_id, rte_pmd_rvu_lf_msg_handler_cb_fn cb); + +/** + * Unregister message handler callback + * + * @param dev_id + * device id of RVU LF device + * + * @return 0 on success, negative value otherwise + */ +__rte_internal +int rte_pmd_rvu_lf_msg_handler_unregister(uint8_t dev_id); + #ifdef __cplusplus } #endif diff --git a/drivers/raw/cnxk_rvu_lf/version.map b/drivers/raw/cnxk_rvu_lf/version.map index a2e8a2c9b3..fcbb2545ea 100644 --- a/drivers/raw/cnxk_rvu_lf/version.map +++ b/drivers/raw/cnxk_rvu_lf/version.map @@ -3,6 +3,8 @@ INTERNAL { rte_pmd_rvu_lf_irq_register; rte_pmd_rvu_lf_irq_unregister; + rte_pmd_rvu_lf_msg_handler_register; + rte_pmd_rvu_lf_msg_handler_unregister; rte_pmd_rvu_lf_npa_pf_func_get; rte_pmd_rvu_lf_sso_pf_func_get; -- 2.25.1