From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Wathsala Vithanage <wathsala.vithanage@arm.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Robin Jarry <rjarry@redhat.com>
Subject: [PATCH] config/arm: fix warning for native build with meson >= 0.55
Date: Mon, 28 Oct 2024 14:10:47 +0100 [thread overview]
Message-ID: <20241028131047.3036831-1-david.marchand@redhat.com> (raw)
Caught in UNH logs for native compilation on ARM:
Program /...../dpdk/config/arm/armv8_machine.py found: YES
(/...../dpdk/config/arm/armv8_machine.py)
WARNING: Project targeting '>= 0.57' but tried to use feature deprecated
since '0.55.0': ExternalProgram.path. use ExternalProgram.full_path()
instead
There is nothing to search, nor a reason to call the script with an
absolute path.
The script can be directly pointed at with files().
Fixes: 200b88cbe0e6 ("build: detect micro-arch on ARM")
Fixes: 6f3dbd306de0 ("build: increase minimum meson version to 0.57")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
config/arm/meson.build | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/config/arm/meson.build b/config/arm/meson.build
index 55be7c8711..95500c8ed3 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -784,9 +784,8 @@ else
# native build
# The script returns ['Implementer', 'Variant', 'Architecture',
# 'Primary Part number', 'Revision']
- detect_vendor = find_program(join_paths(meson.current_source_dir(),
- 'armv8_machine.py'))
- cmd = run_command(detect_vendor.path(), check: false)
+ detect_vendor = py3 + files('armv8_machine.py')
+ cmd = run_command(detect_vendor, check: false)
if cmd.returncode() == 0
cmd_output = cmd.stdout().to_lower().strip().split(' ')
implementer_id = cmd_output[0]
--
2.46.2
next reply other threads:[~2024-10-28 13:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-28 13:10 David Marchand [this message]
2024-10-28 13:12 ` Robin Jarry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028131047.3036831-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=fengchengwen@huawei.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@marvell.com \
--cc=rjarry@redhat.com \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).