DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Lewis Donzis <lew@perftech.com>
Cc: dev <dev@dpdk.org>, "Anatoly Burakov" <anatoly.burakov@intel.com>,
	"Stephen Hemminger" <stephen@networkplumber.org>,
	"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump
Date: Mon, 28 Oct 2024 16:26:06 +0300	[thread overview]
Message-ID: <20241028162606.48381738@sovereign> (raw)
In-Reply-To: <1865717992.9940628.1729942988633.JavaMail.zimbra@donzis.com>

2024-10-26 06:43 (UTC-0500), Lewis Donzis:
> Is the extra control necessary, i.e., why not just always do this and let
> the EAL option control whether the pages get dumped?

I've been evaluating your suggestion and see no downsides,
except contigmem default behavior change, but does it have non-DPDK users?
If no one objects, I'll prepare v3 doing the following:
1) everything from v2,
2) except always mark contigmem buffers as dumpable,
3) add --dump-mapped back and make DPDK disable dumping by default.
As a result, in order to include mapped memory in coredump:
* FreeBSD will require only "--dump-mapped";
* Linux will require both "coredump_filter" setup and "--dump-mapped".

  reply	other threads:[~2024-10-28 13:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 23:18 [PATCH] eal: support including mapped memory " Dmitry Kozlyuk
2024-10-24  2:19 ` Stephen Hemminger
2024-10-24  2:31 ` Stephen Hemminger
2024-10-24  7:07   ` Morten Brørup
2024-10-24  7:22 ` Morten Brørup
2024-10-24  8:25   ` Dmitry Kozlyuk
2024-10-24 12:55 ` Lewis Donzis
2024-10-24 16:38 ` Stephen Hemminger
2024-10-24 20:54   ` Dmitry Kozlyuk
2024-10-25  0:22     ` Dmitry Kozlyuk
2024-10-25 20:26 ` [PATCH v2 0/2] Hugepage inclusion " Dmitry Kozlyuk
2024-10-25 20:26   ` [PATCH v2 1/2] contigmem: support including mapped buffers " Dmitry Kozlyuk
2024-10-26 11:43     ` Lewis Donzis
2024-10-28 13:26       ` Dmitry Kozlyuk [this message]
2024-10-28 13:35         ` Lewis Donzis
2024-10-25 20:26   ` [PATCH v2 2/2] doc: add instruction for including hugepages " Dmitry Kozlyuk
2024-10-26  3:18   ` [PATCH v2 0/2] Hugepage inclusion " Morten Brørup

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028162606.48381738@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=lew@perftech.com \
    --cc=mb@smartsharesystems.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).