From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC96345BB1; Mon, 28 Oct 2024 14:26:10 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9DD740E1B; Mon, 28 Oct 2024 14:26:10 +0100 (CET) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id EE640400D7 for ; Mon, 28 Oct 2024 14:26:09 +0100 (CET) Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-53b13ea6b78so6604385e87.2 for ; Mon, 28 Oct 2024 06:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730121969; x=1730726769; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=xJTlQQSlgakKNGd+fCq+qKNMvOugwrcyiASN8Ri+Tbc=; b=MjFIdYGiSqatWjtX8FP6dnX+uJpA3R+4rGOUSMPrFM/L76x/ITEJrNfUOYYCVW6fKT 1ygdDMvuRb8DvcfIZ3M0Q9pZX1BKcWK58ETERCaIGHWqMPZE1KQR7lM2e2+uHhDQ0agM 5UvSFMLhizGgZeHp5fd6pB/0QeJ2hnHbI1kUGZ+HAXL45HzyYSRMvXGx+M3c+Sc/2FHB l6jbyGL6azFmlm4u3kQMQOpM9xuzoCbXqEjYBUKF091V+6nxRIdY5OtGaLTs9QOHDWMg cg6hsFMmZUNSURcHWdiWtk+A22YCdV/9vaqY5PTWGbBWRNn8YNRBqUSv29uAX4IV3Yug l8Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730121969; x=1730726769; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xJTlQQSlgakKNGd+fCq+qKNMvOugwrcyiASN8Ri+Tbc=; b=InZgpSQM5indNCYRwZb+81eV/rJmNJdjfg7snVhqRP7surTvk57RC87sKhhe43WoB2 lJwhiO3fpvANK5fNHT6mIR4+y+Kji0G0Db8PYUrcA6c2wC0hx+h4YPK/vrfb1ocihBQR 7mtKCQ7ZCSJriAlBIXOvSsoD/yMEyKkYcyB5EEMPCzyy4HwUsxbHh9YrtporReEhnzRK +bsJaK2knU540eLxfizO90F0FjdGo7EQyr8esaUN1gRiH/vS6I6bTTWuvOajySoRfwIi 5TZXyzlj8V/Y6l9NCb2j/dwzACjItnCiDmO7lNeVhNO2Ef2s+jz5hCLfhfKkt+C6lZjI a81w== X-Gm-Message-State: AOJu0YwTVxtEI711NpkJcyFkVpiEJgjDs4mZ5vfQRPaNtP0QXO3VJcPS Qqo+ApHkz200DqptGDLEPzlP6G/ti0OWBm3jdSOIDaFyPByAXulp X-Google-Smtp-Source: AGHT+IH0naNyrTjLagoTGMspzU12Visb2xDFK8yLc9k7oNRkWwVvPKtLBAPG4k4QqsasFhMmUdXHwQ== X-Received: by 2002:a05:6512:33cf:b0:533:c9d:a01f with SMTP id 2adb3069b0e04-53b348ba0bemr4936442e87.4.1730121968872; Mon, 28 Oct 2024 06:26:08 -0700 (PDT) Received: from sovereign (broadband-109-173-43-194.ip.moscow.rt.ru. [109.173.43.194]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-53b2e10a4b2sm1057806e87.52.2024.10.28.06.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 06:26:08 -0700 (PDT) Date: Mon, 28 Oct 2024 16:26:06 +0300 From: Dmitry Kozlyuk To: Lewis Donzis Cc: dev , Anatoly Burakov , Stephen Hemminger , Morten =?UTF-8?B?QnLDuHJ1cA==?= Subject: Re: [PATCH v2 1/2] contigmem: support including mapped buffers in core dump Message-ID: <20241028162606.48381738@sovereign> In-Reply-To: <1865717992.9940628.1729942988633.JavaMail.zimbra@donzis.com> References: <20241023231859.1323727-1-kozlyuk@bifit.com> <20241025202615.2581513-1-dmitry.kozliuk@gmail.com> <20241025202615.2581513-2-dmitry.kozliuk@gmail.com> <1865717992.9940628.1729942988633.JavaMail.zimbra@donzis.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2024-10-26 06:43 (UTC-0500), Lewis Donzis: > Is the extra control necessary, i.e., why not just always do this and let > the EAL option control whether the pages get dumped? I've been evaluating your suggestion and see no downsides, except contigmem default behavior change, but does it have non-DPDK users? If no one objects, I'll prepare v3 doing the following: 1) everything from v2, 2) except always mark contigmem buffers as dumpable, 3) add --dump-mapped back and make DPDK disable dumping by default. As a result, in order to include mapped memory in coredump: * FreeBSD will require only "--dump-mapped"; * Linux will require both "coredump_filter" setup and "--dump-mapped".