From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA33B45BFE; Mon, 28 Oct 2024 17:33:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E02EF42797; Mon, 28 Oct 2024 17:33:38 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id AD9A741060 for ; Mon, 28 Oct 2024 17:33:36 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-20cdb889222so42176755ad.3 for ; Mon, 28 Oct 2024 09:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730133216; x=1730738016; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bjUc46z0duVbhORRSy9Ld/m8jllv4d3txApi7p8d4jA=; b=VuMutFQy//n9jKdJvnJoegWdmiAo2/wFOicxLvjAQqXrifU7yWHgTHvk3Zh9/MbJ5D ji5TRr2uq7bwGj4YuKwrKRYKIMPK2ri1/Zd8Ex4ovXE7nQ7Njh25gY4eQ2fkW9O6olqN LErEjV2Ncht7rfeqD82X/JHc5PqMrACCmDtDV4ZZ+1GLbF6oxncI0qKnERkAmcR77vZu qt5Y+17azXUGZ2um1+kOpA3vf5ccGpYvKquCjN/8ZFoJK27KfohzpzBCTQ6BnSYDH4xC NCq9DfWrj6O3SI0CrSGSLZzCiK2Z5RlPNqOoCxl/EgxZIh/MgNtLKCNcsDp110/QtFih hj/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730133216; x=1730738016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bjUc46z0duVbhORRSy9Ld/m8jllv4d3txApi7p8d4jA=; b=tI3MvCg2J+D+M6OsXoecpH7/kYmcJInTSRcjfdHwr7PovmWC5bqKO2pkTo2XU5Iw3k 6vVp+pitBZVc4+V9ISFP1gma21V84144kZgFIFI73ULWodslQAugLk3wkXM+U3TIg0N5 vweUYMo/RpAlrKeYIJZo62BMAilhO6pcePzJZ15R0bkxGbB7w8tp+2QZa/Ixg/yNxjwp bzy7E2l+xHXeKoFEcjW4a7M8e8G5FqCFqQehyNOyhZySD5JrwRu0Z/3ix6lEyb/goIFB M7TR/fwgPM2xwjwNqlZLJaQMy5UQbRl6OPWe5BvAb9RmPckTkcMpauTThcZ+23bpd28T M2/A== X-Gm-Message-State: AOJu0YwgJQm20+2UFGO6y4lxFhSf8UQ5L9gGiacFYw7rMwOPnVipsp/U V612lcyisyN+kz9WKBP/CvTYD/WimcfOdGrnZ654YxMfE2DO9LNChW37RmUlPWd+niSfaFNer43 D X-Google-Smtp-Source: AGHT+IFSM48fAFxJ90rxYcAE4Lp9vUHIopmAj8MXxKnKSW+OCTCb4ncqIvuoMcE51A5suxXF+9XSuQ== X-Received: by 2002:a17:903:90c:b0:20c:9821:69af with SMTP id d9443c01a7336-210c6c90a40mr135194405ad.45.1730133215726; Mon, 28 Oct 2024 09:33:35 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf43460sm52709895ad.23.2024.10.28.09.33.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2024 09:33:35 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 1/4] net/tap: replace rte_memcpy Date: Mon, 28 Oct 2024 09:32:09 -0700 Message-ID: <20241028163324.193338-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241028163324.193338-1-stephen@networkplumber.org> References: <20241028163324.193338-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There is no point in using rte_memcpy to copy Ethernet addresses. Use rte_ether_addr_copy() instead. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 36b06b3ac5..da45610665 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -15,7 +15,6 @@ #include #include #include -#include #include #include #include @@ -1395,11 +1394,13 @@ tap_mac_set(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr) mac_addr)) mode = LOCAL_AND_REMOTE; ifr.ifr_hwaddr.sa_family = AF_LOCAL; - rte_memcpy(ifr.ifr_hwaddr.sa_data, mac_addr, RTE_ETHER_ADDR_LEN); + + rte_ether_addr_copy(mac_addr, (struct rte_ether_addr *)&ifr.ifr_hwaddr.sa_data); ret = tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 1, mode); if (ret < 0) return ret; - rte_memcpy(&pmd->eth_addr, mac_addr, RTE_ETHER_ADDR_LEN); + + rte_ether_addr_copy(mac_addr, &pmd->eth_addr); #ifdef HAVE_TCA_FLOWER if (pmd->remote_if_index && !pmd->flow_isolate) { @@ -1987,7 +1988,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, if (rte_is_zero_ether_addr(mac_addr)) rte_eth_random_addr((uint8_t *)&pmd->eth_addr); else - rte_memcpy(&pmd->eth_addr, mac_addr, sizeof(*mac_addr)); + rte_ether_addr_copy(mac_addr, &pmd->eth_addr); } /* @@ -2010,8 +2011,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, if (pmd->type == ETH_TUNTAP_TYPE_TAP) { memset(&ifr, 0, sizeof(struct ifreq)); ifr.ifr_hwaddr.sa_family = AF_LOCAL; - rte_memcpy(ifr.ifr_hwaddr.sa_data, &pmd->eth_addr, - RTE_ETHER_ADDR_LEN); + rte_ether_addr_copy(&pmd->eth_addr, (struct rte_ether_addr *)&ifr.ifr_hwaddr.sa_data); if (tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 0, LOCAL_ONLY) < 0) goto error_exit; } @@ -2070,8 +2070,8 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, const char *tap_name, pmd->name, pmd->remote_iface); goto error_remote; } - rte_memcpy(&pmd->eth_addr, ifr.ifr_hwaddr.sa_data, - RTE_ETHER_ADDR_LEN); + + rte_ether_addr_copy((struct rte_ether_addr *)&ifr.ifr_hwaddr.sa_data, &pmd->eth_addr); /* The desired MAC is already in ifreq after SIOCGIFHWADDR. */ if (tap_ioctl(pmd, SIOCSIFHWADDR, &ifr, 0, LOCAL_ONLY) < 0) { TAP_LOG(ERR, "%s: failed to get %s MAC address.", -- 2.45.2