From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C3A145BC0; Tue, 29 Oct 2024 17:20:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF0C042EA9; Tue, 29 Oct 2024 17:20:43 +0100 (CET) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id CC22C42E48 for ; Tue, 29 Oct 2024 17:20:42 +0100 (CET) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-71e681bc315so4349b3a.0 for ; Tue, 29 Oct 2024 09:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730218842; x=1730823642; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RXo0s4bnwM659WZ25GFEIl3Waf+htoZLsGXOI+WewVE=; b=WyQb0gtipgZTBo3oD0RcfN3nK63ovjq6Zcy0QbNHLYZ9hbXo67vwqMoH7VvwQ8IBwo fPgwEGp7Rjqfh1/chEDQvj1NypQauKq64r8QTbHiwIjk2MyvZPCmaiM6+od8D8IR1rJE AzC+goue+ze9lfbbBJX2dJdNAhMoreFJsRsTOKPuIEelRGkZHnzyfPTSyd65ij9dZUWC rHuNQArhSktuTNKfWzrEZJe+BLLmY+9KUuYDFcbM/MR6w+e4fEmWrVYXJ1gc17WqKmPW /XwKpg9kOZZn+t+68rdnPub9LCVZMMfUYmQmvH6Q5EYY4j7d2iH2JiQ5EbxiaON6TRNm Gsgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730218842; x=1730823642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RXo0s4bnwM659WZ25GFEIl3Waf+htoZLsGXOI+WewVE=; b=HBj+zWBiulu5q1R26YKbvebdgwVZssofw0oSORlaclxl4k7f38zWEXhTVcz1RnniCk pxGp6stGe03OqStPeH7frA+6uX5rZuhRLz/Rq1FpsIa/y/2rmVgoGF+/OZUy5OZSzjQP osKt1VFb3gPpvjO/p611WXzPdQP+j9V+g+ZTBoXK3m1sL/DGkm/DPVoRvGhE8/u0XgoJ eLL07mY7nRjm5N6ySWsNzRTZKoVRjN/VmWfRuNrXTzFoU19xCHCh3LryPbFUdaKpVKCB gGlg2r5LS6oL6OABXsTjXENIPuOD4Exf76yRXDlLUmAZlvfXEzwwCBx3MllT2m0fovL9 Qzug== X-Forwarded-Encrypted: i=1; AJvYcCVzQ+Eq+Px2jRUK6ZRKzS5dNt6Oi2YhnYxTSwEux0/iXuCS9okQN8jmW2eMdUhVj4rAJzU=@dpdk.org X-Gm-Message-State: AOJu0YzEksiDW2g8Q7LERNayupYapiQvjsMV86wTKwYQiW/aZNg/+9TE Z763p/jMKHxp6X/ZAm6PhrtAnVZOT7rx1mEq8RzYeULUszGn2itx+R+eAjpleoVX4SI+zJH0/tw h0M8= X-Google-Smtp-Source: AGHT+IEW+0XZTxfbk+lyvn+lNZ5dGAq49YWE520HD/ARlmQUUln7Ofp2FqMfEMFAXh4hfpLEUhGhgQ== X-Received: by 2002:a05:6a00:139e:b0:71e:52f0:1c28 with SMTP id d2e1a72fcca58-72096367d96mr4250679b3a.0.1730218841654; Tue, 29 Oct 2024 09:20:41 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057931942sm7741278b3a.65.2024.10.29.09.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 09:20:41 -0700 (PDT) Date: Tue, 29 Oct 2024 09:20:39 -0700 From: Stephen Hemminger To: "Minggang Li(Gavin)" Cc: , , , , Dariusz Sosnowski , Bing Zhao , Suanming Mou , , , Rongwei Liu Subject: Re: [PATCH V3 3/7] net/mlx5: add new devargs to control probe optimization Message-ID: <20241029092039.7dcc5525@hermes.local> In-Reply-To: <20241029134256.874767-4-gavinl@nvidia.com> References: <20241028091822.860660-8-gavinl@nvidia.com> <20241029134256.874767-1-gavinl@nvidia.com> <20241029134256.874767-4-gavinl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 29 Oct 2024 15:42:52 +0200 "Minggang Li(Gavin)" wrote: > From: Rongwei Liu > > Add a new devarg probe_opt_en to control probe optimization > in PMD. > > By default, the value is 0 and no behavior changed. > > Signed-off-by: Rongwei Liu > Acked-by: Viacheslav Ovsiienko Once again, every option you introduce expands the test space by 2X. "Do or Do not. There is no try" Either it works all the time or it is a bad idea. Sorry if I sound like a broken record, the project I used to work on had the same kind of "always add an option" policy. But every time an option was changed, there was a 50/50 chance that it was broken because that combination of options had not been tested since originally added and was non functional due to bit rot.