From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96A1945BC0; Tue, 29 Oct 2024 18:36:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 741BD42EA0; Tue, 29 Oct 2024 18:36:13 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id C52C140267 for ; Tue, 29 Oct 2024 18:36:11 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-208cf673b8dso54398405ad.3 for ; Tue, 29 Oct 2024 10:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730223371; x=1730828171; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=CKL8EamJ1PIodXCRHiv3Uw4gPxE/xvgwHk8zAIjXJrk=; b=k9CXEbrMxaIauj18n0TdKGAE3bbWhLV7EysY+eQR1OhvLyR4HQrS+dFZxlaQcvimHD pLtBMEFxJStC/XiFZIa8DDy6puhLfS9SZDYjARvRZhDG/86BRg8ippoRqgnAiZG5FAnD UFLk1D0DFBITQTg/+qECqhzPMt1G4FXQDmzD7aVHArwOg4bKIiS166t9pfT9DIkrk0Qs A+oax9OoDTsV0P/5c7SADiv6P+gKsT/tMLPmAWUCssKRvgj9sL/8v28q/p/3gWj01PYb 8VXlUTxF0h+IEtJMoLDE7cvvyVTPpFVrSBIiruSe3nYQgUYjAxW5IiAR6lXdIetzHfbL mghQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730223371; x=1730828171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CKL8EamJ1PIodXCRHiv3Uw4gPxE/xvgwHk8zAIjXJrk=; b=C/bxR2BaW9Ps0Aa/peZ27I/j7H9UBo0Ik4raIv3rcxNzHm3Vtx3MGJ9S4fNJJ3IF66 j0IpF19iBHpOnfrrxcVzUX5nd39oVXDr+Kaw9S4i+C21GlFDO8T2aARNaEHhbLRLU9FH e76WLL4E95T6UGiPoCF4wvr5aRvSd2cf82EvrMqDcc3c37vzD4xR85quCqmLbnZhp3aY ZncXJc59FMktqXGayqcsHALej5VGqGiSo7nOp7y3jp4mWIO+TDDPX0jd/JLvaH121jGD iJh0rzLO65LTLTtNGZnklMwDZhyymO49k9MLCQ+Ve8VdFltp3/2212eAzI+2wk8uLwuO AfZw== X-Forwarded-Encrypted: i=1; AJvYcCWUWD9D74MAMIlBclNGlVts5sBUrGPD8KrdteczNEwUo1opKCiKTSChqc/c7J83Ivws4Qo=@dpdk.org X-Gm-Message-State: AOJu0Yw6eXearcbJ5lQYFARr/lZYGSvOWgdyftI1RbaJPJpFGqUjlegU XBdfak7NsZiH6zitCtJNJwuA2Gq6VjLTs/hfTCdz0DTJ3o/g+7dsEm4BVuGItI8= X-Google-Smtp-Source: AGHT+IGZi6w6aLGn9u7v9vNQRyE5T/dBY+V4xZc/+dtAh9it/kMgHp7oLKuiZF5YtLpxM/MntVw4Ig== X-Received: by 2002:a17:903:230e:b0:20c:bf43:938e with SMTP id d9443c01a7336-210c68d3ee4mr190411685ad.15.1730223370945; Tue, 29 Oct 2024 10:36:10 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc04ae0esm68185865ad.271.2024.10.29.10.36.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2024 10:36:10 -0700 (PDT) Date: Tue, 29 Oct 2024 10:36:09 -0700 From: Stephen Hemminger To: Lukas Sismis Cc: chas3@att.com, dev@dpdk.org Subject: Re: [PATCH] net/bonding: make bonding functions stable Message-ID: <20241029103609.2d668596@hermes.local> In-Reply-To: <20241029154113.310040-1-sismis@cesnet.cz> References: <20241029154113.310040-1-sismis@cesnet.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 29 Oct 2024 16:41:13 +0100 Lukas Sismis wrote: > diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map > index a309469b1f..68b892d1e6 100644 > --- a/drivers/net/bonding/version.map > +++ b/drivers/net/bonding/version.map > @@ -26,13 +26,3 @@ DPDK_25 { > > local: *; > }; > - > -EXPERIMENTAL { > - # added in 23.11 > - global: > - rte_eth_bond_8023ad_member_info; > - rte_eth_bond_active_members_get; > - rte_eth_bond_member_add; > - rte_eth_bond_member_remove; > - rte_eth_bond_members_get; > -}; > -- The build of this patch fails. Need to add these functions into the DPDK_25 section. The list there needs to stay alphabetical. Something like: diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map index a309469b1f..eb37dadf76 100644 --- a/drivers/net/bonding/version.map +++ b/drivers/net/bonding/version.map @@ -11,12 +11,17 @@ DPDK_25 { rte_eth_bond_8023ad_ext_distrib; rte_eth_bond_8023ad_ext_distrib_get; rte_eth_bond_8023ad_ext_slowtx; + rte_eth_bond_8023ad_member_info; rte_eth_bond_8023ad_setup; + rte_eth_bond_active_members_get; rte_eth_bond_create; rte_eth_bond_free; rte_eth_bond_link_monitoring_set; rte_eth_bond_mac_address_reset; rte_eth_bond_mac_address_set; + rte_eth_bond_member_add; + rte_eth_bond_member_remove; + rte_eth_bond_members_get; rte_eth_bond_mode_get; rte_eth_bond_mode_set; rte_eth_bond_primary_get; @@ -26,13 +31,3 @@ DPDK_25 { local: *; }; - -EXPERIMENTAL { - # added in 23.11 - global: - rte_eth_bond_8023ad_member_info; - rte_eth_bond_active_members_get; - rte_eth_bond_member_add; - rte_eth_bond_member_remove; - rte_eth_bond_members_get; -};