* [PATCH] net/bonding: make bonding functions stable
@ 2024-10-29 15:41 Lukas Sismis
2024-10-29 16:10 ` Stephen Hemminger
2024-10-29 17:36 ` Stephen Hemminger
0 siblings, 2 replies; 6+ messages in thread
From: Lukas Sismis @ 2024-10-29 15:41 UTC (permalink / raw)
To: chas3; +Cc: dev, Lukas Sismis
Remove rte_experimental macros from the stable functions
as they have been part of the stable API since 23.11.
Signed-off-by: Lukas Sismis <sismis@cesnet.cz>
---
drivers/net/bonding/rte_eth_bond.h | 4 ----
drivers/net/bonding/rte_eth_bond_8023ad.h | 1 -
drivers/net/bonding/version.map | 10 ----------
3 files changed, 15 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond.h b/drivers/net/bonding/rte_eth_bond.h
index e59ff8793e..4f79ff9b85 100644
--- a/drivers/net/bonding/rte_eth_bond.h
+++ b/drivers/net/bonding/rte_eth_bond.h
@@ -125,7 +125,6 @@ rte_eth_bond_free(const char *name);
* @return
* 0 on success, negative value otherwise
*/
-__rte_experimental
int
rte_eth_bond_member_add(uint16_t bonding_port_id, uint16_t member_port_id);
@@ -138,7 +137,6 @@ rte_eth_bond_member_add(uint16_t bonding_port_id, uint16_t member_port_id);
* @return
* 0 on success, negative value otherwise
*/
-__rte_experimental
int
rte_eth_bond_member_remove(uint16_t bonding_port_id, uint16_t member_port_id);
@@ -199,7 +197,6 @@ rte_eth_bond_primary_get(uint16_t bonding_port_id);
* Number of members associated with bonding device on success,
* negative value otherwise
*/
-__rte_experimental
int
rte_eth_bond_members_get(uint16_t bonding_port_id, uint16_t members[],
uint16_t len);
@@ -216,7 +213,6 @@ rte_eth_bond_members_get(uint16_t bonding_port_id, uint16_t members[],
* Number of active members associated with bonding device on success,
* negative value otherwise
*/
-__rte_experimental
int
rte_eth_bond_active_members_get(uint16_t bonding_port_id, uint16_t members[],
uint16_t len);
diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.h b/drivers/net/bonding/rte_eth_bond_8023ad.h
index b2deb26e2e..5432eafcfe 100644
--- a/drivers/net/bonding/rte_eth_bond_8023ad.h
+++ b/drivers/net/bonding/rte_eth_bond_8023ad.h
@@ -193,7 +193,6 @@ rte_eth_bond_8023ad_setup(uint16_t port_id,
* -EINVAL if conf is NULL or member id is invalid (not a member of given
* bonding device or is not inactive).
*/
-__rte_experimental
int
rte_eth_bond_8023ad_member_info(uint16_t port_id, uint16_t member_id,
struct rte_eth_bond_8023ad_member_info *conf);
diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map
index a309469b1f..68b892d1e6 100644
--- a/drivers/net/bonding/version.map
+++ b/drivers/net/bonding/version.map
@@ -26,13 +26,3 @@ DPDK_25 {
local: *;
};
-
-EXPERIMENTAL {
- # added in 23.11
- global:
- rte_eth_bond_8023ad_member_info;
- rte_eth_bond_active_members_get;
- rte_eth_bond_member_add;
- rte_eth_bond_member_remove;
- rte_eth_bond_members_get;
-};
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/bonding: make bonding functions stable
2024-10-29 15:41 [PATCH] net/bonding: make bonding functions stable Lukas Sismis
@ 2024-10-29 16:10 ` Stephen Hemminger
2024-10-29 17:36 ` Stephen Hemminger
1 sibling, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2024-10-29 16:10 UTC (permalink / raw)
To: Lukas Sismis; +Cc: chas3, dev
On Tue, 29 Oct 2024 16:41:13 +0100
Lukas Sismis <sismis@cesnet.cz> wrote:
> Remove rte_experimental macros from the stable functions
> as they have been part of the stable API since 23.11.
>
> Signed-off-by: Lukas Sismis <sismis@cesnet.cz>
Is this the same patch?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/bonding: make bonding functions stable
2024-10-29 15:41 [PATCH] net/bonding: make bonding functions stable Lukas Sismis
2024-10-29 16:10 ` Stephen Hemminger
@ 2024-10-29 17:36 ` Stephen Hemminger
2024-10-29 20:23 ` Lukáš Šišmiš
1 sibling, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2024-10-29 17:36 UTC (permalink / raw)
To: Lukas Sismis; +Cc: chas3, dev
On Tue, 29 Oct 2024 16:41:13 +0100
Lukas Sismis <sismis@cesnet.cz> wrote:
> diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map
> index a309469b1f..68b892d1e6 100644
> --- a/drivers/net/bonding/version.map
> +++ b/drivers/net/bonding/version.map
> @@ -26,13 +26,3 @@ DPDK_25 {
>
> local: *;
> };
> -
> -EXPERIMENTAL {
> - # added in 23.11
> - global:
> - rte_eth_bond_8023ad_member_info;
> - rte_eth_bond_active_members_get;
> - rte_eth_bond_member_add;
> - rte_eth_bond_member_remove;
> - rte_eth_bond_members_get;
> -};
> --
The build of this patch fails.
Need to add these functions into the DPDK_25 section.
The list there needs to stay alphabetical.
Something like:
diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map
index a309469b1f..eb37dadf76 100644
--- a/drivers/net/bonding/version.map
+++ b/drivers/net/bonding/version.map
@@ -11,12 +11,17 @@ DPDK_25 {
rte_eth_bond_8023ad_ext_distrib;
rte_eth_bond_8023ad_ext_distrib_get;
rte_eth_bond_8023ad_ext_slowtx;
+ rte_eth_bond_8023ad_member_info;
rte_eth_bond_8023ad_setup;
+ rte_eth_bond_active_members_get;
rte_eth_bond_create;
rte_eth_bond_free;
rte_eth_bond_link_monitoring_set;
rte_eth_bond_mac_address_reset;
rte_eth_bond_mac_address_set;
+ rte_eth_bond_member_add;
+ rte_eth_bond_member_remove;
+ rte_eth_bond_members_get;
rte_eth_bond_mode_get;
rte_eth_bond_mode_set;
rte_eth_bond_primary_get;
@@ -26,13 +31,3 @@ DPDK_25 {
local: *;
};
-
-EXPERIMENTAL {
- # added in 23.11
- global:
- rte_eth_bond_8023ad_member_info;
- rte_eth_bond_active_members_get;
- rte_eth_bond_member_add;
- rte_eth_bond_member_remove;
- rte_eth_bond_members_get;
-};
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/bonding: make bonding functions stable
2024-10-29 17:36 ` Stephen Hemminger
@ 2024-10-29 20:23 ` Lukáš Šišmiš
0 siblings, 0 replies; 6+ messages in thread
From: Lukáš Šišmiš @ 2024-10-29 20:23 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: chas3, dev
Sorry for multiple patch request versions, I am going to make a new one
as per your suggestions.
Thanks!
Lukas
On 29. 10. 24 18:36, Stephen Hemminger wrote:
> On Tue, 29 Oct 2024 16:41:13 +0100
> Lukas Sismis <sismis@cesnet.cz> wrote:
>
>> diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map
>> index a309469b1f..68b892d1e6 100644
>> --- a/drivers/net/bonding/version.map
>> +++ b/drivers/net/bonding/version.map
>> @@ -26,13 +26,3 @@ DPDK_25 {
>>
>> local: *;
>> };
>> -
>> -EXPERIMENTAL {
>> - # added in 23.11
>> - global:
>> - rte_eth_bond_8023ad_member_info;
>> - rte_eth_bond_active_members_get;
>> - rte_eth_bond_member_add;
>> - rte_eth_bond_member_remove;
>> - rte_eth_bond_members_get;
>> -};
>> --
> The build of this patch fails.
> Need to add these functions into the DPDK_25 section.
>
> The list there needs to stay alphabetical.
> Something like:
>
> diff --git a/drivers/net/bonding/version.map b/drivers/net/bonding/version.map
> index a309469b1f..eb37dadf76 100644
> --- a/drivers/net/bonding/version.map
> +++ b/drivers/net/bonding/version.map
> @@ -11,12 +11,17 @@ DPDK_25 {
> rte_eth_bond_8023ad_ext_distrib;
> rte_eth_bond_8023ad_ext_distrib_get;
> rte_eth_bond_8023ad_ext_slowtx;
> + rte_eth_bond_8023ad_member_info;
> rte_eth_bond_8023ad_setup;
> + rte_eth_bond_active_members_get;
> rte_eth_bond_create;
> rte_eth_bond_free;
> rte_eth_bond_link_monitoring_set;
> rte_eth_bond_mac_address_reset;
> rte_eth_bond_mac_address_set;
> + rte_eth_bond_member_add;
> + rte_eth_bond_member_remove;
> + rte_eth_bond_members_get;
> rte_eth_bond_mode_get;
> rte_eth_bond_mode_set;
> rte_eth_bond_primary_get;
> @@ -26,13 +31,3 @@ DPDK_25 {
>
> local: *;
> };
> -
> -EXPERIMENTAL {
> - # added in 23.11
> - global:
> - rte_eth_bond_8023ad_member_info;
> - rte_eth_bond_active_members_get;
> - rte_eth_bond_member_add;
> - rte_eth_bond_member_remove;
> - rte_eth_bond_members_get;
> -};
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] net/bonding: make bonding functions stable
@ 2024-10-29 14:42 Lukas Sismis
2024-10-29 16:10 ` Stephen Hemminger
0 siblings, 1 reply; 6+ messages in thread
From: Lukas Sismis @ 2024-10-29 14:42 UTC (permalink / raw)
To: chas3; +Cc: dev, Lukas Sismis
Remove rte_experimental macros from the stable functions
as they have been part of the stable API since 22.11.
Signed-off-by: Lukas Sismis <sismis@cesnet.cz>
---
drivers/net/bonding/rte_eth_bond.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond.h b/drivers/net/bonding/rte_eth_bond.h
index e59ff8793e..4f79ff9b85 100644
--- a/drivers/net/bonding/rte_eth_bond.h
+++ b/drivers/net/bonding/rte_eth_bond.h
@@ -125,7 +125,6 @@ rte_eth_bond_free(const char *name);
* @return
* 0 on success, negative value otherwise
*/
-__rte_experimental
int
rte_eth_bond_member_add(uint16_t bonding_port_id, uint16_t member_port_id);
@@ -138,7 +137,6 @@ rte_eth_bond_member_add(uint16_t bonding_port_id, uint16_t member_port_id);
* @return
* 0 on success, negative value otherwise
*/
-__rte_experimental
int
rte_eth_bond_member_remove(uint16_t bonding_port_id, uint16_t member_port_id);
@@ -199,7 +197,6 @@ rte_eth_bond_primary_get(uint16_t bonding_port_id);
* Number of members associated with bonding device on success,
* negative value otherwise
*/
-__rte_experimental
int
rte_eth_bond_members_get(uint16_t bonding_port_id, uint16_t members[],
uint16_t len);
@@ -216,7 +213,6 @@ rte_eth_bond_members_get(uint16_t bonding_port_id, uint16_t members[],
* Number of active members associated with bonding device on success,
* negative value otherwise
*/
-__rte_experimental
int
rte_eth_bond_active_members_get(uint16_t bonding_port_id, uint16_t members[],
uint16_t len);
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net/bonding: make bonding functions stable
2024-10-29 14:42 Lukas Sismis
@ 2024-10-29 16:10 ` Stephen Hemminger
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Hemminger @ 2024-10-29 16:10 UTC (permalink / raw)
To: Lukas Sismis; +Cc: chas3, dev
On Tue, 29 Oct 2024 15:42:51 +0100
Lukas Sismis <sismis@cesnet.cz> wrote:
> Remove rte_experimental macros from the stable functions
> as they have been part of the stable API since 22.11.
>
> Signed-off-by: Lukas Sismis <sismis@cesnet.cz>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-10-29 20:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-29 15:41 [PATCH] net/bonding: make bonding functions stable Lukas Sismis
2024-10-29 16:10 ` Stephen Hemminger
2024-10-29 17:36 ` Stephen Hemminger
2024-10-29 20:23 ` Lukáš Šišmiš
-- strict thread matches above, loose matches on Subject: below --
2024-10-29 14:42 Lukas Sismis
2024-10-29 16:10 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).