Re: [PATCH v5 1/1] testpmd: add hairpin-map parameter

[Stephen Hemminger <stephen@networkplumber.org>]

On Tue, 29 Oct 2024 21:51:40 +0000
Ferruh Yigit <ferruh.yigit@amd.com> wrote:

> On 9/22/2024 7:50 AM, Gregory Etelson wrote:
> > Hairpin offloads packet forwarding between ports.
> > Packet is expected on Rx port <rp>, Rx queue <rq> and is forwarded
> > to Tx port <tp> Tx queue <tq>.
> > 
> > Testpmd implements a static hairpin configuration scheme.
> > 
> > The new parameter allows explicit selection of Rx and Tx ports and
> > queues in hairpin configuration.
> > The new `hairpin-map` parameter is provided with 5 parameters,
> > separated by `:`
> > 
> > `--hairpin-map=Rx port id:Rx queue:Tx port id:Tx queue:queues number`
> > 
> > Testpmd operator can provide several `hairpin-map` parameters for
> > different hairpin maps.
> > Example:
> > 
> > dpdk-testpmd <EAL params> -- \
> >   <testpmd params> \
> >   --rxq=2 --txq=2 --hairpinq=2 --hairpin-mode=0x12 \
> >   --hairpin-map=0:2:1:2:1 \ # [1]
> >   --hairpin-map=0:3:2:2:3   # [2]
> > 
> > Hairpin map [1] binds Rx port 0, queue 2 with Tx port 1, queue 2.
> > Hairpin map [2] binds
> >   Rx port 0, queue 3 with Tx port 2, queue 2,
> >   Rx port 0, queue 4 with Tx port 2, queue 3,
> >   Rx port 0, queue 5 with Tx port 2, queue 4.
> > 
> > The new `hairpin-map` parameter is optional.
> > If omitted, testpmd will create "default" hairpin maps.
> > 
> > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> > Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
> >  
> 
> +Praveen
> cpfl is only other driver that implements hairpin, @Praveen can you
> please help reviewing this patch, and confirm change works fine with
> your changes.
> 
> @Stephen, if you have any free cycles, can you please help on this patch
> too?
> 
> Thanks,
> ferruh

Ok, can do semantic review but do not have any working HW with hairpin capability.