From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8269A45C16; Wed, 30 Oct 2024 16:05:26 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 721E0433DA; Wed, 30 Oct 2024 16:05:26 +0100 (CET) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 96E7D402EE for ; Wed, 30 Oct 2024 16:05:25 +0100 (CET) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-7edb6879196so4517141a12.3 for ; Wed, 30 Oct 2024 08:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730300725; x=1730905525; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9TNAfWcciEtcdM3X9IevguRDmjhVllllvcowbmFhRK0=; b=DBf4KXu8/pMcZAo2Zk8OZhB1t/rDFhh5P8Xp53HqMk41ag/KqPj7l4oOuZo0cc3avO 2l/5JuVohiFvDLKfUZBxVxdLhto0fNA6VLqzEVP8TOZWdB4rS1pwBh+SNnFvfLP+YBCS x+JEMkjfTBycGq3aaWQHDiXVlbyOEgYIvZbqG6KsEKIB27jIuaWf9Ck3KlPzurnJxCk8 SjlNDr1ULAak+JjNoDSkzng9lNPzyG9tA1SxqFm+JnCjZ8xVbAc5bHWtE0MFYBavq9rE 3lkIdfON0zubfHtkf07eGkcFbjTM6OM0I4sf7Bc7cr7+T8liRO8B29dBMcrwbdG0rBHB Cy5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730300725; x=1730905525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9TNAfWcciEtcdM3X9IevguRDmjhVllllvcowbmFhRK0=; b=f4lN1+NZEPYkE8o4GJGBV5p/EpKpD4/oQZbQbDpV4j1XsHaPEtMF27EyJaJMMJjRSC o/oGLXlV7TDsfKC7aJ7FXjMIbtLqTxvPd6/oGxcRrFsJhcmAWn8ZtoKZSten9jyoaXmd gsfj1TTPk6cgjNARZ7Nk4vfRPfL/EI5vL93bnE39ZioYaeqmCylZeHZuxlxtt/YXQWVy D7Ihbu/+0TR1SWvjAJUr4+0rZm+zYmdGArrwjhrSuHbSz4wEi1KTmxrM2SOL0kctOoXe nJuWEnC/md6rH7Yfy6IABsV2caPwtchHEYNpXoB+l7xAXwzEF9ofQNBpnYzCBfUOJVxs BQhg== X-Gm-Message-State: AOJu0YwcXeXKRfDgNgoTpj2Cf2NTMOdqfNTwbz4rs8UweSqBduhJHpDO eRKwFLMMU0rGcr0o4nEftgOzSXdr43Q/JOrxQS/jTn7Bhyx8bsB34UmVuP4OlCE= X-Google-Smtp-Source: AGHT+IE6yy/bpDvZ78Wrqfpb0ZxLZ/Gk9rs4Lr4rwnCG7zQGuiz3xQINweVJhhm6gQxMZs8dBLx8nQ== X-Received: by 2002:a17:90a:f0d3:b0:2e2:bb32:73e0 with SMTP id 98e67ed59e1d1-2e8f1067fc3mr16117031a91.12.1730300724671; Wed, 30 Oct 2024 08:05:24 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e92fa4570fsm1842564a91.30.2024.10.30.08.05.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 08:05:24 -0700 (PDT) Date: Wed, 30 Oct 2024 08:05:22 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, Long Li , Wei Hu Subject: Re: [PATCH] bus/vmbus: remove unnecessary packed attribute Message-ID: <20241030080522.0262c796@hermes.local> In-Reply-To: References: <20241022023728.451151-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 30 Oct 2024 10:26:38 +0100 David Marchand wrote: > On Tue, Oct 22, 2024 at 4:37=E2=80=AFAM Stephen Hemminger > wrote: > > > > The VMBus ring structure was marked packed which will cause > > warnings if the no-address-of-packed is enabled. The structure > > is all 32 bit values and the packed attribute has no impact > > on the code layout; remove it. > > > > Signed-off-by: Stephen Hemminger =20 >=20 > - Why only clean this structure in this header? > I see many others which could get cleaned wrt __rte_packed. Not sure, think these headers got inherited from the FreeBSD driver, and the FreeBSD driver got these from Windows. And Windows code always uses packed. >=20 > (There are some unused structs too and it would be better not to keep > unused code around). Yes, cleanup would be good. >=20 > - On a separate note, I wonder why the vmbus headers are exported as > public headers. > All those seem to be for use only in drivers, for resources attached > on such a bus. > Would an application benefit from talking directly to the hyperv? Probably no need to export, Long can look into it.