From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 959BD45C16; Wed, 30 Oct 2024 16:26:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 865E64028F; Wed, 30 Oct 2024 16:26:13 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id D78D440281 for ; Wed, 30 Oct 2024 16:26:11 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-72097a5ca74so1543859b3a.3 for ; Wed, 30 Oct 2024 08:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730301971; x=1730906771; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=8KZdUzaDswdPcb4aFrqR5Y8ZHRNc6FSOhTtaUDTNS+0=; b=F7oPVGN1mlLs1OAzn0pXLJRdFoWy04fHYO2Uqgy7GfjYfSrK1Ep1W62b7ct373rBvL bw6epIuWBhh4VppSN5yjmmiSjSRiWLgtK9kodYIAUtvx/dhRHHnAilnaYjjBciUW+6pN 5gxUKV+tNaNy8ES5GJ4isQC/UQWkFo+V4oZJ/c/XZpPGOoX6AYYa+YQwSxUxy8wVtrxj 5JENsvJMDBduGlMfS0PfhsMiac9Xbq1W3/IyOt1KKz4RuBXfZeuoi/UJCq8A1Nx9l0EV W5h4Q/4bCx/qoFpp42fLnKit8y3hrPkCNaHRDnjOSjHn28ONe4KsnRmkYB1YVaYxoR5Q Vcaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730301971; x=1730906771; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8KZdUzaDswdPcb4aFrqR5Y8ZHRNc6FSOhTtaUDTNS+0=; b=UcNj/cUYnWgBk3mnKCtGGZ7QFu0Z+yyzExpPbDP79AhFr3fMWwhGpd4Als4/aby9n6 jGbHF1Cs/cpkg4gGwjOmPIGPwojUYQD2USSebVUiGppk2mb8svqRwIMcrrLcWxm+eNOr kz4HV2bVBd+UcPM7Os8oZI0Pl04BtrwvAeki+Flh1RHE6Mlkia7eSa+5uPUu980Q3gKp vqzL03im/aRp9pK0SsP+lGjNyUC28HbSrqk1Sr+a296q+HYJzuXhySquyGvkdRNSaYAF WqHEtN2qz77/5HLgQ2fattHjRk1TOzAePjutrr0xuM6aKydNTGNScFb9u5qjfNRTIBSU G5KA== X-Gm-Message-State: AOJu0YyHIMT34y9IDCsEVUDFb4T6dnMYW4ihFXNbWFaMEBnVuqywCVSW Zcpgp/ygahITBD0anFePKW2W0YnW5gNb+PMwccaIeKby470JvjqGBcAFhrWQIWE= X-Google-Smtp-Source: AGHT+IGvH0CM9viprCyJoX6MCVbEZtN+rJeuODcsy2tDhwpq10G2c+51meuloOhH8meI1kcInXIXwA== X-Received: by 2002:a05:6a00:992:b0:71e:415:c4c6 with SMTP id d2e1a72fcca58-720630933a2mr22229664b3a.26.1730301970816; Wed, 30 Oct 2024 08:26:10 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7edc8a77412sm9088921a12.94.2024.10.30.08.26.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 08:26:10 -0700 (PDT) Date: Wed, 30 Oct 2024 08:26:08 -0700 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, Long Li , Wei Hu Subject: Re: [PATCH] bus/vmbus: remove unnecessary packed attribute Message-ID: <20241030082608.331f9355@hermes.local> In-Reply-To: References: <20241022023728.451151-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 30 Oct 2024 10:26:38 +0100 David Marchand wrote: > On Tue, Oct 22, 2024 at 4:37=E2=80=AFAM Stephen Hemminger > wrote: > > > > The VMBus ring structure was marked packed which will cause > > warnings if the no-address-of-packed is enabled. The structure > > is all 32 bit values and the packed attribute has no impact > > on the code layout; remove it. > > > > Signed-off-by: Stephen Hemminger =20 >=20 > - Why only clean this structure in this header? The patch was addressing the warning generated when the address of packed member is re-enabled. The other usages are less of a problem and cause no errors.