From: Stephen Hemminger <stephen@networkplumber.org>
To: liwencheng <liwencheng@phytium.com.cn>
Cc: dev@dpdk.org
Subject: Re: [PATCH v1] net/macb: add new driver
Date: Wed, 30 Oct 2024 08:32:28 -0700 [thread overview]
Message-ID: <20241030083228.580e6472@hermes.local> (raw)
In-Reply-To: <1730282009-562817-1-git-send-email-liwencheng@phytium.com.cn>
On Wed, 30 Oct 2024 09:53:29 +0000
liwencheng <liwencheng@phytium.com.cn> wrote:
> diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
> index 80c35f9..b4db58b 100755
> --- a/usertools/dpdk-devbind.py
> +++ b/usertools/dpdk-devbind.py
This should be a separate patch.
Please run a python checker like flake8 and cleanup.
$ flake8 --max-line-length=100 dpdk-devbind.py
dpdk-devbind.py:156:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:167:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:353:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:374:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:398:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:408:5: E265 block comment should start with '# '
dpdk-devbind.py:415:25: E127 continuation line over-indented for visual indent
dpdk-devbind.py:421:21: E128 continuation line under-indented for visual indent
dpdk-devbind.py:428:13: E128 continuation line under-indented for visual indent
dpdk-devbind.py:435:17: E127 continuation line over-indented for visual indent
dpdk-devbind.py:437:62: E225 missing whitespace around operator
dpdk-devbind.py:439:1: E302 expected 2 blank lines, found 1
dpdk-devbind.py:629:32: E231 missing whitespace after ','
Also, it would probably better to encourage users to use another tool
like driverctl, rather than adding more complexity to dpdk-devbind.
That was the response I got when looking to add vmbus support to devbind.
next prev parent reply other threads:[~2024-10-30 15:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 9:53 liwencheng
2024-10-30 10:14 ` Bruce Richardson
2024-10-30 15:32 ` Stephen Hemminger [this message]
2024-10-30 15:40 ` Stephen Hemminger
-- strict thread matches above, loose matches on Subject: below --
2024-10-30 7:59 liwencheng
2024-10-30 5:51 liwencheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030083228.580e6472@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=liwencheng@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).