From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED5A645C16; Wed, 30 Oct 2024 16:32:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD56B4028F; Wed, 30 Oct 2024 16:32:33 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 2AB8640281 for ; Wed, 30 Oct 2024 16:32:32 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-210e5369b7dso32107195ad.3 for ; Wed, 30 Oct 2024 08:32:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730302351; x=1730907151; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Zs89z1JT3gPKRvb9bLPVUqJ2nsAye5g6dgA8oZvHjkM=; b=lw8UZ+7lV8uyRUGbC+M4/4KzsZYmMOCBUjzhI3NXFuUFlY2rlcsMjbpc00YDyUDDwE DSyCu/ZTH+WzRUYnF8z6u+T2NZ16DREmjkjTH9ELHGNRfgQOA2aUs1gSgIEZvSD21ssv Xpc4mOvcP3RU51yhsMNShy7F3XcEugThKyeYxyEsEl6lbOYVCPYGS78W2kCu2naNy9hb /HiopeGLsQsUUYb6mQGOaDFjXaxAxp21V07A5YsSYGPTt6ABmdYc4OjBO9MnJnoqNP5F 4o/6vHKKKxVxmK8PEpSXHYmTVW4jiFk2XVwdysmBkZBy1aQdZ+TAEB8tb2S+ORLNmgwn N8dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730302351; x=1730907151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Zs89z1JT3gPKRvb9bLPVUqJ2nsAye5g6dgA8oZvHjkM=; b=fr6gJCPOsVdHvCtpY1t79V9uyYqjh/sWcuUeF/lqmWaimUgmJMktu3BktTjgAUAkCn rUxGe1tp1tsIjKviQm/tdyTRup66r71iHQcV8gp5dlNqz/y56qg+dWM6H8pkQo4s+OuV NG4GbZ7CSpDUYtKtGzL8nfsYDtwHnvJnEAN4bz4Ey5RNdLF4e62UbJHs4nb0SLtz+4QC II5Otq1TfdZ98iS29Xjzsm0IBuELOBPgQFCyBgVJO4nUxeNaVXd4IeGEneeD6R5C+1cM 6o+QWTQfDa4YOaN41y4W9MP64OxxVsOG/7p52y6zZs24S/iqsezef48LYbWwoshoaL1u PZsw== X-Gm-Message-State: AOJu0Yx8YnCFKLmLlBQ5u9il4HNdDaV75QcwWyrq5qCIFWq3ZQQ0QHh2 MVGi0FXZoB+AUL/bZ5vdA3QZv3rgIAuUhQGA/+w0GKit83mE53cpVrtsHjnUBnborvXlCBC0HtD A X-Google-Smtp-Source: AGHT+IGAFPyIGjn1XvwhNTG2PNjjQqYgtc1Jk+cWAUeMJ/fQoaDNuAoh1VHBoe9xYKCzillJFJougQ== X-Received: by 2002:a17:903:32c4:b0:20c:7796:5e76 with SMTP id d9443c01a7336-210c68d82f3mr228166415ad.18.1730302349910; Wed, 30 Oct 2024 08:32:29 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bc02ee38sm82370075ad.215.2024.10.30.08.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 08:32:29 -0700 (PDT) Date: Wed, 30 Oct 2024 08:32:28 -0700 From: Stephen Hemminger To: liwencheng Cc: dev@dpdk.org Subject: Re: [PATCH v1] net/macb: add new driver Message-ID: <20241030083228.580e6472@hermes.local> In-Reply-To: <1730282009-562817-1-git-send-email-liwencheng@phytium.com.cn> References: <1730282009-562817-1-git-send-email-liwencheng@phytium.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 30 Oct 2024 09:53:29 +0000 liwencheng wrote: > diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py > index 80c35f9..b4db58b 100755 > --- a/usertools/dpdk-devbind.py > +++ b/usertools/dpdk-devbind.py This should be a separate patch. Please run a python checker like flake8 and cleanup. $ flake8 --max-line-length=100 dpdk-devbind.py dpdk-devbind.py:156:1: E302 expected 2 blank lines, found 1 dpdk-devbind.py:167:1: E302 expected 2 blank lines, found 1 dpdk-devbind.py:353:1: E302 expected 2 blank lines, found 1 dpdk-devbind.py:374:1: E302 expected 2 blank lines, found 1 dpdk-devbind.py:398:1: E302 expected 2 blank lines, found 1 dpdk-devbind.py:408:5: E265 block comment should start with '# ' dpdk-devbind.py:415:25: E127 continuation line over-indented for visual indent dpdk-devbind.py:421:21: E128 continuation line under-indented for visual indent dpdk-devbind.py:428:13: E128 continuation line under-indented for visual indent dpdk-devbind.py:435:17: E127 continuation line over-indented for visual indent dpdk-devbind.py:437:62: E225 missing whitespace around operator dpdk-devbind.py:439:1: E302 expected 2 blank lines, found 1 dpdk-devbind.py:629:32: E231 missing whitespace after ',' Also, it would probably better to encourage users to use another tool like driverctl, rather than adding more complexity to dpdk-devbind. That was the response I got when looking to add vmbus support to devbind.