From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EF3C45C16; Wed, 30 Oct 2024 16:48:58 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90CB743438; Wed, 30 Oct 2024 16:48:58 +0100 (CET) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id 120D04028F for ; Wed, 30 Oct 2024 16:48:57 +0100 (CET) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-20cb89a4e4cso46608995ad.3 for ; Wed, 30 Oct 2024 08:48:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730303336; x=1730908136; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Y5f3MjxHtIVYNrh6KQ7pOGeo370o+fHTAn8nDxEkFqQ=; b=oInSsB8fhr2LnJ+ygWbYKoDVPlYhAXo9cCeQu4HXqL2+bNzhreV4fOHUxLLHEMseU3 yZDwibXIY88AbmzB2VhjR0Gu7oEkzy3B22F61lZdKmwf5lF7Dvrn27oimgk19Nq/8IhC FnCHbaVOv89QyILfVMbuHKsxJV3VBSc/CHLRDxHFARgFaY4dhHKg7EEi0pDEsak5QjOc o4U3wEwGcrYR7aT2qX+K7PQ0jSZwmeKcs2JKHLIHwlnqsx0roi4t3axEXukJ07ayYhhn AFxh0IbiC9wdiPJ/0upCkSrYxpU0bAavoYFzd4XJJ6CO6IgEm8d8D7zAL4vbqlu8APB6 /Wdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730303336; x=1730908136; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y5f3MjxHtIVYNrh6KQ7pOGeo370o+fHTAn8nDxEkFqQ=; b=UcVN8P3EDw/i5ka5Muyk6xIwhaDf7z0WK6dQyqv3DCcK6GjtSJTXYBAeevO/AVnsB5 Q9BsP89eV4EacRxYOwbS0Rf/WXcwr2EYYZ3KWyBWHmUaICI/W5jSGVNPCAJaAmItIrYb v4lLLrOyN7gQOIqxVtL6VOShj4ee0q+Xu1J+AKqUnfU+CFmuDr/RMXTLj0A36GwVoSrI xOOAcsRZv5g7eYJolxi+WR3sVYU9ImO+7Z7SV3jslI5q0DrC1ELqiHcIG2aTNr0jPc2M jRRqfV/Zckn3Zyhiqrpctw7f2nY622VbewWPUB369IQSuaJFylGaoRPOa3sZcV3hxb3g gQnA== X-Forwarded-Encrypted: i=1; AJvYcCVoXlJxvSeh91JYwR8hE5/tROblb76rM6n/0Hesa5iRAh90tjTyCd625g/JJO9YUjOMgNs=@dpdk.org X-Gm-Message-State: AOJu0Yx9mYyjOq+9qOo/TpjgRdWDEtkm7NK/JZKJsxCxaVTQ7dp2EayI gHA5qIsPKGSB3GUtY7dXE4F/YGIR5LjlHHlLovTsbd2OTyWET5jDDSGAc6dnTu3bTd18tD4+xjD d X-Google-Smtp-Source: AGHT+IGVHN4iuku55krdRca04Y+2TZ0jsAkDc6Ia4EZku+Gc/74aG23OtjVPVcM3NqRe62xVqGsvSA== X-Received: by 2002:a17:903:2b0e:b0:20c:769b:f042 with SMTP id d9443c01a7336-210c6c079fcmr218099695ad.31.1730303336136; Wed, 30 Oct 2024 08:48:56 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-210bbf6d3f4sm82399405ad.69.2024.10.30.08.48.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 08:48:55 -0700 (PDT) Date: Wed, 30 Oct 2024 08:48:54 -0700 From: Stephen Hemminger To: Andre Muezerie Cc: dmitry.kozliuk@gmail.com, dev@dpdk.org Subject: Re: [PATCH v4] doc: modernize build instructions on Windows Message-ID: <20241030084854.5630a336@hermes.local> In-Reply-To: <1730301585-14536-1-git-send-email-andremue@linux.microsoft.com> References: <20241030120920.55303842@sovereign> <1730301585-14536-1-git-send-email-andremue@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 30 Oct 2024 08:19:45 -0700 Andre Muezerie wrote: > Meson 0.57 was an unstable version and is now outdated. > The referenced bug in Meson 0.58 is fixed in stable releases. > Recommend the latest stable release which is tested. > > Building DPDK applications that run on 32-bit Windows is > currently not supported. However, some Visual Studio environments > default to producing 32-bit binaries. > Recommend instructing the developer prompt to produce 64-bit binaries > when that is the case. > > Signed-off-by: Andre Muezerie > --- > v4: > - Clarified that "32-bit binaries" were refering to the Windows environment. > - Added clarifying commit messages. > v3: > - Recommended Meson version to use and removed mention about old bug. > - Set VS developer prompt to produce 64 bit binaries if needed. > v2: > - provide Meson version that works > > .mailmap | 1 + > doc/guides/windows_gsg/build_dpdk.rst | 22 ++++++++++++++++------ > 2 files changed, 17 insertions(+), 6 deletions(-) > > diff --git a/.mailmap b/.mailmap > index 5290420..60db768 100644 > --- a/.mailmap > +++ b/.mailmap > @@ -98,6 +98,7 @@ Anatolii Gerasymenko > Anatoly Burakov > Anbarasan Murugesan > Anders Roxell > +Andre Muezerie > Andrea Arcangeli > Andrea Grandi > Andre Richter > diff --git a/doc/guides/windows_gsg/build_dpdk.rst b/doc/guides/windows_gsg/build_dpdk.rst > index 708875c..ff89e95 100644 > --- a/doc/guides/windows_gsg/build_dpdk.rst > +++ b/doc/guides/windows_gsg/build_dpdk.rst > @@ -72,10 +72,7 @@ A good option to choose is the MSI installer for both meson and ninja together:: > > http://mesonbuild.com/Getting-meson.html#installing-meson-and-ninja-with-the-msi-installer%22 > > -Required version is Meson 0.57. > - > -Versions starting from 0.58 are unusable with LLVM toolchain > -because of a `Meson issue `_. > +Meson version 1.5.2 or newer is recommended. > > > Install the Backend > @@ -129,13 +126,26 @@ Depending on the distribution, paths in this file may need adjustments. > Option 3. Native Build on Windows using MSVC > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. > +Open a 'Visual Studio Developer Command Prompt'. > The developer prompt will configure the environment > to select the appropriate compiler, linker and SDK paths > required to build with Visual Studio 2022. > > +Building DPDK applications that run on 32-bit Windows is currently not > +supported. If your Visual Studio environment defaults to producing > +32-bit binaries you can instruct the toolset to produce 64-bit binaries using "-arch" parameter. > +For more details about the Developer Prompt options look at the `Visual Studio Developer > +Command Prompt and Developer PowerShell > +`_. > + > +.. code-block:: console > + > + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 > + > +Compile the code from the developer prompt. > + > .. code-block:: console > > cd C:\Users\me\dpdk > meson setup -Denable_stdatomic=true build > - meson compile -C build > + meson compile -C build > \ No newline at end of file Please fix the file to have newline at end.