From: Chengwen Feng <fengchengwen@huawei.com>
To: <thomas@monjalon.net>, <ferruh.yigit@amd.com>,
<david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <stephen@networkplumber.org>
Subject: [PATCH v4 4/7] app/test: extract with keys testcase for kvargs
Date: Wed, 30 Oct 2024 08:54:47 +0000 [thread overview]
Message-ID: <20241030085450.56864-5-fengchengwen@huawei.com> (raw)
In-Reply-To: <20241030085450.56864-1-fengchengwen@huawei.com>
The test_valid_kvargs() function is too long to understand, extract
the with keys tests as one stand-alone testcase.
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/test_kvargs.c | 60 +++++++++++++++++++++++++-----------------
1 file changed, 36 insertions(+), 24 deletions(-)
diff --git a/app/test/test_kvargs.c b/app/test/test_kvargs.c
index 2147080160..8b53d6d585 100644
--- a/app/test/test_kvargs.c
+++ b/app/test/test_kvargs.c
@@ -43,30 +43,6 @@ static int test_valid_kvargs(void)
const char *valid_keys_list[] = { "foo", "check", NULL };
const char **valid_keys;
- /* second test using valid_keys */
- args = "foo=droids,check=value0,check=value1,check=wrong_value";
- valid_keys = valid_keys_list;
- kvlist = rte_kvargs_parse(args, valid_keys);
- if (kvlist == NULL) {
- printf("rte_kvargs_parse() error");
- goto fail;
- }
- /* call check_handler() on all entries with key="check", it
- * should fail as the value is not recognized by the handler */
- if (rte_kvargs_process(kvlist, "check", check_handler, NULL) == 0) {
- printf("rte_kvargs_process() is success but should not\n");
- rte_kvargs_free(kvlist);
- goto fail;
- }
- count = rte_kvargs_count(kvlist, "check");
- if (count != 3) {
- printf("invalid count value %d after rte_kvargs_count(check)\n",
- count);
- rte_kvargs_free(kvlist);
- goto fail;
- }
- rte_kvargs_free(kvlist);
-
/* third test using list as value */
args = "foo=[0,1],check=value2";
valid_keys = valid_keys_list;
@@ -224,6 +200,41 @@ test_parse_without_valid_keys(void)
return 0;
}
+static int
+test_parse_with_valid_keys(void)
+{
+ const char *args = "foo=droids,check=value0,check=value1,check=wrong_value";
+ const char *valid_keys[] = { "foo", "check", NULL };
+ struct rte_kvargs *kvlist;
+
+ kvlist = rte_kvargs_parse(args, valid_keys);
+ if (kvlist == NULL) {
+ printf("rte_kvargs_parse() error\n");
+ return -1;
+ }
+
+ /* call check_handler() on all entries with key="check", it
+ * should fail as the value is not recognized by the handler
+ */
+ count = 0;
+ if (rte_kvargs_process(kvlist, "check", check_handler, NULL) == 0 || count != 2) {
+ printf("rte_kvargs_process(check) is success but should not\n");
+ rte_kvargs_free(kvlist);
+ return -1;
+ }
+
+ count = rte_kvargs_count(kvlist, "check");
+ if (count != 3) {
+ printf("invalid count value %u after rte_kvargs_count(check)\n",
+ count);
+ rte_kvargs_free(kvlist);
+ return -1;
+ }
+
+ rte_kvargs_free(kvlist);
+ return 0;
+}
+
/* test several error cases */
static int test_invalid_kvargs(void)
{
@@ -267,6 +278,7 @@ static struct unit_test_suite kvargs_test_suite = {
TEST_CASE(test_valid_kvargs),
TEST_CASE(test_basic_token_count),
TEST_CASE(test_parse_without_valid_keys),
+ TEST_CASE(test_parse_with_valid_keys),
TEST_CASE(test_invalid_kvargs),
TEST_CASES_END() /**< NULL terminate unit test array */
}
--
2.17.1
next prev parent reply other threads:[~2024-10-30 8:54 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 9:53 [PATCH 0/7] refactor kvargs test Chengwen Feng
2023-11-03 9:53 ` [PATCH 1/7] app/test: introduce UT suite framework for kvargs Chengwen Feng
2024-10-11 2:08 ` Stephen Hemminger
2024-10-11 3:35 ` fengchengwen
2023-11-03 9:53 ` [PATCH 2/7] app/test: extract basic token count testcase " Chengwen Feng
2023-11-03 9:53 ` [PATCH 3/7] app/test: extract without keys " Chengwen Feng
2023-11-03 9:53 ` [PATCH 4/7] app/test: extract with " Chengwen Feng
2023-11-03 9:53 ` [PATCH 5/7] app/test: extract parse list value " Chengwen Feng
2023-11-03 9:53 ` [PATCH 6/7] app/test: extract parse empty elements " Chengwen Feng
2023-11-03 9:53 ` [PATCH 7/7] maintainers: update for kvargs library Chengwen Feng
2023-12-05 2:55 ` [PATCH 0/7] refactor kvargs test fengchengwen
2024-10-05 15:49 ` Stephen Hemminger
2024-10-11 3:34 ` [PATCH v2 " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 1/7] app/test: introduce UT suite framework for kvargs Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 2/7] app/test: extract basic token count testcase " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 3/7] app/test: extract without keys " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 4/7] app/test: extract with " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 5/7] app/test: extract parse list value " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 6/7] app/test: extract parse empty elements " Chengwen Feng
2024-10-11 3:34 ` [PATCH v2 7/7] maintainers: update for kvargs library Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 0/8] refactor kvargs test Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 1/8] app/test: introduce UT suite framework for kvargs Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 2/8] app/test: extract basic token count testcase " Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 3/8] app/test: extract without keys " Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 4/8] app/test: extract with " Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 5/8] app/test: extract parse list value " Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 6/8] app/test: extract parse empty elements " Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 7/8] app/test: add process opt " Chengwen Feng
2024-10-22 6:14 ` [PATCH v3 8/8] maintainers: update for kvargs library Chengwen Feng
2024-10-30 8:54 ` [PATCH v4 0/7] refactor kvargs test Chengwen Feng
2024-10-30 8:54 ` [PATCH v4 1/7] app/test: introduce UT suite framework for kvargs Chengwen Feng
2024-10-30 8:54 ` [PATCH v4 2/7] app/test: extract basic token count testcase " Chengwen Feng
2024-10-30 8:54 ` [PATCH v4 3/7] app/test: extract without keys " Chengwen Feng
2024-10-30 8:54 ` Chengwen Feng [this message]
2024-10-30 8:54 ` [PATCH v4 5/7] app/test: extract parse list value " Chengwen Feng
2024-10-30 8:54 ` [PATCH v4 6/7] app/test: extract parse empty elements " Chengwen Feng
2024-10-30 8:54 ` [PATCH v4 7/7] app/test: add process opt " Chengwen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030085450.56864-5-fengchengwen@huawei.com \
--to=fengchengwen@huawei.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).