From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D02C545C13; Wed, 30 Oct 2024 11:55:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A15A8433D5; Wed, 30 Oct 2024 11:55:24 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2057.outbound.protection.outlook.com [40.107.101.57]) by mails.dpdk.org (Postfix) with ESMTP id EB10E433DA for ; Wed, 30 Oct 2024 11:55:22 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Q3sZJ83KjjjzpS7izrKBJL7ztvlSrjiPYw9YbrdMUribICfq7TuQzFQjsYijfnPPzSxMByNSVqUqIjAoJyY6M30l/Sfo0D6UY5N84kYiZUmhO2aMBqVAGc+eufD2W4go27e+8VLAagG5jtrwPevcDLA74X/J7kNhttLGpATSBcvMDMQOj1yE/HmfgHcqywaxeUDhExlvamMO+GsMJXYbioprcRxqZFnBxrRlJvs0WHgp9JKqJAQPfCPt/IUmBmpi2sTZOE0kb8PntFVV3hIqP0c32my+QZtjHQUe5vemkG6zXx5qvnSVlTvCqVjVrdXvafUV3ShRCCasV9zGY9QgVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pb4ptJdxHVhJPMePUAcq2GGa9JAqlWKiWn/Hi7dZ8uQ=; b=RSQ4RXWAWVma4vENaKpscv5v+9QbgnVe1FhwOrtsVWjYt/NcW5STSa4JQ3d6HvGU3J6hFRhoLMc8OzTmT8JaBLMASWogwISWkxk8E7mMLKrC0eMO/OerjV3l9Us7M4jNO7vqAOuvZ4AZaYdHqInWt72eB1SsxH6U1CL3kB2GTj5mZDdx9gyneufpTMjeTqeAYY0ivUTgbSpjUM+eJy3hohLTYAbpB9QFHF9mEsU0SivuDLs0LxfdTMipUVw1Paw+Niu0bZjxFFkjAHfBc58AVnzEayOfuf1Nzw6LsLaMkDmM+tsmiB8RTM7+DUxGETsFhtP9vhy+uEhnd/CgKrAehw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pb4ptJdxHVhJPMePUAcq2GGa9JAqlWKiWn/Hi7dZ8uQ=; b=qp74r2BghAeM1sqfD49G1BBUK1ZipyGs2nA88LW24igANDKLntNAIqn1JiF/0lzT9sbWzQeJ1wJQUJwLtEU82Xj8VtPUMvcY3krEqXniGZNM1Iy1EudVrlCgGod4xIDOFGDhlUW+vm6t3oPEBuXTENTf6ZnVrwXiijmoPd3bnhCHutC3j7jaO/UeGAECgYe4iZR4574OvBPjm9YX9kvex9jbhn6+1RoAgqIhUcU9IOiAFJlSJDTLH5uPgqt/2m7JT/upOIuHo4F53I3XG5wib+Oz3fgM0MXyCglR59qC4JO7FBntTSxgTjhFiaTwBpqz0eOQocguKFMldb2sTPp/Eg== Received: from BN9PR03CA0072.namprd03.prod.outlook.com (2603:10b6:408:fc::17) by SN7PR12MB6959.namprd12.prod.outlook.com (2603:10b6:806:261::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.25; Wed, 30 Oct 2024 10:55:16 +0000 Received: from MN1PEPF0000ECD9.namprd02.prod.outlook.com (2603:10b6:408:fc:cafe::e8) by BN9PR03CA0072.outlook.office365.com (2603:10b6:408:fc::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.17 via Frontend Transport; Wed, 30 Oct 2024 10:55:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by MN1PEPF0000ECD9.mail.protection.outlook.com (10.167.242.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.16 via Frontend Transport; Wed, 30 Oct 2024 10:55:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 30 Oct 2024 03:54:52 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Wed, 30 Oct 2024 03:54:50 -0700 From: Dariusz Sosnowski To: Raslan Darawsheh , Viacheslav Ovsiienko , Bing Zhao , Ori Kam , Suanming Mou , Matan Azrad CC: Subject: [PATCH 2/3] net/mlx5: fix mingw stubs link issue in flow destroy Date: Wed, 30 Oct 2024 11:54:11 +0100 Message-ID: <20241030105412.482107-3-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241030105412.482107-1-dsosnowski@nvidia.com> References: <20241030105412.482107-1-dsosnowski@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECD9:EE_|SN7PR12MB6959:EE_ X-MS-Office365-Filtering-Correlation-Id: a78b1a1a-f3e4-4c6c-7147-08dcf8d1568a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Gzl88Z2mTIr30Sbzy9Nq19RXnRgvmzs1V/YCsuABcyEj8S1a4F7TGqyiH4ju?= =?us-ascii?Q?3jRZaCxPHc7QL0JSK1tXe8oeyixqrHVovNJwX9j/THq8qo7pQRuLoo7Gz0K1?= =?us-ascii?Q?XoXCOuhoZWokB6YXDgMXW9PBeml8OrF8+B5Y1/k1WvdhZvo0+9XNoW1vtjO6?= =?us-ascii?Q?UJCQsiqHrnFxLsz6+L71sdIkaeEaVKIZ1A9sivU9T3iGW46eJRw+iUfufkJi?= =?us-ascii?Q?LQcias/C12J6hpET/GPDg4gy2QPzkHhRRohcnkZ8KiBZtIKZ4M7xcIYGmuQN?= =?us-ascii?Q?wUvvSxXYuLSA70Mxjv070uBkFNbfbviEb0QDnhU9dS+z4h7l3FBAlsGDGHNu?= =?us-ascii?Q?iHliBzPgQz+SNl616iM7I2308UIFp2YxaBx1yetRyPI2f93w5dRjHYBcJXD6?= =?us-ascii?Q?60y7WyQjVP5Im5bUvWC02wZ1alZxyVRTH7rqNyfL4rHeoGV//ImFEjWIAP8/?= =?us-ascii?Q?maw/H06nl0lKURYDEF1jcSrefytsb+h6cnG/9amPNd1sDFh9oTr+xhv+jwaU?= =?us-ascii?Q?6lYvLrJ5nTAfzBJ7WzSBJkh0a+2YwjDpAHBkAW5B54R5A1MWOFc/hbTx2QHZ?= =?us-ascii?Q?WsAFS6aKhcRk8f1EhdXJ6xYwC7qt/gyYnZohnzA8lpJdGGbYZhHC4Vp3+ixL?= =?us-ascii?Q?zaYRh5zvJatNP9XWa2xKD29fTz7gtGwDAk5TeJ7bENvLJs6VKKeVQmXFLKCL?= =?us-ascii?Q?wovdQZhT9YLaHQInHkSB6dzWUhBNhJvOQsMvY+KTW+jhIa0AhO9RlOHgF8VM?= =?us-ascii?Q?R9EXUQcMSVJQrKv6OaiRZOQbM//Pj60TSVQt9ocG4mmewVC8rPHotMEPMgAl?= =?us-ascii?Q?JR4AvpUVyqbZ+sXNQU1RAI3oL6XLH7yN7keqdLY4u6DQrYfnqdmzfi9LOar9?= =?us-ascii?Q?FA0OKakxXQXoWhNguC6rjHHKAVqZoh3H5U1Fh/swvVv1c2qO0pKOZFXmL84C?= =?us-ascii?Q?SNkyP9sHeJdjzmOZBLristA8MEFjCQ6jm2RBe927NcMMEZFDACCYZmd12Yb8?= =?us-ascii?Q?UTdbQN8qrso3yTBE5yggNOryTyVdYvtv5lJQtjEX1F5UT2jfzJItbglLF31n?= =?us-ascii?Q?i56UxP/WFN2hTDh0Pht4Lty3Whl5fnBxyXtj+3TeiHYMk715ZKnPtpawBSWS?= =?us-ascii?Q?Gr3s02TNBQrlh9ZDf2DLCmrXFZXruODHKxdi3AgwO5C6WsKLHL7YlNYXzNts?= =?us-ascii?Q?PEesAMEPmCqmUpKWjyIdCNrAFQgsS6ofkzJZLinwAIl2CP+m+Kleq1SVPO84?= =?us-ascii?Q?Gk3cWImdOeARpLGLlWKuhuPlimTGwxtyEjtwZVm2dthi4tXo18bq2njv/0/J?= =?us-ascii?Q?HUA5H6aBwiuuUg4h4G/0ONsYstnqrQezFN9V9zgwBNTxyLD1PSRmxvre2BoQ?= =?us-ascii?Q?T/YeVVbbPV/J6YbaTQsZG0MaOGCkB96gJLV2OCEQ4348p/h23g=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2024 10:55:16.1503 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a78b1a1a-f3e4-4c6c-7147-08dcf8d1568a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECD9.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6959 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Offending commit used weak symbols to implement stubs for functions for destroying control flow rules for MAC address and VLAN matching. Since weak symbols are not supported with MinGW and concrete implementations of these functions are required if and only if PMD is compiled on Linux and DV API is available in rdma-core, this patch removes the __rte_weak. mlx5_flow_hw_stubs.c was already included on required platforms by preceding commit. Fixes: 8ed3e0001d0d ("net/mlx5: support destroying unicast flow rules") Signed-off-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw_stubs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw_stubs.c b/drivers/net/mlx5/mlx5_flow_hw_stubs.c index 1df615d94c..06c096e1bc 100644 --- a/drivers/net/mlx5/mlx5_flow_hw_stubs.c +++ b/drivers/net/mlx5/mlx5_flow_hw_stubs.c @@ -31,7 +31,7 @@ mlx5_flow_hw_ctrl_flow_dmac(struct rte_eth_dev *dev __rte_unused, * - PMD is compiled on Windows or * - available rdma-core does not support HWS. */ -__rte_weak int +int mlx5_flow_hw_ctrl_flow_dmac_destroy(struct rte_eth_dev *dev __rte_unused, const struct rte_ether_addr *addr __rte_unused) { @@ -58,7 +58,7 @@ mlx5_flow_hw_ctrl_flow_dmac_vlan(struct rte_eth_dev *dev __rte_unused, * - PMD is compiled on Windows or * - available rdma-core does not support HWS. */ -__rte_weak int +int mlx5_flow_hw_ctrl_flow_dmac_vlan_destroy(struct rte_eth_dev *dev __rte_unused, const struct rte_ether_addr *addr __rte_unused, const uint16_t vlan __rte_unused) -- 2.39.5