DPDK patches and discussions
 help / color / mirror / Atom feed
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3] doc: enhance build instructions on Windows
Date: Wed, 30 Oct 2024 12:09:20 +0300	[thread overview]
Message-ID: <20241030120920.55303842@sovereign> (raw)
In-Reply-To: <1730144749-25447-1-git-send-email-andremue@linux.microsoft.com>

2024-10-28 12:45 (UTC-0700), Andre Muezerie:
> Enhance build instructions on Windows

Commit messages should explain why the previous state had been problematic
and how the new state solves the issues. For example:

	doc: modernize build instructions on Windows

	Meson 0.57 was an unstable version and is now outdated.
	The referenced bug in Meson 0.58 is fixed in stable releases.
	Recommend the latest stable release which is tested.

	...likewise about command prompt changes...

[...]
> @@ -129,11 +126,23 @@ Depending on the distribution, paths in this file may need adjustments.
>  Option 3. Native Build on Windows using MSVC
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  
> -Open a 'Developer PowerShell for VS 2022' prompt from the start menu.
> +Open a 'Visual Studio Developer Command Prompt'.
>  The developer prompt will configure the environment
>  to select the appropriate compiler, linker and SDK paths
>  required to build with Visual Studio 2022.
>  
> +Windows 32-bit is currently not supported, so if your Visual Studio environment defaults
> +to 32-bits you can instruct the toolset to produce 64-bit binaries using "-arch" parameter.
> +For more details about the Developer Prompt options look at the `Visual Studio Developer
> +Command Prompt and Developer PowerShell
> +<https://learn.microsoft.com/en-us/visualstudio/ide/reference/command-prompt-powershell?view=vs-2022>`_.
> +
> +.. code-block:: console
> +
> +    "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64
> +
> +Compile the code from the developer prompt.
> +
>  .. code-block:: console
>  
>     cd C:\Users\me\dpdk

It will be unclear to the reader to which machine "32-bit" refers.
Suggestion:

	Building DPDK applications that run on 32-bit Windows is currently not
	supported. If your Visual Studio environment defaults to producing
	32-bit binaries...

With the above corrections,
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>

  reply	other threads:[~2024-10-30  9:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-25 14:15 [PATCH] doc: enhance build instructions on windows Andre Muezerie
2024-10-25 14:15 ` [PATCH] doc: enhanced build instructions on Windows Andre Muezerie
2024-10-25 14:50   ` Thomas Monjalon
2024-10-25 19:30     ` [PATCH v2 0/2] doc: enhance build instructions on windows Andre Muezerie
2024-10-25 19:30       ` [PATCH v2 1/2] doc: enhanced build instructions on Windows Andre Muezerie
2024-10-26 21:03         ` Dmitry Kozlyuk
2024-10-28 19:45           ` [PATCH v3] doc: enhance " Andre Muezerie
2024-10-30  9:09             ` Dmitry Kozlyuk [this message]
2024-10-25 19:30       ` [PATCH v2 2/2] doc: provide Meson version that works Andre Muezerie
2024-10-26 20:45         ` Dmitry Kozlyuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241030120920.55303842@sovereign \
    --to=dmitry.kozliuk@gmail.com \
    --cc=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).