From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B6E345C13; Wed, 30 Oct 2024 10:09:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F024943387; Wed, 30 Oct 2024 10:09:27 +0100 (CET) Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by mails.dpdk.org (Postfix) with ESMTP id 6D57F42FB9 for ; Wed, 30 Oct 2024 10:09:26 +0100 (CET) Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2fb5743074bso6083671fa.1 for ; Wed, 30 Oct 2024 02:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730279366; x=1730884166; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TrtCCU5s9D1Xtp3lCqFfitZSTfO73zipdTwFncFbJWs=; b=DB1pR0xew9ZBL+/Nb0eeD8b2aAu25N/PBXCKVDaxniqMQaFcjhb9B3VR3nuLd6mH+4 UkBN+2j6WHM6jKBpE9gG1715w3wTiijrdozxjSTvu9jBSP49MvbeOaEF4t16w7rWswd2 RPJWmMTnRrSpn7VUmY91sayLZ+6wBLC4zgNxq47ZL2/Rg44kt72uwznPY+mVWCNUFfvz XEI+QYcOjXhegFIx61hxqArkLxE/NV2PSHEeFsd2OaRYba+C1wWpJgyduaczhkRx6ISC tf1GfN+a6nKyV07/Gkvh4vcfhnmp/pOhif+Xcaay10Ok+ZHMCKaVyaTQj3i/u26vltjO ICDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730279366; x=1730884166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TrtCCU5s9D1Xtp3lCqFfitZSTfO73zipdTwFncFbJWs=; b=IOqVqehJR7MHlXPLUiuGlrP3KfaNQfxmrSgr5zG9Mnu1zwW2XzLE9fjJxSSV1qMo+/ GKfWbkuhA6UcfpXbW/1ZGttScXT8SbVYckZJRzN6ob3i8b/PBY6ARQ2igq048M5JfXjc uoyY955D0rqlFO/EZxstSVF8fy4zqd8L/0Zz7IwmuxNROAl3/SkqpH7EnaT+G9etZJne n49G17Wp23Rr2hbbGluKDHFEu8rppb5HWElUgxYfnkKJpE8U5dpHK+dOBryrc570tyK9 Kp5ZHoRqKxuxf3yyd1B7ZbG8Vl8RwosQcjOmhZhgBjMnD4yCdXX77uO95NoxvQby6QJY D1Bg== X-Gm-Message-State: AOJu0YyEw8NHwIIQuz+xdjgRRnvgPiNE87phVrakYLoEhnfJz9bVPfjI CcbRj8f3pBlivUNSwMz2fVN42szcKjw4uxOh7iwPKubTdtrD/PQZ X-Google-Smtp-Source: AGHT+IFgHK5fKn9tw1lD1A4Wrqf2YSdpAAgN0s75ckGYN7dimYUq0e8niNomlLJhT82y47wkLw1zEg== X-Received: by 2002:a05:651c:2121:b0:2f7:cac8:9e38 with SMTP id 38308e7fff4ca-2fdaa904b12mr5960931fa.18.1730279365325; Wed, 30 Oct 2024 02:09:25 -0700 (PDT) Received: from sovereign (broadband-109-173-43-194.ip.moscow.rt.ru. [109.173.43.194]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2fd5366b163sm2034251fa.123.2024.10.30.02.09.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 02:09:23 -0700 (PDT) Date: Wed, 30 Oct 2024 12:09:20 +0300 From: Dmitry Kozlyuk To: Andre Muezerie Cc: dev@dpdk.org Subject: Re: [PATCH v3] doc: enhance build instructions on Windows Message-ID: <20241030120920.55303842@sovereign> In-Reply-To: <1730144749-25447-1-git-send-email-andremue@linux.microsoft.com> References: <20241027000318.6898e3c9@sovereign> <1730144749-25447-1-git-send-email-andremue@linux.microsoft.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2024-10-28 12:45 (UTC-0700), Andre Muezerie: > Enhance build instructions on Windows Commit messages should explain why the previous state had been problematic and how the new state solves the issues. For example: doc: modernize build instructions on Windows Meson 0.57 was an unstable version and is now outdated. The referenced bug in Meson 0.58 is fixed in stable releases. Recommend the latest stable release which is tested. ...likewise about command prompt changes... [...] > @@ -129,11 +126,23 @@ Depending on the distribution, paths in this file may need adjustments. > Option 3. Native Build on Windows using MSVC > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > -Open a 'Developer PowerShell for VS 2022' prompt from the start menu. > +Open a 'Visual Studio Developer Command Prompt'. > The developer prompt will configure the environment > to select the appropriate compiler, linker and SDK paths > required to build with Visual Studio 2022. > > +Windows 32-bit is currently not supported, so if your Visual Studio environment defaults > +to 32-bits you can instruct the toolset to produce 64-bit binaries using "-arch" parameter. > +For more details about the Developer Prompt options look at the `Visual Studio Developer > +Command Prompt and Developer PowerShell > +`_. > + > +.. code-block:: console > + > + "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=amd64 > + > +Compile the code from the developer prompt. > + > .. code-block:: console > > cd C:\Users\me\dpdk It will be unclear to the reader to which machine "32-bit" refers. Suggestion: Building DPDK applications that run on 32-bit Windows is currently not supported. If your Visual Studio environment defaults to producing 32-bit binaries... With the above corrections, Acked-by: Dmitry Kozlyuk