From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DBB5645C18; Wed, 30 Oct 2024 20:52:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6BC143274; Wed, 30 Oct 2024 20:52:19 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 9AB8942F2B for ; Wed, 30 Oct 2024 20:52:17 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7209415ca51so153317b3a.2 for ; Wed, 30 Oct 2024 12:52:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730317937; x=1730922737; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fwT9K9nbZVDqSDsthEc8ME193g56uNxOgu7NNdHmLBA=; b=AgqF9kLipgAQ6pLO0kKhj70fFxE6aNQ29M4VYUKiRcBsrtWPcYreFYK4BB9fLNuubT yOneNP+V8OYjFNqyQeUOrelInTjZAQUzlV90VRIgszo0mPhhMOdRVpRe3NdJtBZrgjOz /ftdzbkcvQtgtPIIc/PkxBe1CrFxSt3QyuKWcByp4OozIqLsB1XHFS2xfkdv/rEMHCKU MKLrJFDx028V4ETUhDhtiWTX76reSaQFqnWPqEmPYCYbrxuk9Mf2pJ099u+coh1k0Q36 qhY5HwkjzEZbSFfRUQkhcxSkoy4NHQ15W/SXqlqrqpcGUHeS5h3KxWsBWhI/rmkmBRl6 5zfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730317937; x=1730922737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fwT9K9nbZVDqSDsthEc8ME193g56uNxOgu7NNdHmLBA=; b=HlqWer9nIrglgh7iNDy7o4jcG5ZpInfVhLzu5EcasoViewVOd9jkQSJtzcqxKqXTDN Knqy/P4P+GGX2EZCV9M1IsbQ8bzu2pKnJMxY+0kWllE3rOpcQbREVYhJTwbbdMNa+V+9 KZjqpJN3c/HiicoGHlzkkR3o5FyBJClf28ZQd947ajLp1M+yMaJhVIcfu5bzhEtJsate a5sNJ/pbvDSTOLti7SXO2tNu0lGig8c3vcieIUp4nmu3A1Yj/0QGiRGFwiROYMnlKBsr gYfACAmbQDLEZKfNSCg9X4r3a/pYy6RiIOvL6Yh4Fq6Q/BFuyMDPNKfhVEKNoIW7FYtb PPww== X-Gm-Message-State: AOJu0Yxiew05v3pnGlxNhGDs6Uf+3wbfI9VST3ACBDqfn6fjTmk7Auyy n39QV97bNBd+xH2gffPGdPrGkjffnlU+P55QwDv35uoE4eyzkkAohBXAG46gGa0Rg+gC2wzoLtE B X-Google-Smtp-Source: AGHT+IF0CujCefQ3ViQAwWLckXuVjrNpqz11XWoNTW1YLCzMdK5U9mjo+JOuuPv/ecWjU6ZA4BMMoQ== X-Received: by 2002:a05:6a00:2288:b0:71e:75c0:2552 with SMTP id d2e1a72fcca58-720b99e63camr1270061b3a.0.1730317936475; Wed, 30 Oct 2024 12:52:16 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72057a1fc16sm9725244b3a.161.2024.10.30.12.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 12:52:16 -0700 (PDT) Date: Wed, 30 Oct 2024 12:52:14 -0700 From: Stephen Hemminger To: luca.boccassi@gmail.com Cc: dev@dpdk.org, david.marchand@redhat.com, roretzla@linux.microsoft.com Subject: Re: [PATCH] Revert "eal/unix: fix thread creation" Message-ID: <20241030125214.0274b37b@hermes.local> In-Reply-To: <20241030190945.409721-1-luca.boccassi@gmail.com> References: <20241030190945.409721-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 30 Oct 2024 19:08:41 +0000 luca.boccassi@gmail.com wrote: > From: Luca Boccassi > > This commit introduced a regression on arm64, causing a deadlock. > lcores_autotest gets stuck and never terminates: > > [ 1077s] EAL: Detected CPU lcores: 4 > [ 1077s] EAL: Detected NUMA nodes: 1 > [ 1077s] EAL: Detected shared linkage of DPDK > [ 1077s] EAL: Multi-process socket /tmp/dpdk/rte/mp_socket > [ 1077s] EAL: Selected IOVA mode 'VA' > [ 1077s] APP: HPET is not enabled, using TSC as default timer > [ 1077s] RTE>>lcores_autotest > [ 1127s] DPDK:fast-tests / lcores_autotest time out (After 50.0 seconds) > > This is 100% reproducible when running the fast tests suite > after a package build on OBS. Reverting it reliably fixes the > issue. > > This reverts commit b28c6196b132d1f25cb8c1bf781520fc41556b3a. > --- > I have bisected this long standing issue and identified the commit > that introduced it. If anybody can provide a different fix that would > be better, but if it's not possible to find another solution, it would > be good to revert it until it can be found, to resolve the regression. > > lib/eal/unix/rte_thread.c | 73 +++++++++++++++------------------------ > 1 file changed, 28 insertions(+), 45 deletions(-) Missing DCO (no Signed-off-by) which is required even for a Revert. Also Luca usually uses either Debian or Microsoft email address getting one from gmail is different and not in mailmap.