From: Stephen Hemminger <stephen@networkplumber.org>
To: 王颢 <howard_wang@realsil.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"pro_nic_dpdk@realtek.com" <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH v3 01/18] net/r8169: add PMD driver skeleton
Date: Thu, 31 Oct 2024 08:49:39 -0700 [thread overview]
Message-ID: <20241031084939.032cec9a@hermes.local> (raw)
In-Reply-To: <d5b1276677814fcc9e1430a877a8fc66@realsil.com.cn>
On Thu, 31 Oct 2024 07:47:51 +0000
王颢 <howard_wang@realsil.com.cn> wrote:
> Dear Stephen,
>
> I have modified the code related to braces in the latest patch. Recently, I was reviewing the DPDK Coding Style and found the reason why I initially removed the redundant braces. If symmetrical braces are required, it would be better to update the DPDK Coding Style accordingly.
>
> in https://doc.dpdk.org/guides/contributing/coding_style.html
> Braces that are not necessary should be left out.
>
> if (test)
> stmt;
> else if (bar) {
> stmt;
> stmt;
> } else
> stmt;
>
> Best Regards,
> Howard Wang
Thanks, the DPDK inherits DPDK from the Linux kernel, and the Linux kernel
community sometimes changes and adds things.
next prev parent reply other threads:[~2024-10-31 15:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 3:33 [PATCH v3 00/18] Modify some code as suggested by the maintainer Howard Wang
2024-10-23 3:33 ` [PATCH v3 01/18] net/r8169: add PMD driver skeleton Howard Wang
2024-10-23 5:17 ` Stephen Hemminger
2024-10-23 5:59 ` 答复: " 王颢
2024-10-23 6:16 ` Stephen Hemminger
2024-10-31 7:47 ` 答复: " 王颢
2024-10-31 15:49 ` Stephen Hemminger [this message]
2024-10-23 3:33 ` [PATCH v3 02/18] net/r8169: add logging structure Howard Wang
2024-10-23 3:33 ` [PATCH v3 03/18] net/r8169: add hardware registers access routines Howard Wang
2024-10-23 3:33 ` [PATCH v3 04/18] net/r8169: implement core logic for Tx/Rx Howard Wang
2024-10-23 3:33 ` [PATCH v3 05/18] net/r8169: add support for hw config Howard Wang
2024-10-23 3:33 ` [PATCH v3 06/18] net/r8169: add phy registers access routines Howard Wang
2024-10-23 3:33 ` [PATCH v3 07/18] net/r8169: add support for hardware operations Howard Wang
2024-10-23 3:33 ` [PATCH v3 08/18] net/r8169: add support for phy configuration Howard Wang
2024-10-23 3:33 ` [PATCH v3 09/18] net/r8169: add support for hw initialization Howard Wang
2024-10-23 3:33 ` [PATCH v3 10/18] net/r8169: add link status and interrupt management Howard Wang
2024-10-23 3:33 ` [PATCH v3 11/18] net/r8169: implement Rx path Howard Wang
2024-10-23 3:33 ` [PATCH v3 12/18] net/r8169: implement Tx path Howard Wang
2024-10-23 5:22 ` Stephen Hemminger
2024-10-23 3:33 ` [PATCH v3 13/18] net/r8169: implement device statistics Howard Wang
2024-10-23 3:33 ` [PATCH v3 14/18] net/r8169: implement promisc and allmulti modes Howard Wang
2024-10-23 3:33 ` [PATCH v3 15/18] net/r8169: impelment MTU configuration Howard Wang
2024-10-23 3:33 ` [PATCH v3 16/18] net/r8169: add support for getting fw version Howard Wang
2024-10-23 3:33 ` [PATCH v3 17/18] net/r8169: add driver_start and driver_stop Howard Wang
2024-10-23 3:33 ` [PATCH v3 18/18] doc/guides/nics: add documents for r8169 pmd Howard Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031084939.032cec9a@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).