From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63CCA45C24; Thu, 31 Oct 2024 16:49:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2EDF40273; Thu, 31 Oct 2024 16:49:44 +0100 (CET) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 7B2A94025A for ; Thu, 31 Oct 2024 16:49:44 +0100 (CET) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-7ede82dbb63so764547a12.2 for ; Thu, 31 Oct 2024 08:49:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730389783; x=1730994583; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=BrGwjAUkxWMLAXS1ND+ZZhCUkrsV6vJCZQcB0ma3wEM=; b=kvNQnIRw4Z19Sfcxa2sVigBVhgzqsgx1+ImVFOPXERdlM7fVN16QKKNBHSCK0bnV7U zj1YpoDtUiLoiJ2PITUozxTRfYsI1ffAHupS1sgvPN7By70POWFZtecp7qiPNRvM9Lhg wHxzpyPDEKfifhfLnKeUH+BtoU+yxM3KIh6q2qWI2hZO6cZySjCYI2QW0ob27r+0ndrj DpPbaF2zC0gak4iinQnafoBINZOqmEkZypcwAQvmvmj3w/EZTbWLlNxNyeOWx6D6hUWy yzLj3/JRzZLUtgGWRbFSapIvSFoR74/8gRXg6qn57wimNQBJWfLLD1TKfZN85QvU85qR qkpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730389783; x=1730994583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BrGwjAUkxWMLAXS1ND+ZZhCUkrsV6vJCZQcB0ma3wEM=; b=G6bX7nZHJa2ZD14gHwnf+gXkV6+1yElX3hYsGAztE4trv3AyAAKGtzAb25xVYHUWUb w69NXqd2Tc87KB0IytF0b1wou0lVGig7Fug/VSMSBmWkYBW3TilyCGMUFzUXnTKFl01J bdprfJKcGnl1ZesaKuVqwrbExjfdVeD+Xo4ZIKRRGJoGAMzg1BjsBdsJrGEdHoXXZQI+ 00e3cFP+HcXFaVRXrugpSeP1q7XMh9+hJoLJ35QQMt4sxIo034OBRIpwJ2r67jPptlup vWfsAp8f1UZbGLoXJI/cENyIf+u8Yofclo+K7ClvcHS/RQa4Mqrw9rA0t4V5rSzCXDeN onBg== X-Gm-Message-State: AOJu0YyBpiekemxrIhiypUslETqCBmc00We5jy0IH+X5a0Kf5pMTDFUq bUhcHKnP4y0HYuxYncHPS8/X/QXduIrpwDaI5EkZjpIcWTd96hmVoBCHhtiOENg= X-Google-Smtp-Source: AGHT+IFI7B2Whug11Neq4aLOFGn6Md+SgOSLJcu+f9ELUjMHp37+oKd8KxgmLvoafYPqcNDTIeaTxw== X-Received: by 2002:a05:6a20:6f02:b0:1d8:fcf2:9ce2 with SMTP id adf61e73a8af0-1dba5620c0dmr39765637.44.1730389783535; Thu, 31 Oct 2024 08:49:43 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc1b8920sm1274044b3a.6.2024.10.31.08.49.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 08:49:43 -0700 (PDT) Date: Thu, 31 Oct 2024 08:49:39 -0700 From: Stephen Hemminger To: =?UTF-8?B?546L6aKi?= Cc: "dev@dpdk.org" , "pro_nic_dpdk@realtek.com" Subject: Re: [PATCH v3 01/18] net/r8169: add PMD driver skeleton Message-ID: <20241031084939.032cec9a@hermes.local> In-Reply-To: References: <20241023033328.191827-1-howard_wang@realsil.com.cn> <20241023033328.191827-2-howard_wang@realsil.com.cn> <20241022221733.464ef6a4@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 31 Oct 2024 07:47:51 +0000 =E7=8E=8B=E9=A2=A2 wrote: > Dear Stephen, >=20 > I have modified the code related to braces in the latest patch. Recently,= I was reviewing the DPDK Coding Style and found the reason why I initially= removed the redundant braces. If symmetrical braces are required, it would= be better to update the DPDK Coding Style accordingly. >=20 > in https://doc.dpdk.org/guides/contributing/coding_style.html > Braces that are not necessary should be left out. >=20 > if (test) > stmt; > else if (bar) { > stmt; > stmt; > } else > stmt; >=20 > Best Regards, > Howard Wang Thanks, the DPDK inherits DPDK from the Linux kernel, and the Linux kernel community sometimes changes and adds things.