From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7508B45C22; Fri, 1 Nov 2024 03:56:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C87143283; Fri, 1 Nov 2024 03:56:36 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 7D42C40265 for ; Fri, 1 Nov 2024 03:56:35 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-71e592d7f6eso1208498b3a.3 for ; Thu, 31 Oct 2024 19:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730429794; x=1731034594; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=UtLPcQPurQbc1xru/5Nm0L+K5XqxmhnXY2qUNVNCDlI=; b=sEFjyLM/HxjJR8e/jqY1MLn9hXSLc6A/8OU3v/T6KX/5hXL/hcnS6SOKiDHPxeFVBO z4K6aEwlW2SB1S+XehWuf/kFSi7E6y+k0ycNMxvyOntfXgVdwdHmbXOa228OY8ceQ3/h lmle+xzpsBl139/2V3kgItWWzkf/79MuZohD4Mho0gZcmdq1gWCJZyQgWTwBs5/b76ik vmYZB8IeXekxxqSSP2tPSo5j8o8TMY8NmPFO7bcFp54Xv8MoUz7iNNsZJxc0zh89h/9G K1IjRLXD1N9uAy91HNArJtWlD+f/bDSyjWtMRE2llBp7P9GzKJrlepFgvKDD2N59FL9+ QZNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730429794; x=1731034594; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UtLPcQPurQbc1xru/5Nm0L+K5XqxmhnXY2qUNVNCDlI=; b=p9yQdbRAt8Eo02eiMZn2E41ut156jZAko/Iz43R4sHLMECwe3toAtMnMWY/tZUeOXr 8Y2NwpGVgupfDdk1jfyiCo3FCaTyzPkjrWKDomUia/RnZOSsTnq2HO16eShNqd2bZjhk 0sqjgYXlSb+ap4x2Sv1Okr0ff4MQPiqmVK9uA1ybnv9RROJMXtVi1KBocnBqNJ7CzRkb og1hGmkfEs/H/B5E7uJSkQtEf+fionFJ777Dj6pCr4TPLbIp4qmh1V1KlNU7JS6ndhyC ZY/WH6yzc3ZcPY6/8YylxbQPTlbDyhqYTYVnfh1aXwTRQQoCXBxFhvObjgsMVa06+WO8 qwLw== X-Forwarded-Encrypted: i=1; AJvYcCWfQQuxJQnR7oH/vCd5Zsq1iG2oglZMcB0GgrzpALyI9voVeOMWjUNZJcmqJoc1VoTYQQc=@dpdk.org X-Gm-Message-State: AOJu0Yzlw7NpAlTTUGadsSC7xmOG5IVVSgz1ZJ5zkFSuVMnH68aCIIDr eyI6T1nSPnnslUU+sClZ1Ou1jv7NNH2nhxEAij+8f0AMKR5DZwvHzqOaH+lqPOg= X-Google-Smtp-Source: AGHT+IH3TCIPajYNrcjeXlU1JwlKwQ02DHF5ikrOXfYo3802uZRj+2N1cA9DrvauW0O9dfN7jFl6Kg== X-Received: by 2002:a05:6a00:8d5:b0:71e:69e:596b with SMTP id d2e1a72fcca58-720c99b8091mr3189998b3a.17.1730429794585; Thu, 31 Oct 2024 19:56:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc3172f4sm1834415b3a.208.2024.10.31.19.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 19:56:34 -0700 (PDT) Date: Thu, 31 Oct 2024 19:56:32 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Jiawen Wu , dev@dpdk.org Subject: Re: [PATCH v2 06/13] net/txgbe: check length of Tx packets Message-ID: <20241031195632.1336a276@hermes.local> In-Reply-To: <402cfb9a-d84a-4bb6-919d-68c7b3ccc0f3@amd.com> References: <20241023064836.2017879-1-jiawenwu@trustnetic.com> <20241028023147.60157-1-jiawenwu@trustnetic.com> <20241028023147.60157-7-jiawenwu@trustnetic.com> <402cfb9a-d84a-4bb6-919d-68c7b3ccc0f3@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 1 Nov 2024 01:22:47 +0000 Ferruh Yigit wrote: > Hi Jiawen, > > Above are generic checks, we may add this function to ethdev driver > header (ethdev_driver.h) so that any PMD can use it, what do you think? This is in the fastpath, and additional checks should not be added there. Or at least put them under RTE_ETHDEV_DEBUG.