From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com, peng.zhang@corigine.com
Subject: Re: [PATCH v3 1/4] net/nfp: fix port index problem
Date: Thu, 31 Oct 2024 20:44:06 -0700 [thread overview]
Message-ID: <20241031204406.1b2ecc2c@hermes.local> (raw)
In-Reply-To: <20241101025713.290462-2-chaoyong.he@corigine.com>
On Fri, 1 Nov 2024 10:57:10 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:
> @@ -1022,6 +1025,7 @@ nfp_flower_pf_repr_alloc(struct nfp_net_hw_priv *hw_priv,
>
> /* Create a rte_eth_dev for PF vNIC representor */
> flower_repr->repr_type = NFP_REPR_TYPE_PF;
> + flower_repr->idx = 0;
That initialization does not look like it necessary since that structure
was initialized at start of the function. Might be better to put all the init
for the data structure there, to avoid confusion.
next prev parent reply other threads:[~2024-11-01 3:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-30 8:19 [PATCH 0/3] NFP PMD enhancement Chaoyong He
2024-10-30 8:19 ` [PATCH 1/3] net/nfp: extract function to check physical reprsentor Chaoyong He
2024-10-30 8:19 ` [PATCH 2/3] net/nfp: add support for EEPROM functions Chaoyong He
2024-10-30 8:19 ` [PATCH 3/3] net/nfp: add support for port identify Chaoyong He
2024-10-30 8:27 ` [PATCH 0/4] NFP PMD enhancement Chaoyong He
2024-10-30 8:27 ` [PATCH 1/4] net/nfp: fix port index problem Chaoyong He
2024-10-30 8:27 ` [PATCH 2/4] net/nfp: extract function to check physical reprsentor Chaoyong He
2024-10-30 8:27 ` [PATCH 3/4] net/nfp: add support for EEPROM functions Chaoyong He
2024-10-30 8:27 ` [PATCH 4/4] net/nfp: add support for port identify Chaoyong He
2024-11-01 2:57 ` [PATCH v3 0/4] NFP PMD enhancement Chaoyong He
2024-11-01 2:57 ` [PATCH v3 1/4] net/nfp: fix port index problem Chaoyong He
2024-11-01 3:44 ` Stephen Hemminger [this message]
2024-11-01 2:57 ` [PATCH v3 2/4] net/nfp: extract function to check physical reprsentor Chaoyong He
2024-11-01 2:57 ` [PATCH v3 3/4] net/nfp: add support for EEPROM functions Chaoyong He
2024-11-01 2:57 ` [PATCH v3 4/4] net/nfp: add support for port identify Chaoyong He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241031204406.1b2ecc2c@hermes.local \
--to=stephen@networkplumber.org \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).