From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6FE645C29; Fri, 1 Nov 2024 04:44:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C21D43283; Fri, 1 Nov 2024 04:44:12 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id B511F43283 for ; Fri, 1 Nov 2024 04:44:11 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2e2dcf4b153so1205068a91.1 for ; Thu, 31 Oct 2024 20:44:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1730432651; x=1731037451; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=t+fyRQPlRNREfonOwFS1UbKy+e0Nw7ADTglJ9c7wlQQ=; b=I5NB3h7iaDdAHA7cXqogiUH67oJHhQ2HgT6x/kW34o+HHTBEWiUYLqHIl9BhLgPH7t b+QJxBTDl/TRoC6DuNJGGaYUmiA64jhgN4jOzjmkWYfIJYu5bCuBYKWRh7u1hsFbAt7m IzCWFJpuis36/f3tUOgz8ydLI/PPawN99uIJh4Zyxb9oi/Ukc6uPRoO5g/qWcHJz1ks4 iUwd8VuF1NfKUYxb7cBydloSpQjSmb/nLthsJ/Ju3YsoITudVZ6GICJbvEzHW5fCS8SY nL328bG64Y6f0wVBRPQ/g0ja2+pElbz4/9t+IfJV1+Lsid2IO2q481+NJuvzwfelUVeH TWNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730432651; x=1731037451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t+fyRQPlRNREfonOwFS1UbKy+e0Nw7ADTglJ9c7wlQQ=; b=LaGGUPkwtaCvMndx7yqVPGeSEPWQE05zBy5M7tATRC5HzXLOPJQ5IXFqElv82NI/Xz 2V0bf0ggKQwhmbgB4LlRQ2tQ0ifrfF/XtKvlCpqVJboda2FxNPCLR15ZOBnVcCqIQX/T MUm3Rg3T1IvAWro5RLAKawlMnmVujTZWsqkp0sYPQlmdQu0PovzWbWy22SxLme63wHga aLouzExMPwOxZZITJQ25abki/huu5gf4ao4FreHY7EQZIZIQdqtbvySzrINxbbxV74C9 sNAF0UgejVA2zijjP8eZPnC9TtR6R21XnwmpJ/za2L47Ts6STKLNEgwOTdi9v0X9Fh9E RUlg== X-Gm-Message-State: AOJu0YyYXlmMKVKEGkt+zyqqL8C34i9OS69QLLe8QRDrOGBGY5/Wof70 5xvjsEql01O68YemDUbQkib5ABIBa+StHmzazmg7RBZAWULwQwDaebZZyqsMBSA= X-Google-Smtp-Source: AGHT+IFdTAR7E8Z1XKsBJ4eJjwk6hd0RCxcaTE9xJomOwgMtM5rhw+oIIlnpUZUsBRiTj4LLfCUalw== X-Received: by 2002:a17:90b:3b48:b0:2e8:f178:f668 with SMTP id 98e67ed59e1d1-2e92ce4f232mr10373381a91.11.1730432650743; Thu, 31 Oct 2024 20:44:10 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e93daac455sm2207698a91.19.2024.10.31.20.44.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Oct 2024 20:44:10 -0700 (PDT) Date: Thu, 31 Oct 2024 20:44:06 -0700 From: Stephen Hemminger To: Chaoyong He Cc: dev@dpdk.org, oss-drivers@corigine.com, peng.zhang@corigine.com Subject: Re: [PATCH v3 1/4] net/nfp: fix port index problem Message-ID: <20241031204406.1b2ecc2c@hermes.local> In-Reply-To: <20241101025713.290462-2-chaoyong.he@corigine.com> References: <20241030082759.209617-1-chaoyong.he@corigine.com> <20241101025713.290462-1-chaoyong.he@corigine.com> <20241101025713.290462-2-chaoyong.he@corigine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 1 Nov 2024 10:57:10 +0800 Chaoyong He wrote: > @@ -1022,6 +1025,7 @@ nfp_flower_pf_repr_alloc(struct nfp_net_hw_priv *hw_priv, > > /* Create a rte_eth_dev for PF vNIC representor */ > flower_repr->repr_type = NFP_REPR_TYPE_PF; > + flower_repr->idx = 0; That initialization does not look like it necessary since that structure was initialized at start of the function. Might be better to put all the init for the data structure there, to avoid confusion.